| Message ID | 20240711224850.1672662-1-quic_abhinavk@quicinc.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | drm/msm/dp: enable widebus on all relevant chipsets | expand |
On Thu, Jul 11, 2024 at 03:48:50PM GMT, Abhinav Kumar wrote: > Hardware document indicates that widebus is recommended on DP on all > MDSS chipsets starting version 5.x.x and above. > > Follow the guideline and mark widebus support on all relevant > chipsets for DP. > > Signed-off-by: Abhinav Kumar <quic_abhinavk@quicinc.com> > --- > drivers/gpu/drm/msm/dp/dp_display.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > Although it doesn't seem to fix the 4k screen corruption, I think it's still a proper patch (and we should be following hardware documentation). With the Fixes tags in place: Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
On 7/13/2024 3:55 PM, Dmitry Baryshkov wrote: > On Thu, Jul 11, 2024 at 03:48:50PM GMT, Abhinav Kumar wrote: >> Hardware document indicates that widebus is recommended on DP on all >> MDSS chipsets starting version 5.x.x and above. >> >> Follow the guideline and mark widebus support on all relevant >> chipsets for DP. >> >> Signed-off-by: Abhinav Kumar <quic_abhinavk@quicinc.com> >> --- >> drivers/gpu/drm/msm/dp/dp_display.c | 10 +++++----- >> 1 file changed, 5 insertions(+), 5 deletions(-) >> > > Although it doesn't seem to fix the 4k screen corruption, I think it's > still a proper patch (and we should be following hardware > documentation). > > With the Fixes tags in place: > > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > Thanks, I have added the Fixes tags and re-pushed. I have added only sm8650's tag and another change which re-used sc7180's dp_descs without retaining the widebus_supported bit. The reason I didnt add others is because widebus support itself was added only later to DP driver compared to the other ones. If I am missing any Fixes tag, pls let me know and I can fix it while applying.
diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c index 9622e58dce3e..e1228fb093ee 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -119,7 +119,7 @@ struct msm_dp_desc { }; static const struct msm_dp_desc sc7180_dp_descs[] = { - { .io_start = 0x0ae90000, .id = MSM_DP_CONTROLLER_0 }, + { .io_start = 0x0ae90000, .id = MSM_DP_CONTROLLER_0, .wide_bus_supported = true }, {} }; @@ -130,9 +130,9 @@ static const struct msm_dp_desc sc7280_dp_descs[] = { }; static const struct msm_dp_desc sc8180x_dp_descs[] = { - { .io_start = 0x0ae90000, .id = MSM_DP_CONTROLLER_0 }, - { .io_start = 0x0ae98000, .id = MSM_DP_CONTROLLER_1 }, - { .io_start = 0x0ae9a000, .id = MSM_DP_CONTROLLER_2 }, + { .io_start = 0x0ae90000, .id = MSM_DP_CONTROLLER_0, .wide_bus_supported = true }, + { .io_start = 0x0ae98000, .id = MSM_DP_CONTROLLER_1, .wide_bus_supported = true }, + { .io_start = 0x0ae9a000, .id = MSM_DP_CONTROLLER_2, .wide_bus_supported = true }, {} }; @@ -149,7 +149,7 @@ static const struct msm_dp_desc sc8280xp_dp_descs[] = { }; static const struct msm_dp_desc sm8650_dp_descs[] = { - { .io_start = 0x0af54000, .id = MSM_DP_CONTROLLER_0 }, + { .io_start = 0x0af54000, .id = MSM_DP_CONTROLLER_0, .wide_bus_supported = true }, {} };
Hardware document indicates that widebus is recommended on DP on all MDSS chipsets starting version 5.x.x and above. Follow the guideline and mark widebus support on all relevant chipsets for DP. Signed-off-by: Abhinav Kumar <quic_abhinavk@quicinc.com> --- drivers/gpu/drm/msm/dp/dp_display.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)