| Message ID | 20240718-x1e80100-dts-llcc-add-broadcastand_region-v1-1-20b6edf4557e@linaro.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | arm64: dts: qcom: sm8450: Add Broadcast_AND region in LLCC block | expand |
On 18.07.2024 12:20 PM, Abel Vesa wrote: > Add missing Broadcast_AND region to the LLCC block for x1e80100, > as the LLCC version on this platform is 4.1 and it provides the region. > > This also fixes the following error caused by the missing region: > > [ 3.797768] qcom-llcc 25000000.system-cache-controller: error -EINVAL: invalid resource (null) > > Fixes: af16b00578a7 ("arm64: dts: qcom: Add base X1E80100 dtsi and the QCP dts") > Signed-off-by: Abel Vesa <abel.vesa@linaro.org> > --- Please fix the commit title Konrad
On Thu, Jul 18, 2024 at 01:20:37PM +0200, Konrad Dybcio wrote: > On 18.07.2024 12:20 PM, Abel Vesa wrote: > > Add missing Broadcast_AND region to the LLCC block for x1e80100, > > as the LLCC version on this platform is 4.1 and it provides the region. > > > > This also fixes the following error caused by the missing region: > > > > [ 3.797768] qcom-llcc 25000000.system-cache-controller: error -EINVAL: invalid resource (null) Please say something about this error only showing up in linux-next, which has 055afc34fd21 ("soc: qcom: llcc: Add regmap for Broadcast_AND region" region")). > > Fixes: af16b00578a7 ("arm64: dts: qcom: Add base X1E80100 dtsi and the QCP dts") > > Signed-off-by: Abel Vesa <abel.vesa@linaro.org> > > --- > > Please fix the commit title And that. Johan
On 24-07-18 13:28:49, Johan Hovold wrote: > On Thu, Jul 18, 2024 at 01:20:37PM +0200, Konrad Dybcio wrote: > > On 18.07.2024 12:20 PM, Abel Vesa wrote: > > > Add missing Broadcast_AND region to the LLCC block for x1e80100, > > > as the LLCC version on this platform is 4.1 and it provides the region. > > > > > > This also fixes the following error caused by the missing region: > > > > > > [ 3.797768] qcom-llcc 25000000.system-cache-controller: error -EINVAL: invalid resource (null) > > Please say something about this error only showing up in linux-next, > which has 055afc34fd21 ("soc: qcom: llcc: Add regmap for Broadcast_AND region" > region")). Hm, now that I think of it, maybe I should drop the fixes tag altogether, as it fits more into the "new support" category strictly because of that commit you mentioned. > > > > Fixes: af16b00578a7 ("arm64: dts: qcom: Add base X1E80100 dtsi and the QCP dts") > > > Signed-off-by: Abel Vesa <abel.vesa@linaro.org> > > > --- > > > > Please fix the commit title > > And that. Yep. Will do. > > Johan
On Thu, Jul 18, 2024 at 03:45:54PM +0300, Abel Vesa wrote: > On 24-07-18 13:28:49, Johan Hovold wrote: > > On Thu, Jul 18, 2024 at 01:20:37PM +0200, Konrad Dybcio wrote: > > > On 18.07.2024 12:20 PM, Abel Vesa wrote: > > > > Add missing Broadcast_AND region to the LLCC block for x1e80100, > > > > as the LLCC version on this platform is 4.1 and it provides the region. > > > > > > > > This also fixes the following error caused by the missing region: > > > > > > > > [ 3.797768] qcom-llcc 25000000.system-cache-controller: error -EINVAL: invalid resource (null) > > > > Please say something about this error only showing up in linux-next, > > which has 055afc34fd21 ("soc: qcom: llcc: Add regmap for Broadcast_AND region" > > region")). > > Hm, now that I think of it, maybe I should drop the fixes tag > altogether, as it fits more into the "new support" category strictly > because of that commit you mentioned. Looks like you forgot to respin this one so that the error is now logged with mainline since 6.11 and commit 055afc34fd21 ("soc: qcom: llcc: Add regmap for Broadcast_AND region"): qcom-llcc 25000000.system-cache-controller: error -EINVAL: invalid resource (null) Can you please respin as soon as possible with an updated commit message and a CC stable tag to suppress the error? > > > > Fixes: af16b00578a7 ("arm64: dts: qcom: Add base X1E80100 dtsi and the QCP dts") > > > > Signed-off-by: Abel Vesa <abel.vesa@linaro.org> > > > > --- > > > > > > Please fix the commit title > > > > And that. > > Yep. Will do. Don't forget to update Subject. Johan
On 24-10-09 18:34:24, Johan Hovold wrote: > On Thu, Jul 18, 2024 at 03:45:54PM +0300, Abel Vesa wrote: > > On 24-07-18 13:28:49, Johan Hovold wrote: > > > On Thu, Jul 18, 2024 at 01:20:37PM +0200, Konrad Dybcio wrote: > > > > On 18.07.2024 12:20 PM, Abel Vesa wrote: > > > > > Add missing Broadcast_AND region to the LLCC block for x1e80100, > > > > > as the LLCC version on this platform is 4.1 and it provides the region. > > > > > > > > > > This also fixes the following error caused by the missing region: > > > > > > > > > > [ 3.797768] qcom-llcc 25000000.system-cache-controller: error -EINVAL: invalid resource (null) > > > > > > Please say something about this error only showing up in linux-next, > > > which has 055afc34fd21 ("soc: qcom: llcc: Add regmap for Broadcast_AND region" > > > region")). > > > > Hm, now that I think of it, maybe I should drop the fixes tag > > altogether, as it fits more into the "new support" category strictly > > because of that commit you mentioned. > > Looks like you forgot to respin this one so that the error is now logged > with mainline since 6.11 and commit 055afc34fd21 ("soc: qcom: llcc: Add > regmap for Broadcast_AND region"): > > qcom-llcc 25000000.system-cache-controller: error -EINVAL: invalid resource (null) > > Can you please respin as soon as possible with an updated commit message > and a CC stable tag to suppress the error? Sorry about the delay. Just sent the v2 now. https://lore.kernel.org/all/20241014-x1e80100-dts-llcc-add-broadcastand_region-v2-1-5ee6ac128627@linaro.org/ > > > > > > Fixes: af16b00578a7 ("arm64: dts: qcom: Add base X1E80100 dtsi and the QCP dts") > > > > > Signed-off-by: Abel Vesa <abel.vesa@linaro.org> > > > > > --- > > > > > > > > Please fix the commit title > > > > > > And that. > > > > Yep. Will do. > > Don't forget to update Subject. Done. > > Johan Thanks for reviewing. Abel
diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi index 7bca5fcd7d52..2cbc959fc878 100644 --- a/arch/arm64/boot/dts/qcom/x1e80100.dtsi +++ b/arch/arm64/boot/dts/qcom/x1e80100.dtsi @@ -5687,7 +5687,8 @@ system-cache-controller@25000000 { <0 0x25a00000 0 0x200000>, <0 0x25c00000 0 0x200000>, <0 0x25e00000 0 0x200000>, - <0 0x26000000 0 0x200000>; + <0 0x26000000 0 0x200000>, + <0 0x26200000 0 0x200000>; reg-names = "llcc0_base", "llcc1_base", "llcc2_base", @@ -5696,7 +5697,8 @@ system-cache-controller@25000000 { "llcc5_base", "llcc6_base", "llcc7_base", - "llcc_broadcast_base"; + "llcc_broadcast_base", + "llcc_broadcast_and_base"; interrupts = <GIC_SPI 266 IRQ_TYPE_LEVEL_HIGH>; };
Add missing Broadcast_AND region to the LLCC block for x1e80100, as the LLCC version on this platform is 4.1 and it provides the region. This also fixes the following error caused by the missing region: [ 3.797768] qcom-llcc 25000000.system-cache-controller: error -EINVAL: invalid resource (null) Fixes: af16b00578a7 ("arm64: dts: qcom: Add base X1E80100 dtsi and the QCP dts") Signed-off-by: Abel Vesa <abel.vesa@linaro.org> --- arch/arm64/boot/dts/qcom/x1e80100.dtsi | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) --- base-commit: 73399b58e5e5a1b28a04baf42e321cfcfc663c2f change-id: 20240718-x1e80100-dts-llcc-add-broadcastand_region-797413ee2a8f Best regards,