| Message ID | 20240719101238.199850-1-arnd@kernel.org (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Commit | dbd6bd124e34f9f859271ed9ae2afc39f36c7e8c |
| Headers | show |
| Series | soc: qcom: pd-mapper: mark qcom_pdm_domains as __maybe_unused | expand |
On Fri, Jul 19, 2024 at 12:12:31PM GMT, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > The qcom_pdm_domains[] array is used only when passing it into of_match_node() > but is not also referenced by MODULE_DEVICE_TABLE() or the platform driver > as a table. When CONFIG_OF is disabled, this causes a harmless build warning: > > drivers/soc/qcom/qcom_pd_mapper.c:520:34: error: 'qcom_pdm_domains' defined but not used [-Werror=unused-const-variable=] > > Avoid this by marking the variable as __maybe_unused. This also makes it > clear that anything referenced by it will be dropped by the compiler when > it is unused. > > Fixes: 1ebcde047c54 ("soc: qcom: add pd-mapper implementation") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/soc/qcom/qcom_pd_mapper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
On Fri, 19 Jul 2024 12:12:31 +0200, Arnd Bergmann wrote: > The qcom_pdm_domains[] array is used only when passing it into of_match_node() > but is not also referenced by MODULE_DEVICE_TABLE() or the platform driver > as a table. When CONFIG_OF is disabled, this causes a harmless build warning: > > drivers/soc/qcom/qcom_pd_mapper.c:520:34: error: 'qcom_pdm_domains' defined but not used [-Werror=unused-const-variable=] > > Avoid this by marking the variable as __maybe_unused. This also makes it > clear that anything referenced by it will be dropped by the compiler when > it is unused. > > [...] Applied, thanks! [1/1] soc: qcom: pd-mapper: mark qcom_pdm_domains as __maybe_unused commit: dbd6bd124e34f9f859271ed9ae2afc39f36c7e8c Best regards,
diff --git a/drivers/soc/qcom/qcom_pd_mapper.c b/drivers/soc/qcom/qcom_pd_mapper.c index a4c007080665..9afa09c3920e 100644 --- a/drivers/soc/qcom/qcom_pd_mapper.c +++ b/drivers/soc/qcom/qcom_pd_mapper.c @@ -517,7 +517,7 @@ static const struct qcom_pdm_domain_data *sm8550_domains[] = { NULL, }; -static const struct of_device_id qcom_pdm_domains[] = { +static const struct of_device_id qcom_pdm_domains[] __maybe_unused = { { .compatible = "qcom,apq8064", .data = NULL, }, { .compatible = "qcom,apq8074", .data = NULL, }, { .compatible = "qcom,apq8084", .data = NULL, },