| Message ID | 20240902104302.3959670-1-quic_tingguoc@quicinc.com (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | arm64: dts: qcom: sa8775p: pmic: enable rtc | expand |
On 02/09/2024 12:43, Tingguo Cheng wrote: > Add RTC node, the RTC is controlled by PMIC device via spmi bus. > > Signed-off-by: Tingguo Cheng <quic_tingguoc@quicinc.com> > --- > arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi b/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi > index 1369c3d43f86..47d05b897d5a 100644 > --- a/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi > +++ b/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi We achieved consensus allowing sa8775p to stay, but now Qualcomm changes point of view and insists on new approach of dropping sa8775p. Therefore this change does not make much sense in the new approach. Best regards, Krzysztof
On 9/6/2024 8:22 PM, Krzysztof Kozlowski wrote: > On 02/09/2024 12:43, Tingguo Cheng wrote: >> Add RTC node, the RTC is controlled by PMIC device via spmi bus. >> >> Signed-off-by: Tingguo Cheng <quic_tingguoc@quicinc.com> >> --- >> arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi b/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi >> index 1369c3d43f86..47d05b897d5a 100644 >> --- a/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi > > We achieved consensus allowing sa8775p to stay, but now Qualcomm changes > point of view and insists on new approach of dropping sa8775p. Therefore > this change does not make much sense in the new approach. > The new approach(QCS9100+sa8775p compatible) will still use the same PMIC chip(As usually, include sa8775p-pmics.dtsi as it's pmic part). Therefore, from this point, it does make sense in the new approach. From another point, for old boards, this change should have been there. > Best regards, > Krzysztof >
On 9/19/2024 10:23 AM, Tingguo Cheng wrote: > > > On 9/6/2024 8:22 PM, Krzysztof Kozlowski wrote: >> On 02/09/2024 12:43, Tingguo Cheng wrote: >>> Add RTC node, the RTC is controlled by PMIC device via spmi bus. >>> >>> Signed-off-by: Tingguo Cheng <quic_tingguoc@quicinc.com> >>> --- >>> arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi | 8 ++++++++ >>> 1 file changed, 8 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi b/arch/ >>> arm64/boot/dts/qcom/sa8775p-pmics.dtsi >>> index 1369c3d43f86..47d05b897d5a 100644 >>> --- a/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi >>> +++ b/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi >> >> We achieved consensus allowing sa8775p to stay, but now Qualcomm changes >> point of view and insists on new approach of dropping sa8775p. Therefore >> this change does not make much sense in the new approach. >> > The new approach(QCS9100+sa8775p compatible) will still use the same > PMIC chip(As usually, include sa8775p-pmics.dtsi as it's pmic part). > Therefore, from this point, it does make sense in the new approach. > From another point, for old boards, this change should have been there. > >> Best regards, >> Krzysztof >> > We have aligned this internally again, "sa8775p-pmics.dtsi" still continue to be used for qcs9100-ride. Can you help review/apply this change? We need this RTC function in some boards.
On Mon, Sep 02, 2024 at 06:43:02PM +0800, Tingguo Cheng wrote: > Add RTC node, the RTC is controlled by PMIC device via spmi bus. > > Signed-off-by: Tingguo Cheng <quic_tingguoc@quicinc.com> > --- > arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi | 8 ++++++++ > 1 file changed, 8 insertions(+) > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
On 11/22/2024 7:00 PM, Dmitry Baryshkov wrote: > On Mon, Sep 02, 2024 at 06:43:02PM +0800, Tingguo Cheng wrote: >> Add RTC node, the RTC is controlled by PMIC device via spmi bus. >> >> Signed-off-by: Tingguo Cheng <quic_tingguoc@quicinc.com> >> --- >> arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> > > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > Could you please help apply this patch?
On 16/01/2025 08:44, Tingguo Cheng wrote: > > > On 11/22/2024 7:00 PM, Dmitry Baryshkov wrote: >> On Mon, Sep 02, 2024 at 06:43:02PM +0800, Tingguo Cheng wrote: >>> Add RTC node, the RTC is controlled by PMIC device via spmi bus. >>> >>> Signed-off-by: Tingguo Cheng <quic_tingguoc@quicinc.com> >>> --- >>> arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi | 8 ++++++++ >>> 1 file changed, 8 insertions(+) >>> >> >> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> >> > Could you please help apply this patch? Check the patchwork, is it there? What is it its status? Maybe no need to ping people, because it will change nothing? Best regards, Krzysztof
diff --git a/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi b/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi index 1369c3d43f86..47d05b897d5a 100644 --- a/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi +++ b/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi @@ -132,6 +132,14 @@ pmm8654au_0_pon_resin: resin { }; }; + pmm8654au_0_rtc: rtc@6100 { + compatible = "qcom,pmk8350-rtc"; + reg = <0x6100>, <0x6200>; + reg-names = "rtc", "alarm"; + interrupts = <0x0 0x62 0x1 IRQ_TYPE_EDGE_RISING>; + allow-set-time; + }; + pmm8654au_0_gpios: gpio@8800 { compatible = "qcom,pmm8654au-gpio", "qcom,spmi-gpio"; reg = <0x8800>;
Add RTC node, the RTC is controlled by PMIC device via spmi bus. Signed-off-by: Tingguo Cheng <quic_tingguoc@quicinc.com> --- arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi | 8 ++++++++ 1 file changed, 8 insertions(+)