diff mbox series

clk: qcom: Make GCC_6125 depend on QCOM_GDSC

Message ID 20241003-topic-6125kconfig-v1-1-f5e1efbff07c@quicinc.com (mailing list archive)
State Accepted
Commit 04bad0c91743c8f3753c35750ffe4ddb1bf22489
Headers show
Series clk: qcom: Make GCC_6125 depend on QCOM_GDSC | expand

Commit Message

Konrad Dybcio Oct. 2, 2024, 11:16 p.m. UTC
From: Konrad Dybcio <quic_kdybcio@quicinc.com>

Like all other non-ancient Qualcomm clock drivers, QCOM_GDSC is
required, as the GCC driver defines and instantiates a bunch of GDSCs.

Add the missing dependency.

Reported-by: Kamil Gołda <kamil.golda@protonmail.com>
Signed-off-by: Konrad Dybcio <quic_kdybcio@quicinc.com>
---
 drivers/clk/qcom/Kconfig | 1 +
 1 file changed, 1 insertion(+)


---
base-commit: cea5425829f77e476b03702426f6b3701299b925
change-id: 20241003-topic-6125kconfig-647a38512867

Best regards,

Comments

Vladimir Zapolskiy Oct. 3, 2024, 8:05 a.m. UTC | #1
Hi Konrad,

On 10/3/24 02:16, Konrad Dybcio wrote:
> From: Konrad Dybcio <quic_kdybcio@quicinc.com>
> 
> Like all other non-ancient Qualcomm clock drivers, QCOM_GDSC is
> required, as the GCC driver defines and instantiates a bunch of GDSCs.
> 
> Add the missing dependency.
> 
> Reported-by: Kamil Gołda <kamil.golda@protonmail.com>
> Signed-off-by: Konrad Dybcio <quic_kdybcio@quicinc.com>

Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>

An identical change but for SM8150 GCC is also welcome.

--
Best wishes,
Vladimir
Bjorn Andersson Nov. 6, 2024, 12:53 a.m. UTC | #2
On Thu, 03 Oct 2024 01:16:27 +0200, Konrad Dybcio wrote:
> Like all other non-ancient Qualcomm clock drivers, QCOM_GDSC is
> required, as the GCC driver defines and instantiates a bunch of GDSCs.
> 
> Add the missing dependency.
> 
> 

Applied, thanks!

[1/1] clk: qcom: Make GCC_6125 depend on QCOM_GDSC
      commit: 04bad0c91743c8f3753c35750ffe4ddb1bf22489

Best regards,
diff mbox series

Patch

diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
index a3e2a09e2105b2f0a43afce7987fdd65f9b08c92..c6642d31707d01c33e9c0cee7100074e4cffc15b 100644
--- a/drivers/clk/qcom/Kconfig
+++ b/drivers/clk/qcom/Kconfig
@@ -987,6 +987,7 @@  config SM_GCC_6115
 config SM_GCC_6125
 	tristate "SM6125 Global Clock Controller"
 	depends on ARM64 || COMPILE_TEST
+	select QCOM_GDSC
 	help
 	  Support for the global clock controller on SM6125 devices.
 	  Say Y if you want to use peripheral devices such as UART,