| Message ID | 20241007130251.125022-2-lujianhua000@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2,1/3] arm64: dts: qcom: sm8250-xiaomi-elish: Add qca6390-pmu node | expand |
sorry, I forget to CC Dmitry Baryshkov. On Mon, Oct 07, 2024 at 09:02:50PM +0800, Jianhua Lu wrote: > Add wifi node and this wifi module is connected to pice port. > The following is qca6390 probe message: > ath11k_pci 0000:01:00.0: Adding to iommu group 12 > ath11k_pci 0000:01:00.0: BAR 0 [mem 0x60400000-0x604fffff 64bit]: assigned > ath11k_pci 0000:01:00.0: enabling device (0000 -> 0002) > ath11k_pci 0000:01:00.0: MSI vectors: 32 > ath11k_pci 0000:01:00.0: qca6390 hw2.0 > ath11k_pci 0000:01:00.0: chip_id 0x0 chip_family 0xb board_id 0xff soc_id 0xffffffff > ath11k_pci 0000:01:00.0: fw_version 0x10121492 fw_build_timestamp 2021-11-04 11:23 fw_build_id > > Signed-off-by: Jianhua Lu <lujianhua000@gmail.com> > --- > changes in v2: > 1. add ath11k-calibration-variant property. > > .../dts/qcom/sm8250-xiaomi-elish-common.dtsi | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi > index ebea283f56ea..7a55e271c3ac 100644 > --- a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi > @@ -680,6 +680,25 @@ &pcie0_phy { > status = "okay"; > }; > > +&pcieport0 { > + wifi@0 { > + compatible = "pci17cb,1101"; > + reg = <0x10000 0x0 0x0 0x0 0x0>; > + > + vddrfacmn-supply = <&vreg_pmu_rfa_cmn>; > + vddaon-supply = <&vreg_pmu_aon_0p59>; > + vddwlcx-supply = <&vreg_pmu_wlcx_0p8>; > + vddwlmx-supply = <&vreg_pmu_wlmx_0p85>; > + vddrfa0p8-supply = <&vreg_pmu_rfa_0p8>; > + vddrfa1p2-supply = <&vreg_pmu_rfa_1p2>; > + vddrfa1p7-supply = <&vreg_pmu_rfa_1p7>; > + vddpcie0p9-supply = <&vreg_pmu_pcie_0p9>; > + vddpcie1p8-supply = <&vreg_pmu_pcie_1p8>; > + > + qcom,ath11k-calibration-variant = "Xiaomi_Pad_5Pro"; > + }; > +}; > + > &pm8150_gpios { > vol_up_n: vol-up-n-state { > pins = "gpio6"; > -- > 2.46.0 >
On 10/7/2024 6:02 AM, Jianhua Lu wrote: > Add wifi node and this wifi module is connected to pice port. s/pici/pcie/ (or perhaps better: PCIe) > The following is qca6390 probe message: > ath11k_pci 0000:01:00.0: Adding to iommu group 12 > ath11k_pci 0000:01:00.0: BAR 0 [mem 0x60400000-0x604fffff 64bit]: assigned > ath11k_pci 0000:01:00.0: enabling device (0000 -> 0002) > ath11k_pci 0000:01:00.0: MSI vectors: 32 > ath11k_pci 0000:01:00.0: qca6390 hw2.0 > ath11k_pci 0000:01:00.0: chip_id 0x0 chip_family 0xb board_id 0xff soc_id 0xffffffff > ath11k_pci 0000:01:00.0: fw_version 0x10121492 fw_build_timestamp 2021-11-04 11:23 fw_build_id > > Signed-off-by: Jianhua Lu <lujianhua000@gmail.com> > --- > changes in v2: > 1. add ath11k-calibration-variant property. > > .../dts/qcom/sm8250-xiaomi-elish-common.dtsi | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi > index ebea283f56ea..7a55e271c3ac 100644 > --- a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi > @@ -680,6 +680,25 @@ &pcie0_phy { > status = "okay"; > }; > > +&pcieport0 { > + wifi@0 { > + compatible = "pci17cb,1101"; > + reg = <0x10000 0x0 0x0 0x0 0x0>; > + > + vddrfacmn-supply = <&vreg_pmu_rfa_cmn>; > + vddaon-supply = <&vreg_pmu_aon_0p59>; > + vddwlcx-supply = <&vreg_pmu_wlcx_0p8>; > + vddwlmx-supply = <&vreg_pmu_wlmx_0p85>; > + vddrfa0p8-supply = <&vreg_pmu_rfa_0p8>; > + vddrfa1p2-supply = <&vreg_pmu_rfa_1p2>; > + vddrfa1p7-supply = <&vreg_pmu_rfa_1p7>; > + vddpcie0p9-supply = <&vreg_pmu_pcie_0p9>; > + vddpcie1p8-supply = <&vreg_pmu_pcie_1p8>; > + > + qcom,ath11k-calibration-variant = "Xiaomi_Pad_5Pro"; Are you going to submit the board file per the guidance Dmitry provided? Note that I am not up to speed on the firmware/board maintenance procedures so we'll need to wait for Kalle to have bandwidth to handle the request (and show me how he handles it). /jeff
On Mon, Oct 07, 2024 at 11:40:48AM -0700, Jeff Johnson wrote: > On 10/7/2024 6:02 AM, Jianhua Lu wrote: > > Add wifi node and this wifi module is connected to pice port. > > s/pici/pcie/ (or perhaps better: PCIe) > Acked > > The following is qca6390 probe message: > > ath11k_pci 0000:01:00.0: Adding to iommu group 12 > > ath11k_pci 0000:01:00.0: BAR 0 [mem 0x60400000-0x604fffff 64bit]: assigned > > ath11k_pci 0000:01:00.0: enabling device (0000 -> 0002) > > ath11k_pci 0000:01:00.0: MSI vectors: 32 > > ath11k_pci 0000:01:00.0: qca6390 hw2.0 > > ath11k_pci 0000:01:00.0: chip_id 0x0 chip_family 0xb board_id 0xff soc_id 0xffffffff > > ath11k_pci 0000:01:00.0: fw_version 0x10121492 fw_build_timestamp 2021-11-04 11:23 fw_build_id > > > > Signed-off-by: Jianhua Lu <lujianhua000@gmail.com> > > --- > > changes in v2: > > 1. add ath11k-calibration-variant property. > > > > .../dts/qcom/sm8250-xiaomi-elish-common.dtsi | 19 +++++++++++++++++++ > > 1 file changed, 19 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi > > index ebea283f56ea..7a55e271c3ac 100644 > > --- a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi > > +++ b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi > > @@ -680,6 +680,25 @@ &pcie0_phy { > > status = "okay"; > > }; > > > > +&pcieport0 { > > + wifi@0 { > > + compatible = "pci17cb,1101"; > > + reg = <0x10000 0x0 0x0 0x0 0x0>; > > + > > + vddrfacmn-supply = <&vreg_pmu_rfa_cmn>; > > + vddaon-supply = <&vreg_pmu_aon_0p59>; > > + vddwlcx-supply = <&vreg_pmu_wlcx_0p8>; > > + vddwlmx-supply = <&vreg_pmu_wlmx_0p85>; > > + vddrfa0p8-supply = <&vreg_pmu_rfa_0p8>; > > + vddrfa1p2-supply = <&vreg_pmu_rfa_1p2>; > > + vddrfa1p7-supply = <&vreg_pmu_rfa_1p7>; > > + vddpcie0p9-supply = <&vreg_pmu_pcie_0p9>; > > + vddpcie1p8-supply = <&vreg_pmu_pcie_1p8>; > > + > > + qcom,ath11k-calibration-variant = "Xiaomi_Pad_5Pro"; > > Are you going to submit the board file per the guidance Dmitry provided? I want to get comment for this patch, then send board file. I have send board file to ath11k@lists.infradead.org now. > > Note that I am not up to speed on the firmware/board maintenance procedures so > we'll need to wait for Kalle to have bandwidth to handle the request (and show > me how he handles it). > > /jeff >
diff --git a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi index ebea283f56ea..7a55e271c3ac 100644 --- a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi @@ -680,6 +680,25 @@ &pcie0_phy { status = "okay"; }; +&pcieport0 { + wifi@0 { + compatible = "pci17cb,1101"; + reg = <0x10000 0x0 0x0 0x0 0x0>; + + vddrfacmn-supply = <&vreg_pmu_rfa_cmn>; + vddaon-supply = <&vreg_pmu_aon_0p59>; + vddwlcx-supply = <&vreg_pmu_wlcx_0p8>; + vddwlmx-supply = <&vreg_pmu_wlmx_0p85>; + vddrfa0p8-supply = <&vreg_pmu_rfa_0p8>; + vddrfa1p2-supply = <&vreg_pmu_rfa_1p2>; + vddrfa1p7-supply = <&vreg_pmu_rfa_1p7>; + vddpcie0p9-supply = <&vreg_pmu_pcie_0p9>; + vddpcie1p8-supply = <&vreg_pmu_pcie_1p8>; + + qcom,ath11k-calibration-variant = "Xiaomi_Pad_5Pro"; + }; +}; + &pm8150_gpios { vol_up_n: vol-up-n-state { pins = "gpio6";
Add wifi node and this wifi module is connected to pice port. The following is qca6390 probe message: ath11k_pci 0000:01:00.0: Adding to iommu group 12 ath11k_pci 0000:01:00.0: BAR 0 [mem 0x60400000-0x604fffff 64bit]: assigned ath11k_pci 0000:01:00.0: enabling device (0000 -> 0002) ath11k_pci 0000:01:00.0: MSI vectors: 32 ath11k_pci 0000:01:00.0: qca6390 hw2.0 ath11k_pci 0000:01:00.0: chip_id 0x0 chip_family 0xb board_id 0xff soc_id 0xffffffff ath11k_pci 0000:01:00.0: fw_version 0x10121492 fw_build_timestamp 2021-11-04 11:23 fw_build_id Signed-off-by: Jianhua Lu <lujianhua000@gmail.com> --- changes in v2: 1. add ath11k-calibration-variant property. .../dts/qcom/sm8250-xiaomi-elish-common.dtsi | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+)