Message ID | 20241014-add_display_support_for_qcs615-v1-1-4efa191dbdd4@quicinc.com (mailing list archive) |
---|---|
State | Changes Requested |
Headers | show |
Series | add_display_support_for_QCS615 | expand |
On Mon, Oct 14, 2024 at 05:47:27PM +0800, fangez via B4 Relay wrote: > From: lliu6 <quic_lliu6@quicinc.com> This is not the name > > Enable SX150X pinctrl driver. ... which is used for the abcdef board. > > Signed-off-by: lliu6 <quic_lliu6@quicinc.com> > --- > arch/arm64/configs/defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > index 76f3a6ee93e979e9e39cb0283699a2753b0dddf4..13ff005ebe0e9cfcf171b08add24465d0ab94f05 100644 > --- a/arch/arm64/configs/defconfig > +++ b/arch/arm64/configs/defconfig > @@ -630,6 +630,7 @@ CONFIG_PINCTRL_SM8350=y > CONFIG_PINCTRL_SM8450=y > CONFIG_PINCTRL_SM8550=y > CONFIG_PINCTRL_SM8650=y > +CONFIG_PINCTRL_SX150X=y > CONFIG_PINCTRL_X1E80100=y > CONFIG_PINCTRL_QCOM_SPMI_PMIC=y > CONFIG_PINCTRL_LPASS_LPI=m > > -- > 2.25.1 > >
On Mon, Oct 14, 2024 at 05:47:27PM +0800, fangez via B4 Relay wrote: > From: lliu6 <quic_lliu6@quicinc.com> > > Enable SX150X pinctrl driver. > > Signed-off-by: lliu6 <quic_lliu6@quicinc.com> Ok, even worse. fangez, you are not the author of the patches, so there is a missing S-o-B. > --- > arch/arm64/configs/defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > index 76f3a6ee93e979e9e39cb0283699a2753b0dddf4..13ff005ebe0e9cfcf171b08add24465d0ab94f05 100644 > --- a/arch/arm64/configs/defconfig > +++ b/arch/arm64/configs/defconfig > @@ -630,6 +630,7 @@ CONFIG_PINCTRL_SM8350=y > CONFIG_PINCTRL_SM8450=y > CONFIG_PINCTRL_SM8550=y > CONFIG_PINCTRL_SM8650=y > +CONFIG_PINCTRL_SX150X=y > CONFIG_PINCTRL_X1E80100=y > CONFIG_PINCTRL_QCOM_SPMI_PMIC=y > CONFIG_PINCTRL_LPASS_LPI=m > > -- > 2.25.1 > >
On 2024/10/14 18:12, Dmitry Baryshkov wrote: > On Mon, Oct 14, 2024 at 05:47:27PM +0800, fangez via B4 Relay wrote: >> From: lliu6 <quic_lliu6@quicinc.com> > > This is not the name sorry for the mistake. fixed in v2 > >> >> Enable SX150X pinctrl driver. > > ... which is used for the abcdef board. will remove this patch in v3 > >> >> Signed-off-by: lliu6 <quic_lliu6@quicinc.com> >> --- >> arch/arm64/configs/defconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig >> index 76f3a6ee93e979e9e39cb0283699a2753b0dddf4..13ff005ebe0e9cfcf171b08add24465d0ab94f05 100644 >> --- a/arch/arm64/configs/defconfig >> +++ b/arch/arm64/configs/defconfig >> @@ -630,6 +630,7 @@ CONFIG_PINCTRL_SM8350=y >> CONFIG_PINCTRL_SM8450=y >> CONFIG_PINCTRL_SM8550=y >> CONFIG_PINCTRL_SM8650=y >> +CONFIG_PINCTRL_SX150X=y >> CONFIG_PINCTRL_X1E80100=y >> CONFIG_PINCTRL_QCOM_SPMI_PMIC=y >> CONFIG_PINCTRL_LPASS_LPI=m >> >> -- >> 2.25.1 >> >> >
On 2024/10/14 18:37, Dmitry Baryshkov wrote: > On Mon, Oct 14, 2024 at 05:47:27PM +0800, fangez via B4 Relay wrote: >> From: lliu6 <quic_lliu6@quicinc.com> >> >> Enable SX150X pinctrl driver. >> >> Signed-off-by: lliu6 <quic_lliu6@quicinc.com> > > Ok, even worse. fangez, you are not the author of the patches, so there > is a missing S-o-B. Got it, fixed in v2 for other patches, and will remove the defconfig patch and I believe all items have been addressed. May I ask if we can start sending v3 now? > >> --- >> arch/arm64/configs/defconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig >> index 76f3a6ee93e979e9e39cb0283699a2753b0dddf4..13ff005ebe0e9cfcf171b08add24465d0ab94f05 100644 >> --- a/arch/arm64/configs/defconfig >> +++ b/arch/arm64/configs/defconfig >> @@ -630,6 +630,7 @@ CONFIG_PINCTRL_SM8350=y >> CONFIG_PINCTRL_SM8450=y >> CONFIG_PINCTRL_SM8550=y >> CONFIG_PINCTRL_SM8650=y >> +CONFIG_PINCTRL_SX150X=y >> CONFIG_PINCTRL_X1E80100=y >> CONFIG_PINCTRL_QCOM_SPMI_PMIC=y >> CONFIG_PINCTRL_LPASS_LPI=m >> >> -- >> 2.25.1 >> >> >
On Fri, 22 Nov 2024 at 09:57, fange zhang <quic_fangez@quicinc.com> wrote: > > > > On 2024/10/14 18:37, Dmitry Baryshkov wrote: > > On Mon, Oct 14, 2024 at 05:47:27PM +0800, fangez via B4 Relay wrote: > >> From: lliu6 <quic_lliu6@quicinc.com> > >> > >> Enable SX150X pinctrl driver. > >> > >> Signed-off-by: lliu6 <quic_lliu6@quicinc.com> > > > > Ok, even worse. fangez, you are not the author of the patches, so there > > is a missing S-o-B. > Got it, fixed in v2 for other patches, and will remove the defconfig patch > > and I believe all items have been addressed. May I ask if we can start > sending v3 now? Of course. > > > >> --- > >> arch/arm64/configs/defconfig | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > >> index 76f3a6ee93e979e9e39cb0283699a2753b0dddf4..13ff005ebe0e9cfcf171b08add24465d0ab94f05 100644 > >> --- a/arch/arm64/configs/defconfig > >> +++ b/arch/arm64/configs/defconfig > >> @@ -630,6 +630,7 @@ CONFIG_PINCTRL_SM8350=y > >> CONFIG_PINCTRL_SM8450=y > >> CONFIG_PINCTRL_SM8550=y > >> CONFIG_PINCTRL_SM8650=y > >> +CONFIG_PINCTRL_SX150X=y > >> CONFIG_PINCTRL_X1E80100=y > >> CONFIG_PINCTRL_QCOM_SPMI_PMIC=y > >> CONFIG_PINCTRL_LPASS_LPI=m > >> > >> -- > >> 2.25.1 > >> > >> > > >
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index 76f3a6ee93e979e9e39cb0283699a2753b0dddf4..13ff005ebe0e9cfcf171b08add24465d0ab94f05 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/arm64/configs/defconfig @@ -630,6 +630,7 @@ CONFIG_PINCTRL_SM8350=y CONFIG_PINCTRL_SM8450=y CONFIG_PINCTRL_SM8550=y CONFIG_PINCTRL_SM8650=y +CONFIG_PINCTRL_SX150X=y CONFIG_PINCTRL_X1E80100=y CONFIG_PINCTRL_QCOM_SPMI_PMIC=y CONFIG_PINCTRL_LPASS_LPI=m