| Message ID | 20241014-x1e80100-usb2-dwc3-set-dr-mode-host-v1-1-3baab3ad17d8@linaro.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | arm64: dts: qcom: x1e80100: Force host dr_mode for usb_2 controller | expand |
On 14/10/2024 16:14, Abel Vesa wrote: > The usb_2 controller has only a USB 2.0 PHY connected to it. There is no > USB 3.x PHY fot it. So since dual-role is not an option, explicitly set > the dr_mode to host to match the hardware. I don't follow, dual role is perfectly possible with USB2 only, where is the limitation ? Neil > > Signed-off-by: Abel Vesa <abel.vesa@linaro.org> > --- > arch/arm64/boot/dts/qcom/x1e80100.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi > index 0e6802c1d2d8375987c614ec69c440e2f38d25c6..4da13c8472392d842442193dc740027fa011ee1f 100644 > --- a/arch/arm64/boot/dts/qcom/x1e80100.dtsi > +++ b/arch/arm64/boot/dts/qcom/x1e80100.dtsi > @@ -4143,6 +4143,7 @@ usb_2_dwc3: usb@a200000 { > iommus = <&apps_smmu 0x14e0 0x0>; > phys = <&usb_2_hsphy>; > phy-names = "usb2-phy"; > + dr_mode = "host"; > maximum-speed = "high-speed"; > > ports { > > --- > base-commit: d61a00525464bfc5fe92c6ad713350988e492b88 > change-id: 20241014-x1e80100-usb2-dwc3-set-dr-mode-host-35312d1d25b2 > > Best regards,
On 24-10-14 17:48:37, neil.armstrong@linaro.org wrote: > On 14/10/2024 16:14, Abel Vesa wrote: > > The usb_2 controller has only a USB 2.0 PHY connected to it. There is no > > USB 3.x PHY fot it. So since dual-role is not an option, explicitly set > > the dr_mode to host to match the hardware. > > I don't follow, dual role is perfectly possible with USB2 only, where is the limitation ? You're right. USB2 could be OTG. Consider this patch dropped. > > Neil > > > > > Signed-off-by: Abel Vesa <abel.vesa@linaro.org> > > --- > > arch/arm64/boot/dts/qcom/x1e80100.dtsi | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi > > index 0e6802c1d2d8375987c614ec69c440e2f38d25c6..4da13c8472392d842442193dc740027fa011ee1f 100644 > > --- a/arch/arm64/boot/dts/qcom/x1e80100.dtsi > > +++ b/arch/arm64/boot/dts/qcom/x1e80100.dtsi > > @@ -4143,6 +4143,7 @@ usb_2_dwc3: usb@a200000 { > > iommus = <&apps_smmu 0x14e0 0x0>; > > phys = <&usb_2_hsphy>; > > phy-names = "usb2-phy"; > > + dr_mode = "host"; > > maximum-speed = "high-speed"; > > ports { > > > > --- > > base-commit: d61a00525464bfc5fe92c6ad713350988e492b88 > > change-id: 20241014-x1e80100-usb2-dwc3-set-dr-mode-host-35312d1d25b2 > > > > Best regards, > Thanks for reviewing. Abel
diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi index 0e6802c1d2d8375987c614ec69c440e2f38d25c6..4da13c8472392d842442193dc740027fa011ee1f 100644 --- a/arch/arm64/boot/dts/qcom/x1e80100.dtsi +++ b/arch/arm64/boot/dts/qcom/x1e80100.dtsi @@ -4143,6 +4143,7 @@ usb_2_dwc3: usb@a200000 { iommus = <&apps_smmu 0x14e0 0x0>; phys = <&usb_2_hsphy>; phy-names = "usb2-phy"; + dr_mode = "host"; maximum-speed = "high-speed"; ports {
The usb_2 controller has only a USB 2.0 PHY connected to it. There is no USB 3.x PHY fot it. So since dual-role is not an option, explicitly set the dr_mode to host to match the hardware. Signed-off-by: Abel Vesa <abel.vesa@linaro.org> --- arch/arm64/boot/dts/qcom/x1e80100.dtsi | 1 + 1 file changed, 1 insertion(+) --- base-commit: d61a00525464bfc5fe92c6ad713350988e492b88 change-id: 20241014-x1e80100-usb2-dwc3-set-dr-mode-host-35312d1d25b2 Best regards,