| Message ID | 20241017091447.41450-1-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | dt-bindings: mailbox: qcom,apcs-kpss-global: correct expected clocks for fallbacks | expand |
On Thu, 17 Oct 2024 11:14:47 +0200, Krzysztof Kozlowski wrote: > Commit 1e9cb7e007dc ("dt-bindings: mailbox: qcom,apcs-kpss-global: use > fallbacks") and commit 34d8775a0edc ("dt-bindings: mailbox: > qcom,apcs-kpss-global: use fallbacks for few variants") added fallbacks > to few existing compatibles. Neither devices with these existing > compatibles nor devices using fallbacks alone, have clocks, so the > "if:then:" block defining this constrain should be written as > "contains:". > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../bindings/mailbox/qcom,apcs-kpss-global.yaml | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-) > Acked-by: Rob Herring (Arm) <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml index 982c741e6225..9d2dfd85b207 100644 --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml @@ -165,12 +165,13 @@ allOf: - if: properties: compatible: - enum: - - qcom,msm8953-apcs-kpss-global - - qcom,msm8994-apcs-kpss-global - - qcom,msm8996-apcs-hmss-global - - qcom,qcm2290-apcs-hmss-global - - qcom,sdm845-apss-shared + contains: + enum: + - qcom,msm8953-apcs-kpss-global + - qcom,msm8994-apcs-kpss-global + - qcom,msm8996-apcs-hmss-global + - qcom,qcm2290-apcs-hmss-global + - qcom,sdm845-apss-shared then: properties: clocks: false
Commit 1e9cb7e007dc ("dt-bindings: mailbox: qcom,apcs-kpss-global: use fallbacks") and commit 34d8775a0edc ("dt-bindings: mailbox: qcom,apcs-kpss-global: use fallbacks for few variants") added fallbacks to few existing compatibles. Neither devices with these existing compatibles nor devices using fallbacks alone, have clocks, so the "if:then:" block defining this constrain should be written as "contains:". Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- .../bindings/mailbox/qcom,apcs-kpss-global.yaml | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-)