diff mbox series

[5/6] dt-bindings: clock: qcom: Add QCS8300 video clock controller

Message ID 20241018-qcs8300-mm-patches-v1-5-859095e0776c@quicinc.com (mailing list archive)
State Superseded
Headers show
Series Add support for GPUCC, CAMCC and VIDEOCC on Qualcomm QCS8300 platform | expand

Commit Message

Imran Shaik Oct. 18, 2024, 11:12 a.m. UTC
Add device tree bindings for the video clock controller on Qualcomm
QCS8300 platform.

Signed-off-by: Imran Shaik <quic_imrashai@quicinc.com>
---
 Documentation/devicetree/bindings/clock/qcom,sa8775p-videocc.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Rob Herring (Arm) Oct. 21, 2024, 6:16 p.m. UTC | #1
On Fri, Oct 18, 2024 at 04:42:33PM +0530, Imran Shaik wrote:
> Add device tree bindings for the video clock controller on Qualcomm
> QCS8300 platform.

That's obvious reading the diff. How is it different from the sa8775p 
version? It must be different or you should have a fallback compatible.

> 
> Signed-off-by: Imran Shaik <quic_imrashai@quicinc.com>
> ---
>  Documentation/devicetree/bindings/clock/qcom,sa8775p-videocc.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/clock/qcom,sa8775p-videocc.yaml b/Documentation/devicetree/bindings/clock/qcom,sa8775p-videocc.yaml
> index 928131bff4c1..07e5d811d816 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,sa8775p-videocc.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,sa8775p-videocc.yaml
> @@ -18,6 +18,7 @@ description: |
>  properties:
>    compatible:
>      enum:
> +      - qcom,qcs8300-videocc
>        - qcom,sa8775p-videocc
>  
>    clocks:
> 
> -- 
> 2.25.1
>
Imran Shaik Oct. 22, 2024, 4:31 a.m. UTC | #2
On 10/21/2024 11:46 PM, Rob Herring wrote:
> On Fri, Oct 18, 2024 at 04:42:33PM +0530, Imran Shaik wrote:
>> Add device tree bindings for the video clock controller on Qualcomm
>> QCS8300 platform.
> 
> That's obvious reading the diff. How is it different from the sa8775p
> version? It must be different or you should have a fallback compatible.
> 

The QCS8300 Video clock controller is mostly identical to SA8775P, but 
QCS8300 has minor difference. Hence, re-using the SA8775P VideoCC for 
QCS8300. I will update the commit text with the details and post next 
series.

Thanks,
Imran

>>
>> Signed-off-by: Imran Shaik <quic_imrashai@quicinc.com>
>> ---
>>   Documentation/devicetree/bindings/clock/qcom,sa8775p-videocc.yaml | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/clock/qcom,sa8775p-videocc.yaml b/Documentation/devicetree/bindings/clock/qcom,sa8775p-videocc.yaml
>> index 928131bff4c1..07e5d811d816 100644
>> --- a/Documentation/devicetree/bindings/clock/qcom,sa8775p-videocc.yaml
>> +++ b/Documentation/devicetree/bindings/clock/qcom,sa8775p-videocc.yaml
>> @@ -18,6 +18,7 @@ description: |
>>   properties:
>>     compatible:
>>       enum:
>> +      - qcom,qcs8300-videocc
>>         - qcom,sa8775p-videocc
>>   
>>     clocks:
>>
>> -- 
>> 2.25.1
>>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/clock/qcom,sa8775p-videocc.yaml b/Documentation/devicetree/bindings/clock/qcom,sa8775p-videocc.yaml
index 928131bff4c1..07e5d811d816 100644
--- a/Documentation/devicetree/bindings/clock/qcom,sa8775p-videocc.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,sa8775p-videocc.yaml
@@ -18,6 +18,7 @@  description: |
 properties:
   compatible:
     enum:
+      - qcom,qcs8300-videocc
       - qcom,sa8775p-videocc
 
   clocks: