| Message ID | 20241025121622.1496-1-johan+linaro@kernel.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | pinctrl: qcom: spmi: fix debugfs drive strength | expand |
On 25.10.2024 2:16 PM, Johan Hovold wrote: > Commit 723e8462a4fe ("pinctrl: qcom: spmi-gpio: Fix the GPIO strength > mapping") fixed a long-standing issue in the Qualcomm SPMI PMIC gpio > driver which had the 'low' and 'high' drive strength settings switched > but failed to update the debugfs interface which still gets this wrong. > > Fix the debugfs code so that the exported values match the hardware > settings. > > Note that this probably means that most devicetrees that try to describe > the firmware settings got this wrong if the settings were derived from > debugfs. Before the above mentioned commit the settings would have > actually matched the firmware settings even if they were described > incorrectly, but now they are inverted. > > Fixes: 723e8462a4fe ("pinctrl: qcom: spmi-gpio: Fix the GPIO strength mapping") > Fixes: eadff3024472 ("pinctrl: Qualcomm SPMI PMIC GPIO pin controller driver") > Cc: Anjelique Melendez <quic_amelende@quicinc.com> > Cc: stable@vger.kernel.org # 3.19 > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> Konrad
On Fri, Oct 25, 2024 at 2:17 PM Johan Hovold <johan+linaro@kernel.org> wrote: > Commit 723e8462a4fe ("pinctrl: qcom: spmi-gpio: Fix the GPIO strength > mapping") fixed a long-standing issue in the Qualcomm SPMI PMIC gpio > driver which had the 'low' and 'high' drive strength settings switched > but failed to update the debugfs interface which still gets this wrong. > > Fix the debugfs code so that the exported values match the hardware > settings. > > Note that this probably means that most devicetrees that try to describe > the firmware settings got this wrong if the settings were derived from > debugfs. Before the above mentioned commit the settings would have > actually matched the firmware settings even if they were described > incorrectly, but now they are inverted. > > Fixes: 723e8462a4fe ("pinctrl: qcom: spmi-gpio: Fix the GPIO strength mapping") > Fixes: eadff3024472 ("pinctrl: Qualcomm SPMI PMIC GPIO pin controller driver") > Cc: Anjelique Melendez <quic_amelende@quicinc.com> > Cc: stable@vger.kernel.org # 3.19 > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> Patch applied for fixes, thanks for digging into this Johan! Yours, Linus Walleij
diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c index 3d03293f6320..3a12304e2b7d 100644 --- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c +++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c @@ -667,7 +667,7 @@ static void pmic_gpio_config_dbg_show(struct pinctrl_dev *pctldev, "push-pull", "open-drain", "open-source" }; static const char *const strengths[] = { - "no", "high", "medium", "low" + "no", "low", "medium", "high" }; pad = pctldev->desc->pins[pin].drv_data;
Commit 723e8462a4fe ("pinctrl: qcom: spmi-gpio: Fix the GPIO strength mapping") fixed a long-standing issue in the Qualcomm SPMI PMIC gpio driver which had the 'low' and 'high' drive strength settings switched but failed to update the debugfs interface which still gets this wrong. Fix the debugfs code so that the exported values match the hardware settings. Note that this probably means that most devicetrees that try to describe the firmware settings got this wrong if the settings were derived from debugfs. Before the above mentioned commit the settings would have actually matched the firmware settings even if they were described incorrectly, but now they are inverted. Fixes: 723e8462a4fe ("pinctrl: qcom: spmi-gpio: Fix the GPIO strength mapping") Fixes: eadff3024472 ("pinctrl: Qualcomm SPMI PMIC GPIO pin controller driver") Cc: Anjelique Melendez <quic_amelende@quicinc.com> Cc: stable@vger.kernel.org # 3.19 Signed-off-by: Johan Hovold <johan+linaro@kernel.org> --- drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)