| Message ID | 20241030025046.303342-1-joe@pf.is.s.u-tokyo.ac.jp (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 54a8cd0f92068a3718092f68c8ae99e2078f44b6 |
| Headers | show |
| Series | soc: qcom: ice: Remove the device_link field in qcom_ice | expand |
On Wed, 30 Oct 2024 11:50:46 +0900, Joe Hattori wrote: > The struct device_link *link field in struct qcom_ice is only used to > store the result of a device_link_add call with the > DL_FLAG_AUTOREMOVE_SUPPLIER flag. With this flag, the resulting value > can only be used to check whether the link is present or not, as per the > device_link_add description, hence this commit removes the field. > > > [...] Applied, thanks! [1/1] soc: qcom: ice: Remove the device_link field in qcom_ice commit: 54a8cd0f92068a3718092f68c8ae99e2078f44b6 Best regards,
diff --git a/drivers/soc/qcom/ice.c b/drivers/soc/qcom/ice.c index fbab7fe5c652..8c71bd1efaa7 100644 --- a/drivers/soc/qcom/ice.c +++ b/drivers/soc/qcom/ice.c @@ -43,7 +43,6 @@ struct qcom_ice { struct device *dev; void __iomem *base; - struct device_link *link; struct clk *core_clk; }; @@ -268,6 +267,7 @@ struct qcom_ice *of_qcom_ice_get(struct device *dev) struct device_node *node; struct resource *res; void __iomem *base; + struct device_link *link; if (!dev || !dev->of_node) return ERR_PTR(-ENODEV); @@ -312,8 +312,8 @@ struct qcom_ice *of_qcom_ice_get(struct device *dev) goto out; } - ice->link = device_link_add(dev, &pdev->dev, DL_FLAG_AUTOREMOVE_SUPPLIER); - if (!ice->link) { + link = device_link_add(dev, &pdev->dev, DL_FLAG_AUTOREMOVE_SUPPLIER); + if (!link) { dev_err(&pdev->dev, "Failed to create device link to consumer %s\n", dev_name(dev));
The struct device_link *link field in struct qcom_ice is only used to store the result of a device_link_add call with the DL_FLAG_AUTOREMOVE_SUPPLIER flag. With this flag, the resulting value can only be used to check whether the link is present or not, as per the device_link_add description, hence this commit removes the field. Signed-off-by: Joe Hattori <joe@pf.is.s.u-tokyo.ac.jp> --- drivers/soc/qcom/ice.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)