| Message ID | 20241107-topic-sa8775_dma-v1-1-eb633e07b007@oss.qualcomm.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | arm64: dts: qcom: sa8775p: Use valid node names for GPI DMAs | expand |
On 7.11.2024 10:14 PM, Konrad Dybcio wrote: > From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> > > As pointed out by Intel's robot, the node name doesn't adhere to > dt-bindings. > > Fix errors like this one: > > qcs9100-ride.dtb: qcom,gpi-dma@800000: $nodename:0: 'qcom,gpi-dma@800000' does not match '^dma-controller(@.*)?$' > > Fixes: 34d17ccb5db8 ("arm64: dts: qcom: sa8775p: Add GPI configuration") > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202411080206.vFLRjIBZ-lkp@intel.com/ > Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> > --- > arch/arm64/boot/dts/qcom/sa8775p.dtsi | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi > index 9f315a51a7c14cd4116ec5a66a60285361d343f1..ebfa049515c63a0f1a333315dd370e6f78501129 100644 > --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi > +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi > @@ -854,7 +854,7 @@ ipcc: mailbox@408000 { > #mbox-cells = <2>; > }; > > - gpi_dma2: qcom,gpi-dma@800000 { > + gpi_dma2: dma-controller@800000 { > compatible = "qcom,sm6350-gpi-dma"; Now that I sent it, this also doesn't look right.. Konrad
On Thu, Nov 07, 2024 at 10:15:32PM +0100, Konrad Dybcio wrote: > On 7.11.2024 10:14 PM, Konrad Dybcio wrote: > > From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> > > > > As pointed out by Intel's robot, the node name doesn't adhere to > > dt-bindings. > > > > Fix errors like this one: > > > > qcs9100-ride.dtb: qcom,gpi-dma@800000: $nodename:0: 'qcom,gpi-dma@800000' does not match '^dma-controller(@.*)?$' > > > > Fixes: 34d17ccb5db8 ("arm64: dts: qcom: sa8775p: Add GPI configuration") > > Reported-by: kernel test robot <lkp@intel.com> > > Closes: https://lore.kernel.org/oe-kbuild-all/202411080206.vFLRjIBZ-lkp@intel.com/ > > Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> > > --- > > arch/arm64/boot/dts/qcom/sa8775p.dtsi | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi > > index 9f315a51a7c14cd4116ec5a66a60285361d343f1..ebfa049515c63a0f1a333315dd370e6f78501129 100644 > > --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi > > +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi > > @@ -854,7 +854,7 @@ ipcc: mailbox@408000 { > > #mbox-cells = <2>; > > }; > > > > - gpi_dma2: qcom,gpi-dma@800000 { > > + gpi_dma2: dma-controller@800000 { > > compatible = "qcom,sm6350-gpi-dma"; > > Now that I sent it, this also doesn't look right.. For the node renames: Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi index 9f315a51a7c14cd4116ec5a66a60285361d343f1..ebfa049515c63a0f1a333315dd370e6f78501129 100644 --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi @@ -854,7 +854,7 @@ ipcc: mailbox@408000 { #mbox-cells = <2>; }; - gpi_dma2: qcom,gpi-dma@800000 { + gpi_dma2: dma-controller@800000 { compatible = "qcom,sm6350-gpi-dma"; reg = <0x0 0x00800000 0x0 0x60000>; #dma-cells = <3>; @@ -1345,7 +1345,7 @@ &clk_virt SLAVE_QUP_CORE_2 QCOM_ICC_TAG_ALWAYS>, }; - gpi_dma0: qcom,gpi-dma@900000 { + gpi_dma0: dma-controller@900000 { compatible = "qcom,sm6350-gpi-dma"; reg = <0x0 0x00900000 0x0 0x60000>; #dma-cells = <3>; @@ -1770,7 +1770,7 @@ &clk_virt SLAVE_QUP_CORE_0 QCOM_ICC_TAG_ALWAYS>, }; }; - gpi_dma1: qcom,gpi-dma@a00000 { + gpi_dma1: dma-controller@a00000 { compatible = "qcom,sm6350-gpi-dma"; reg = <0x0 0x00a00000 0x0 0x60000>; #dma-cells = <3>; @@ -2225,7 +2225,7 @@ &config_noc SLAVE_QUP_1 QCOM_ICC_TAG_ALWAYS>, }; }; - gpi_dma3: qcom,gpi-dma@b00000 { + gpi_dma3: dma-controller@b00000 { compatible = "qcom,sm6350-gpi-dma"; reg = <0x0 0x00b00000 0x0 0x58000>; #dma-cells = <3>;