| Message ID | 20241123-asus_qcom_display-v2-4-a0bff8576024@hotmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Asus vivobook s15 improvements | expand |
On Sat, Nov 23, 2024 at 01:58:56PM +0100, Maud Spierings wrote: > Add bluetooth for the asus vivobook s15 > > Signed-off-by: Maud Spierings <maud_spierings@hotmail.com> > --- > .../boot/dts/qcom/x1e80100-asus-vivobook-s15.dts | 24 ++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts b/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts > index d0bee4b6fc0be6fe40d335f4d50dde495853b315..caf7509692db84c69ad375b5dd07054ac0adcb52 100644 > --- a/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts > +++ b/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts > @@ -18,6 +18,11 @@ / { > compatible = "asus,vivobook-s15", "qcom,x1e80100"; > chassis-type = "laptop"; > > + aliases { > + serial0 = &uart21; > + serial1 = &uart14; > + }; > + > gpio-keys { > compatible = "gpio-keys"; > pinctrl-0 = <&hall_int_n_default>; > @@ -545,6 +550,14 @@ &tlmm { > <44 4>, /* SPI (TPM) */ > <238 1>; /* UFS Reset */ > > + bt_en_default: bt-en-sleep { > + pins = "gpio116"; > + function = "gpio"; > + output-low; > + bias-disable; > + qcom,drive-strength = <16>; Hm? There is no such property for TLMM. Which node is it? > + }; > + > edp_reg_en: edp-reg-en-state { > pins = "gpio70"; > function = "gpio"; > @@ -624,6 +637,17 @@ tpad_default: tpad-default-state { > }; > }; > > +&uart14 { > + status = "okay"; Missing blank line > + bluetooth: bt_wcn7850 { Underscores are not allowed in node names. Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation Best regards, Krzysztof
diff --git a/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts b/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts index d0bee4b6fc0be6fe40d335f4d50dde495853b315..caf7509692db84c69ad375b5dd07054ac0adcb52 100644 --- a/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts +++ b/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts @@ -18,6 +18,11 @@ / { compatible = "asus,vivobook-s15", "qcom,x1e80100"; chassis-type = "laptop"; + aliases { + serial0 = &uart21; + serial1 = &uart14; + }; + gpio-keys { compatible = "gpio-keys"; pinctrl-0 = <&hall_int_n_default>; @@ -545,6 +550,14 @@ &tlmm { <44 4>, /* SPI (TPM) */ <238 1>; /* UFS Reset */ + bt_en_default: bt-en-sleep { + pins = "gpio116"; + function = "gpio"; + output-low; + bias-disable; + qcom,drive-strength = <16>; + }; + edp_reg_en: edp-reg-en-state { pins = "gpio70"; function = "gpio"; @@ -624,6 +637,17 @@ tpad_default: tpad-default-state { }; }; +&uart14 { + status = "okay"; + bluetooth: bt_wcn7850 { + compatible = "qcom,wcn7850-bt"; + pinctrl-names = "default"; + pinctrl-0 = <&bt_en_default>; + enable-gpios = <&tlmm 116 GPIO_ACTIVE_HIGH>; + max-speed = <3200000>; + }; +}; + &usb_1_ss0_hsphy { vdd-supply = <&vreg_l3j_0p8>; vdda12-supply = <&vreg_l2j_1p2>;