From patchwork Sat Nov 23 05:44:56 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Baryshkov X-Patchwork-Id: 13883758 Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com [209.85.208.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA46417DFEC for ; Sat, 23 Nov 2024 05:45:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732340711; cv=none; b=Ctg0ZKKqmde7DIlHpFdFCpsaaQGSvfUewjA8NRwZn+HXqV0jAlF28LNkiecQfpoSNAm1Ry2aLXHS+S0NW6jyYI/v0LfciKC1TIT2Stu5iNgTWsRA5UkHHzb2VezHBX3dzAVowwPxzxDWuAIjHJbfgNEjUnvN8d4gvj8F1Oq7kZw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732340711; c=relaxed/simple; bh=gdM2PmIA7KXreNC4e0p5DKW62M8digF3+8KzLk+7N4s=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=DkEx3ZkZQXLd0Mazs+hpWA5rx/XqNab0GJ/9K7qqKpN3p2k5xcp+2gPpbqlo9/C8CRLvujpOtn4KCOvAXXdnNSDpQPJ69enBJ/q/o3kdZZLXwd/lYsbiO0v8feOgb4+HVxr4KCHED1DhIwqp/CvFdXLhQzlznNTjj4HLas7mca8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Si3ed5fP; arc=none smtp.client-ip=209.85.208.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Si3ed5fP" Received: by mail-lj1-f179.google.com with SMTP id 38308e7fff4ca-2fb59652cb9so31455631fa.3 for ; Fri, 22 Nov 2024 21:45:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1732340707; x=1732945507; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=/hEtTqrfQSr9pI7m+IfwZIAeqdoTOG6+nBJQtRsFkFE=; b=Si3ed5fP8Jl1yKmDBEgE/N3AsJHJdM2K8JPCu4AC5mDd18vq9GFk4uhSbmWd50+ytf DCF9ixkD+4H5btZVMt6HqE3ukUvb5OCOLKSEYk5yDRJURtwjKHMNSNOdNg6vCT9WdnhQ 7F0WRgczkS2LYSDchN+rxTbiCqn6q25saBGdrbdPRYh7M9/jjhQc0SA0HQOOzsBSqIUp rosZPl8pnPAeZMxykuHIEpAw3Gb7OGZKAYDChdt6sPR5bGNoCf/kjFsd6npCcnNbuwS1 i258QwVUaspNyV0mTSMW98nRvwzrYcB5X8DKsvK14bogmM3GlBeJoGWyaw4DqVqLqwvk aC6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732340707; x=1732945507; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/hEtTqrfQSr9pI7m+IfwZIAeqdoTOG6+nBJQtRsFkFE=; b=MJRIcXRmzuo2i4JyCMZ9UAEEnNjhYu89Wsua2X2OYIPk6CmQaO8YlI5hxOkjOSlekF D+bqZWwEkRnTWYSqIwSV+P/Qwp0cuUIIZGvZ3wXK3dSVKJRd0E3mgGttos22SkS9O1Aj /5geBzx3egrKDHlEGqCkMMmzIhrIq33tE4bQH+W8ngnpICPwGu6VJgcSWTfm2HKBgldC NTMGf1jWdSbpP0CSyk2UVORRzpvGTx77v5sNftP0V/i6AF0SorF/m2IDLt1EAiW19Lbe 1302Jqc2bma9dxTOK7LzJ41TssqJEC3HDi/H1Q04nmWcRX5VX5FM93vQIXUneh+FcWXD 2BaQ== X-Forwarded-Encrypted: i=1; AJvYcCVUuhx8kcNoHwIeY5cBFMWXtws1bRqxe9btdavrQQIK4ukh42B9psLrEsC+rO606aHeeB8bhBqmEnwgGxph@vger.kernel.org X-Gm-Message-State: AOJu0YyqUScxB+Mu2A2FKfsrYCOZjYhKrWT0Lp9mj6AksG4irgTvu7tO yxoZpfgLM4NJ2h2mIlYMYGvPkNZpKnCVX/Ycwf7GC2ljN+q2kWVgu1rTFPNWp4dqM2yD9GFpbRv 3 X-Gm-Gg: ASbGncs+PV+RU+jXPGmcLk+iO1IBvatGJfadjB0AJ8ymlVSqZzfFkm9tzcxzqSktAwj IGM42PT2cXP/cJiblv0pn3nfaKXU1MqSjRX/XLqrB+xp5U4M6TfBGH/lYsttTeh4W3UbMtL1XoX sS6MkXigQ1ppQcDsH0JORC81xcLuPGwmxSLgGSj4+OFsKylXpx+I4ag3AjEZ8J0QAHemekZq96d 0SzjcHqHIPU60yDpIbFcXPV9t4ZFjd7YtOapezRHDtbdRLmLiolqxlQbg== X-Google-Smtp-Source: AGHT+IEJNfzSkuCdzOOYuqLdhThDbipynbQzrrmzQe+8Fcb8wjmn7htIVDE2uytHwA9HycVmGGo/ww== X-Received: by 2002:a05:6512:3a8d:b0:53d:dbec:9fca with SMTP id 2adb3069b0e04-53ddbeca289mr516396e87.0.1732340707412; Fri, 22 Nov 2024 21:45:07 -0800 (PST) Received: from umbar.lan ([192.130.178.90]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-53dd24457e1sm740143e87.34.2024.11.22.21.45.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Nov 2024 21:45:07 -0800 (PST) From: Dmitry Baryshkov Date: Sat, 23 Nov 2024 07:44:56 +0200 Subject: [PATCH v2 3/3] drm/msm/mdss: use boolean values for macrotile_mode Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20241123-msm-mdss-ubwc-v2-3-41344bc6ef9c@linaro.org> References: <20241123-msm-mdss-ubwc-v2-0-41344bc6ef9c@linaro.org> In-Reply-To: <20241123-msm-mdss-ubwc-v2-0-41344bc6ef9c@linaro.org> To: Rob Clark , Abhinav Kumar , Sean Paul , Marijn Suijten , Connor Abbott , David Airlie , Simona Vetter Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2536; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=gdM2PmIA7KXreNC4e0p5DKW62M8digF3+8KzLk+7N4s=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBnQWvaGO+Y6FoVYTBQaZpzt8UIWJKd7OgPZXoQb 1CWB/ILgCCJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZ0Fr2gAKCRCLPIo+Aiko 1aiHCACm2sH3vJTnYnx5BmVp1ztQ3EUYnPTFk6PpxdglQX8AeznE9hDRIEelD+LPW43iHWofTU6 pkI62suQqYHajFWAEqWMO18EwqVqy8xODNIIV0GBVjgYSpuWvZlSix4uU/5q/T/Kwi9ygdrhe2z sNdynfWUQE2Ey1w1uwdNpWI2v/n4ETEGp+y50kNNaroNRRgX0nJOy4Qt4zwdij2pr6Fg/QvqHi5 6DpG0F50H4ZDjhi8BmRCgHDpijcmR2jRVWR9JaGB2LlmjHrVbRK0IiWFItjDK72fIio18UrkFxZ Ek0kVpOmVc/k+s/ED6PQDFAFrTg+2vnXABrRLWw9SGP24yXx X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A The macrotile_mode is a flag, not a bit value. Use true/false values to set it rather than 1/0. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_mdss.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c index 2fdad0fa4bc159e9a10755da2c0402fd87734aee..2d9db179accb0fd8666fe80371ea44a1fcc15e1f 100644 --- a/drivers/gpu/drm/msm/msm_mdss.c +++ b/drivers/gpu/drm/msm/msm_mdss.c @@ -588,7 +588,7 @@ static const struct msm_mdss_data sa8775p_data = { .ubwc_swizzle = 4, .ubwc_bank_spread = true, .highest_bank_bit = 0, - .macrotile_mode = 1, + .macrotile_mode = true, .reg_bus_bw = 74000, }; @@ -607,7 +607,7 @@ static const struct msm_mdss_data sc7280_data = { .ubwc_swizzle = 6, .ubwc_bank_spread = true, .highest_bank_bit = 1, - .macrotile_mode = 1, + .macrotile_mode = true, .reg_bus_bw = 74000, }; @@ -615,7 +615,7 @@ static const struct msm_mdss_data sc8180x_data = { .ubwc_enc_version = UBWC_3_0, .ubwc_dec_version = UBWC_3_0, .highest_bank_bit = 3, - .macrotile_mode = 1, + .macrotile_mode = true, .reg_bus_bw = 76800, }; @@ -625,7 +625,7 @@ static const struct msm_mdss_data sc8280xp_data = { .ubwc_swizzle = 6, .ubwc_bank_spread = true, .highest_bank_bit = 3, - .macrotile_mode = 1, + .macrotile_mode = true, .reg_bus_bw = 76800, }; @@ -689,7 +689,7 @@ static const struct msm_mdss_data sm8250_data = { .ubwc_bank_spread = true, /* TODO: highest_bank_bit = 2 for LP_DDR4 */ .highest_bank_bit = 3, - .macrotile_mode = 1, + .macrotile_mode = true, .reg_bus_bw = 76800, }; @@ -700,7 +700,7 @@ static const struct msm_mdss_data sm8350_data = { .ubwc_bank_spread = true, /* TODO: highest_bank_bit = 2 for LP_DDR4 */ .highest_bank_bit = 3, - .macrotile_mode = 1, + .macrotile_mode = true, .reg_bus_bw = 74000, }; @@ -711,7 +711,7 @@ static const struct msm_mdss_data sm8550_data = { .ubwc_bank_spread = true, /* TODO: highest_bank_bit = 2 for LP_DDR4 */ .highest_bank_bit = 3, - .macrotile_mode = 1, + .macrotile_mode = true, .reg_bus_bw = 57000, }; @@ -722,7 +722,7 @@ static const struct msm_mdss_data x1e80100_data = { .ubwc_bank_spread = true, /* TODO: highest_bank_bit = 2 for LP_DDR4 */ .highest_bank_bit = 3, - .macrotile_mode = 1, + .macrotile_mode = true, /* TODO: Add reg_bus_bw with real value */ };