| Message ID | 20241204105249.3544114-4-quic_ziyuzhan@quicinc.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | pci: qcom: Add PCIe setting current load support | expand |
On Wed, Dec 04, 2024 at 06:52:49PM +0800, Ziyue Zhang wrote: > Add vdda-pll-max-microamp for vdda-pll-supply. The value of this property > is from the power grid guide. It is the maximum current the regulator can > provide. The property will be parsed by PCIe PHY driver to set the current > load. > > Signed-off-by: Ziyue Zhang <quic_ziyuzhan@quicinc.com> > --- > arch/arm64/boot/dts/qcom/qcs615-ride.dts | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/boot/dts/qcom/qcs615-ride.dts b/arch/arm64/boot/dts/qcom/qcs615-ride.dts > index 18f131ae9e07..6d93ef0d886b 100644 > --- a/arch/arm64/boot/dts/qcom/qcs615-ride.dts > +++ b/arch/arm64/boot/dts/qcom/qcs615-ride.dts > @@ -215,6 +215,7 @@ &pcie { > &pcie_phy { > vdda-phy-supply = <&vreg_l5a>; > vdda-pll-supply = <&vreg_l12a>; > + vdda-pll-max-microamp = <165000>; > Min uV of this regulator is 1800000: https://git.kernel.org/pub/scm/linux/kernel/git/qcom/linux.git/tree/arch/arm64/boot/dts/qcom/qcs615-ride.dts?h=for-next#n151 How can you set 165000? - Mani
在 12/11/2024 2:26 PM, Manivannan Sadhasivam 写道: > On Wed, Dec 04, 2024 at 06:52:49PM +0800, Ziyue Zhang wrote: >> Add vdda-pll-max-microamp for vdda-pll-supply. The value of this property >> is from the power grid guide. It is the maximum current the regulator can >> provide. The property will be parsed by PCIe PHY driver to set the current >> load. >> >> Signed-off-by: Ziyue Zhang <quic_ziyuzhan@quicinc.com> >> --- >> arch/arm64/boot/dts/qcom/qcs615-ride.dts | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/qcs615-ride.dts b/arch/arm64/boot/dts/qcom/qcs615-ride.dts >> index 18f131ae9e07..6d93ef0d886b 100644 >> --- a/arch/arm64/boot/dts/qcom/qcs615-ride.dts >> +++ b/arch/arm64/boot/dts/qcom/qcs615-ride.dts >> @@ -215,6 +215,7 @@ &pcie { >> &pcie_phy { >> vdda-phy-supply = <&vreg_l5a>; >> vdda-pll-supply = <&vreg_l12a>; >> + vdda-pll-max-microamp = <165000>; >> > Min uV of this regulator is 1800000: > https://git.kernel.org/pub/scm/linux/kernel/git/qcom/linux.git/tree/arch/arm64/boot/dts/qcom/qcs615-ride.dts?h=for-next#n151 > > How can you set 165000? > > - Mani Hi Mani the 165000 cames from the power grid guide, and it is 165000uA not uV BRs Ziyue >
On Wed, Dec 04, 2024 at 06:52:49PM +0800, Ziyue Zhang wrote: > Add vdda-pll-max-microamp for vdda-pll-supply. The value of this property > is from the power grid guide. It is the maximum current the regulator can > provide. The property will be parsed by PCIe PHY driver to set the current > load. > > Signed-off-by: Ziyue Zhang <quic_ziyuzhan@quicinc.com> > --- > arch/arm64/boot/dts/qcom/qcs615-ride.dts | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/boot/dts/qcom/qcs615-ride.dts b/arch/arm64/boot/dts/qcom/qcs615-ride.dts > index 18f131ae9e07..6d93ef0d886b 100644 > --- a/arch/arm64/boot/dts/qcom/qcs615-ride.dts > +++ b/arch/arm64/boot/dts/qcom/qcs615-ride.dts > @@ -215,6 +215,7 @@ &pcie { > &pcie_phy { > vdda-phy-supply = <&vreg_l5a>; > vdda-pll-supply = <&vreg_l12a>; > + vdda-pll-max-microamp = <165000>; It seems from the driver patch (patch 2/3) that you will apply this load-request at init and release it at exit, which I believe will hold the regulator at HPM always. If that's the case, why is vreg_l12a declared with regulator-allow-set-load and support LPM on this board? If the regulator needs to be in HPM on this board, remove regulator-allow-set-load and the LPM mode from the regulator. In fact, you (all of you) should remove all regulator-allow-set-load and LPM modes from the DT until you know what that implies - and then provide specific patches with clear description of the impact when you add it back. Regards, Bjorn > > status = "okay"; > }; > -- > 2.34.1 >
diff --git a/arch/arm64/boot/dts/qcom/qcs615-ride.dts b/arch/arm64/boot/dts/qcom/qcs615-ride.dts index 18f131ae9e07..6d93ef0d886b 100644 --- a/arch/arm64/boot/dts/qcom/qcs615-ride.dts +++ b/arch/arm64/boot/dts/qcom/qcs615-ride.dts @@ -215,6 +215,7 @@ &pcie { &pcie_phy { vdda-phy-supply = <&vreg_l5a>; vdda-pll-supply = <&vreg_l12a>; + vdda-pll-max-microamp = <165000>; status = "okay"; };
Add vdda-pll-max-microamp for vdda-pll-supply. The value of this property is from the power grid guide. It is the maximum current the regulator can provide. The property will be parsed by PCIe PHY driver to set the current load. Signed-off-by: Ziyue Zhang <quic_ziyuzhan@quicinc.com> --- arch/arm64/boot/dts/qcom/qcs615-ride.dts | 1 + 1 file changed, 1 insertion(+)