From patchwork Sat Dec 14 00:52:04 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 13908221 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF064219E0 for ; Sat, 14 Dec 2024 00:53:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734137595; cv=none; b=iBcEHvDxMZJ9/NPJTD3hVld4zjrLrMqJXhKjMGiufbOs/BnUjV5U8o7BcLiTFidJLerLfLSEE0DuqFU2UhmGFMOsf01qyEWFcztg8M5OOFIEmz6YQumU5uDDhgJZJnX8IqkZ0jFsg07FbCAp8V5xwDqtx4q7X1yQz0uOxw1HTvg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734137595; c=relaxed/simple; bh=V7gKntkQ8bwv+lZaockCmjTF5uEC8vW5YtYKvCaU2Ck=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CZubHULUU9+pMF3a5CwOqkOnAE7TX/YjTUHnE8PbYS2QtrjnJlVv8qt+YB896uN4SApBffpFBJkPKkeRE37z+pqBF/EIGjKOBhLm00yVJTd6mn7hpcf2s4sk/OQUe3UaH39qFkc2U7w+dOOEJxCfMYEJS9KhrZtRBDTJpIhTCMI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=oYcM4koi; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="oYcM4koi" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-2ee8e8e29f6so1784082a91.0 for ; Fri, 13 Dec 2024 16:53:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1734137593; x=1734742393; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=aUvE2f6iOzNwCrYNdrQY+FL/vDHn4ndwLWchPd2QhtQ=; b=oYcM4koiQzAZLEfY3lLfB8Eg/+jZLKhC+RDOkk0iMvD1IZ4szKZz7VsKMcxvQFEoMi 8SjDmFAT7VHHLV14kp9igz74bRjd2zw3H4vr0pZAtavzuSmwLFR7M0DgODsqdji9NfhN Bq8wYqP4cKeQFMpZ1sz0iVdaLhQs2PenGONpI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734137593; x=1734742393; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aUvE2f6iOzNwCrYNdrQY+FL/vDHn4ndwLWchPd2QhtQ=; b=OtyJZ7PtZ5pgegi6x+ka+tzG98WsP7YvTdX5DzWwwOiB9+H8ILzu76KVnIJdfzcV2o uxNkCRrYr1wNgoTwwPF81dNd2SSuWZOPoIp2NorcnPfYw56NpJakJtk9VmfK4jfbQPL/ 7XQaweoHKZ9H1nFDZM3lk7d5V2BPGtmSLGUM57CUHHwxGC69XnF71pjWUogVP/HKNYNL Wu9x0/tHiI1jewnpYAxqlIdhraI15fsv2aVcsz/klT+CPfNeN2vz7x+VMs7gs84W9qv4 hhJlB92Tekt2LynPE7v4ffRULMaABGLBZWppTniI5Lq1x6vs+8fDYCnoZZxpFQPG+WKx XHFw== X-Gm-Message-State: AOJu0Ywrwg3W/NVDowx6OcNOgqFKUCJmNWaDOzbhENpTK2y+jmJ0YfSM SpbUd8XiEB4QZY9MDsXlvqcFuLtVUvXtHbo/pdDienP9ViTLn4sfknDFuyIYiQ== X-Gm-Gg: ASbGncsxZiMQhhIivmyCKkIDW4JvbmIuxGGkOMF0CAjsYAZHU1mA/BjHcosxYbp1ykn /CoPXzcakxs2QV9iRWjYRI5oEU7nkupKXdehvZRtwy0+zLTGQOPFJ89EpiGxc2LmqGsqQinpi0y XmXDmXyfngTIJ/+bxr84xSUbuGC0OAgJIvDb58JOM5krgqfGxinOrtXkWBlFnLQVosWxH7Hb3d6 E9L+5Dy//8SrAenURCPgCCrW3PLF0fw4IIz2s5Uvg3V49QNbyG9C980K2aSR1Rw22nhRxyecrCI X-Google-Smtp-Source: AGHT+IGU2S6Z3GVHm0+57veKVF9GWyDASh7uUNfkbmZbC9Zjun4Gf1t3LPe02j8X69XemOFEZkD8aQ== X-Received: by 2002:a17:90b:3c02:b0:2ee:c9d8:d01a with SMTP id 98e67ed59e1d1-2f28fb63bf1mr6635097a91.11.1734137593296; Fri, 13 Dec 2024 16:53:13 -0800 (PST) Received: from dianders.sjc.corp.google.com ([2620:15c:9d:2:ae86:44a5:253c:f9bf]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2f142f9e186sm3788270a91.41.2024.12.13.16.53.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Dec 2024 16:53:12 -0800 (PST) From: Douglas Anderson To: Catalin Marinas , Will Deacon , Mark Rutland Cc: linux-arm-msm@vger.kernel.org, Jeffrey Hugo , Julius Werner , linux-arm-kernel@lists.infradead.org, Roxana Bradescu , Trilok Soni , bjorn.andersson@oss.qualcomm.com, Douglas Anderson , stable@vger.kernel.org, James Morse , linux-kernel@vger.kernel.org Subject: [PATCH v2 3/6] arm64: errata: Add QCOM_KRYO_4XX_GOLD to the spectre_bhb_k24_list Date: Fri, 13 Dec 2024 16:52:04 -0800 Message-ID: <20241213165201.v2.3.Ie4ef54abe02e7eb0eee50f830575719bf23bda48@changeid> X-Mailer: git-send-email 2.47.1.613.gc27f4b7a9f-goog In-Reply-To: <20241214005248.198803-1-dianders@chromium.org> References: <20241214005248.198803-1-dianders@chromium.org> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Qualcomm Kryo 400-series Gold cores appear to have a derivative of an ARM Cortex A76 in them. Since A76 needs Spectre mitigation via looping then the Kyro 400-series Gold cores also should need Spectre mitigation via looping. Fixes: 558c303c9734 ("arm64: Mitigate spectre style branch history side channels") Cc: stable@vger.kernel.org Signed-off-by: Douglas Anderson --- The "k" value here really should come from analysis by Qualcomm, but until we can get that analysis let's choose the same value as A76: 24. Ideally someone from Qualcomm can confirm that this mitigation is needed and confirm / provide the proper "k" value. ...or do people think that this should go in the k32 list to be safe. At least adding it to the list of CPUs we don't warn about seems like a good idea since it seems very unlikely that it needs a FW mitigation when the A76 it's based on doesn't. ...or should we just drop this until Qualcomm tells us the right "k" value here? Changes in v2: - Slight change to wording and notes of KRYO_4XX_GOLD patch arch/arm64/kernel/proton-pack.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/kernel/proton-pack.c b/arch/arm64/kernel/proton-pack.c index 012485b75019..04c3f0567999 100644 --- a/arch/arm64/kernel/proton-pack.c +++ b/arch/arm64/kernel/proton-pack.c @@ -887,6 +887,7 @@ u8 spectre_bhb_loop_affected(int scope) MIDR_ALL_VERSIONS(MIDR_CORTEX_A76), MIDR_ALL_VERSIONS(MIDR_CORTEX_A77), MIDR_ALL_VERSIONS(MIDR_NEOVERSE_N1), + MIDR_ALL_VERSIONS(MIDR_QCOM_KRYO_4XX_GOLD), {}, }; static const struct midr_range spectre_bhb_k11_list[] = {