| Message ID | 20250107-x1e80100-fix-usb2-controller-irqs-v1-1-4689aa9852a7@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 680421056216efe727ff4ed48f481691d5873b9e |
| Headers | show |
| Series | arm64: dts: qcom: x1e80100: Fix usb_2 controller interrupts | expand |
On Tue, Jan 07, 2025 at 03:15:16PM +0200, Abel Vesa wrote: > Back when the CRD support was brought up, the usb_2 controller didn't > have anything connected to it in order to test it properly, so it was > never enabled. > > On the Lenovo ThinkPad T14s, the usb_2 controller has the fingerprint > controller connected to it. So enabling it, proved that the interrupts > lines were wrong from the start. > > Fix both the pwr_event and the DWC ctrl_irq lines, according to > documentation. > > Fixes: 4af46b7bd66f ("arm64: dts: qcom: x1e80100: Add USB nodes") > Cc: stable@vger.kernel.org # 6.9 > Signed-off-by: Abel Vesa <abel.vesa@linaro.org> Reviewed-by: Johan Hovold <johan+linaro@kernel.org> Tested-by: Johan Hovold <johan+linaro@kernel.org>
On Tue, 07 Jan 2025 15:15:16 +0200, Abel Vesa wrote: > Back when the CRD support was brought up, the usb_2 controller didn't > have anything connected to it in order to test it properly, so it was > never enabled. > > On the Lenovo ThinkPad T14s, the usb_2 controller has the fingerprint > controller connected to it. So enabling it, proved that the interrupts > lines were wrong from the start. > > [...] Applied, thanks! [1/1] arm64: dts: qcom: x1e80100: Fix usb_2 controller interrupts commit: 680421056216efe727ff4ed48f481691d5873b9e Best regards,
diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi index e2f1873296ec7b7ffdb4c57b5c9d5b09368de168..1c3ad5ae0a41ea235cb176095cd49de7fa89ae4a 100644 --- a/arch/arm64/boot/dts/qcom/x1e80100.dtsi +++ b/arch/arm64/boot/dts/qcom/x1e80100.dtsi @@ -4631,7 +4631,7 @@ usb_2: usb@a2f8800 { <&gcc GCC_USB20_MASTER_CLK>; assigned-clock-rates = <19200000>, <200000000>; - interrupts-extended = <&intc GIC_SPI 240 IRQ_TYPE_LEVEL_HIGH>, + interrupts-extended = <&intc GIC_SPI 245 IRQ_TYPE_LEVEL_HIGH>, <&pdc 50 IRQ_TYPE_EDGE_BOTH>, <&pdc 49 IRQ_TYPE_EDGE_BOTH>; interrupt-names = "pwr_event", @@ -4657,7 +4657,7 @@ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>, usb_2_dwc3: usb@a200000 { compatible = "snps,dwc3"; reg = <0 0x0a200000 0 0xcd00>; - interrupts = <GIC_SPI 241 IRQ_TYPE_LEVEL_HIGH>; + interrupts = <GIC_SPI 240 IRQ_TYPE_LEVEL_HIGH>; iommus = <&apps_smmu 0x14e0 0x0>; phys = <&usb_2_hsphy>; phy-names = "usb2-phy";
Back when the CRD support was brought up, the usb_2 controller didn't have anything connected to it in order to test it properly, so it was never enabled. On the Lenovo ThinkPad T14s, the usb_2 controller has the fingerprint controller connected to it. So enabling it, proved that the interrupts lines were wrong from the start. Fix both the pwr_event and the DWC ctrl_irq lines, according to documentation. Fixes: 4af46b7bd66f ("arm64: dts: qcom: x1e80100: Add USB nodes") Cc: stable@vger.kernel.org # 6.9 Signed-off-by: Abel Vesa <abel.vesa@linaro.org> --- arch/arm64/boot/dts/qcom/x1e80100.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- base-commit: 7b4b9bf203da94fbeac75ed3116c84aa03e74578 change-id: 20250107-x1e80100-fix-usb2-controller-irqs-b226a747f73a Best regards,