| Message ID | 20250125035920.2651972-2-quic_mmanikan@quicinc.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | Add PCIe support for IPQ5424 | expand |
On Sat, Jan 25, 2025 at 09:29:17AM +0530, Manikanta Mylavarapu wrote: > Document the global interrupt found on IPQ5424 platform. > > Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@quicinc.com> > --- > Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > index 7235d6554cfb..1fd6aea08bf0 100644 > --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > @@ -49,11 +49,11 @@ properties: > > interrupts: > minItems: 1 > - maxItems: 8 > + maxItems: 9 > > interrupt-names: > minItems: 1 > - maxItems: 8 > + maxItems: 9 You just added it for few other devices as well, like sdm845. If you raise one part of constrain, then you need to correct each block where old constrain was implied. Best regards, Krzysztof
On 1/27/2025 12:55 PM, Krzysztof Kozlowski wrote: > On Sat, Jan 25, 2025 at 09:29:17AM +0530, Manikanta Mylavarapu wrote: >> Document the global interrupt found on IPQ5424 platform. >> >> Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@quicinc.com> >> --- >> Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 6 ++++-- >> 1 file changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml >> index 7235d6554cfb..1fd6aea08bf0 100644 >> --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml >> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml >> @@ -49,11 +49,11 @@ properties: >> >> interrupts: >> minItems: 1 >> - maxItems: 8 >> + maxItems: 9 >> >> interrupt-names: >> minItems: 1 >> - maxItems: 8 >> + maxItems: 9 > > You just added it for few other devices as well, like sdm845. If you > raise one part of constrain, then you need to correct each block where > old constrain was implied. > Hi Krzysztof, Thank you for reviewing the patch. I will explicitly set the maxItems for other devices like sdm845 and msm8996 based on the number of interrupts they support. This will ensure consistency across all devices. Please correct me if my understanding is wrong. Thanks & Regards, Manikanta.
On 27/01/2025 08:25, Krzysztof Kozlowski wrote: > On Sat, Jan 25, 2025 at 09:29:17AM +0530, Manikanta Mylavarapu wrote: >> Document the global interrupt found on IPQ5424 platform. >> >> Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@quicinc.com> >> --- >> Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 6 ++++-- >> 1 file changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml >> index 7235d6554cfb..1fd6aea08bf0 100644 >> --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml >> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml >> @@ -49,11 +49,11 @@ properties: >> >> interrupts: >> minItems: 1 >> - maxItems: 8 >> + maxItems: 9 >> >> interrupt-names: >> minItems: 1 >> - maxItems: 8 >> + maxItems: 9 > > You just added it for few other devices as well, like sdm845. If you > raise one part of constrain, then you need to correct each block where > old constrain was implied. And before you send new version, be 100% sure: 1. You observe the merge window 2. You sync with other people, so you finally stop sending the same multiple times. Including sending the same *MISTAKE* and asking for the same *REVIEW*. The conflicting work from the SAME company or even team is ridiculous. It is not the maintainer's task to coordinate your tasks and what your colleagues are sending! I am not going to review any Qualcomm PCI and PHY patches for the remaining time of merge window and the next week which is usually busy time for picking up patches. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml index 7235d6554cfb..1fd6aea08bf0 100644 --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml @@ -49,11 +49,11 @@ properties: interrupts: minItems: 1 - maxItems: 8 + maxItems: 9 interrupt-names: minItems: 1 - maxItems: 8 + maxItems: 9 iommu-map: minItems: 1 @@ -443,6 +443,7 @@ allOf: interrupts: minItems: 8 interrupt-names: + minItems: 8 items: - const: msi0 - const: msi1 @@ -452,6 +453,7 @@ allOf: - const: msi5 - const: msi6 - const: msi7 + - const: global - if: properties:
Document the global interrupt found on IPQ5424 platform. Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@quicinc.com> --- Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)