diff mbox series

[v3,12/13] ARM: dts: qcom: msm8926-htc-memul: Enable modem

Message ID 20250127-msm8226-modem-v3-12-67e968787eef@lucaweiss.eu (mailing list archive)
State Superseded
Headers show
Series Modem support for MSM8226 | expand

Commit Message

Luca Weiss Jan. 27, 2025, 10:45 p.m. UTC
Enable the modem found on the MSM8926 HTC One Mini 2.

Signed-off-by: Luca Weiss <luca@lucaweiss.eu>
---
 arch/arm/boot/dts/qcom/qcom-msm8926-htc-memul.dts | 10 ++++++++++
 1 file changed, 10 insertions(+)

Comments

Stephan Gerhold Jan. 28, 2025, 8:12 a.m. UTC | #1
On Mon, Jan 27, 2025 at 11:45:44PM +0100, Luca Weiss wrote:
> Enable the modem found on the MSM8926 HTC One Mini 2.
> 
> Signed-off-by: Luca Weiss <luca@lucaweiss.eu>

Reviewed-by: Stephan Gerhold <stephan.gerhold@linaro.org>

> ---
>  arch/arm/boot/dts/qcom/qcom-msm8926-htc-memul.dts | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/qcom/qcom-msm8926-htc-memul.dts b/arch/arm/boot/dts/qcom/qcom-msm8926-htc-memul.dts
> index d6eaa82cee4daf6a1386902f537f1351811d4a06..cb571aa13c11598182dc020f064fe8268bcc061f 100644
> --- a/arch/arm/boot/dts/qcom/qcom-msm8926-htc-memul.dts
> +++ b/arch/arm/boot/dts/qcom/qcom-msm8926-htc-memul.dts
> @@ -195,6 +195,16 @@ &blsp1_i2c6 {
>  	/* TPS61310 Flash/Torch @ 33 */
>  };
>  
> +&modem {
> +	mx-supply = <&pm8226_l3>;
> +	pll-supply = <&pm8226_l8>;
> +	mss-supply = <&pm8226_s5>;
> +
> +	firmware-name = "qcom/msm8926/memul/mba.b00", "qcom/msm8926/memul/modem.mdt";
> +
> +	status = "okay";
> +};
> +
>  &pm8226_vib {
>  	status = "okay";
>  };
> 
> -- 
> 2.48.1
>
Konrad Dybcio Jan. 28, 2025, 11:14 a.m. UTC | #2
On 27.01.2025 11:45 PM, Luca Weiss wrote:
> Enable the modem found on the MSM8926 HTC One Mini 2.
> 
> Signed-off-by: Luca Weiss <luca@lucaweiss.eu>
> ---
>  arch/arm/boot/dts/qcom/qcom-msm8926-htc-memul.dts | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/qcom/qcom-msm8926-htc-memul.dts b/arch/arm/boot/dts/qcom/qcom-msm8926-htc-memul.dts
> index d6eaa82cee4daf6a1386902f537f1351811d4a06..cb571aa13c11598182dc020f064fe8268bcc061f 100644
> --- a/arch/arm/boot/dts/qcom/qcom-msm8926-htc-memul.dts
> +++ b/arch/arm/boot/dts/qcom/qcom-msm8926-htc-memul.dts
> @@ -195,6 +195,16 @@ &blsp1_i2c6 {
>  	/* TPS61310 Flash/Torch @ 33 */
>  };
>  
> +&modem {
> +	mx-supply = <&pm8226_l3>;
> +	pll-supply = <&pm8226_l8>;
> +	mss-supply = <&pm8226_s5>;
> +
> +	firmware-name = "qcom/msm8926/memul/mba.b00", "qcom/msm8926/memul/modem.mdt";

mbn?

Konrad
Luca Weiss Jan. 28, 2025, 4:48 p.m. UTC | #3
On dinsdag 28 januari 2025 12:14:09 Midden-Europese standaardtijd Konrad 
Dybcio wrote:
> On 27.01.2025 11:45 PM, Luca Weiss wrote:
> > Enable the modem found on the MSM8926 HTC One Mini 2.
> > 
> > Signed-off-by: Luca Weiss <luca@lucaweiss.eu>
> > ---
> >  arch/arm/boot/dts/qcom/qcom-msm8926-htc-memul.dts | 10 ++++++++++
> >  1 file changed, 10 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/qcom/qcom-msm8926-htc-memul.dts b/arch/arm/
boot/dts/qcom/qcom-msm8926-htc-memul.dts
> > index 
d6eaa82cee4daf6a1386902f537f1351811d4a06..cb571aa13c11598182dc020f064fe8268bcc061f 
100644
> > --- a/arch/arm/boot/dts/qcom/qcom-msm8926-htc-memul.dts
> > +++ b/arch/arm/boot/dts/qcom/qcom-msm8926-htc-memul.dts
> > @@ -195,6 +195,16 @@ &blsp1_i2c6 {
> >  	/* TPS61310 Flash/Torch @ 33 */
> >  };
> >  
> > +&modem {
> > +	mx-supply = <&pm8226_l3>;
> > +	pll-supply = <&pm8226_l8>;
> > +	mss-supply = <&pm8226_s5>;
> > +
> > +	firmware-name = "qcom/msm8926/memul/mba.b00", "qcom/msm8926/memul/
modem.mdt";
> 
> mbn?

The mba gets loaded with .b00 for some reason, not even the .mdt.

And at least on this device the .mbn doesn't work at all either, but this 
might be due to very weird firmware loading on this board - because also for 
loading wcnss firmware I needed to add a quite weird hack to make it load.

Modem fortunately loads fine like this.

Regards
Luca

> 
> Konrad
>
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/qcom/qcom-msm8926-htc-memul.dts b/arch/arm/boot/dts/qcom/qcom-msm8926-htc-memul.dts
index d6eaa82cee4daf6a1386902f537f1351811d4a06..cb571aa13c11598182dc020f064fe8268bcc061f 100644
--- a/arch/arm/boot/dts/qcom/qcom-msm8926-htc-memul.dts
+++ b/arch/arm/boot/dts/qcom/qcom-msm8926-htc-memul.dts
@@ -195,6 +195,16 @@  &blsp1_i2c6 {
 	/* TPS61310 Flash/Torch @ 33 */
 };
 
+&modem {
+	mx-supply = <&pm8226_l3>;
+	pll-supply = <&pm8226_l8>;
+	mss-supply = <&pm8226_s5>;
+
+	firmware-name = "qcom/msm8926/memul/mba.b00", "qcom/msm8926/memul/modem.mdt";
+
+	status = "okay";
+};
+
 &pm8226_vib {
 	status = "okay";
 };