| Message ID | 20250209-dpu-v1-1-0db666884f70@ethancedwards.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | drm/msm/dpu: Fix uninitialized variable | expand |
On Sun, Feb 09, 2025 at 10:32:33PM -0500, Ethan Carter Edwards wrote: > There is a possibility for an uninitialized *ret* variable to be > returned in some code paths. > > Fix this by initializing *ret* to 0. > > Addresses-Coverity-ID: 1642546 ("Uninitialized scalar variable") > Fixes: 774bcfb731765d ("drm/msm/dpu: add support for virtual planes") > Signed-off-by: Ethan Carter Edwards <ethan@ethancedwards.com> > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c > index 098abc2c0003cde90ce6219c97ee18fa055a92a5..74edaa9ecee72111b70f32b832486aeebe545a28 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c > @@ -1164,7 +1164,7 @@ int dpu_assign_plane_resources(struct dpu_global_state *global_state, > unsigned int num_planes) > { > unsigned int i; > - int ret; > + int ret = 0; Thanks, but I think it better to make the function return ret from within the loop and return explicit 0 if there was no error. > > for (i = 0; i < num_planes; i++) { > struct drm_plane_state *plane_state = states[i]; > > --- > base-commit: a64dcfb451e254085a7daee5fe51bf22959d52d3 > change-id: 20250209-dpu-c3fac78fc617 > > Best regards, > -- > Ethan Carter Edwards <ethan@ethancedwards.com> >
On 25/02/10 05:41AM, Dmitry Baryshkov wrote: > On Sun, Feb 09, 2025 at 10:32:33PM -0500, Ethan Carter Edwards wrote: > > There is a possibility for an uninitialized *ret* variable to be > > returned in some code paths. > > > > Fix this by initializing *ret* to 0. > > > > Addresses-Coverity-ID: 1642546 ("Uninitialized scalar variable") > > Fixes: 774bcfb731765d ("drm/msm/dpu: add support for virtual planes") > > Signed-off-by: Ethan Carter Edwards <ethan@ethancedwards.com> > > --- > > drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c > > index 098abc2c0003cde90ce6219c97ee18fa055a92a5..74edaa9ecee72111b70f32b832486aeebe545a28 100644 > > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c > > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c > > @@ -1164,7 +1164,7 @@ int dpu_assign_plane_resources(struct dpu_global_state *global_state, > > unsigned int num_planes) > > { > > unsigned int i; > > - int ret; > > + int ret = 0; > > Thanks, but I think it better to make the function return ret from > within the loop and return explicit 0 if there was no error. Will do, v2 incoming... > > > > > for (i = 0; i < num_planes; i++) { > > struct drm_plane_state *plane_state = states[i]; > > > > --- > > base-commit: a64dcfb451e254085a7daee5fe51bf22959d52d3 > > change-id: 20250209-dpu-c3fac78fc617 > > > > Best regards, > > -- > > Ethan Carter Edwards <ethan@ethancedwards.com> > > > > -- > With best wishes > Dmitry
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c index 098abc2c0003cde90ce6219c97ee18fa055a92a5..74edaa9ecee72111b70f32b832486aeebe545a28 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c @@ -1164,7 +1164,7 @@ int dpu_assign_plane_resources(struct dpu_global_state *global_state, unsigned int num_planes) { unsigned int i; - int ret; + int ret = 0; for (i = 0; i < num_planes; i++) { struct drm_plane_state *plane_state = states[i];
There is a possibility for an uninitialized *ret* variable to be returned in some code paths. Fix this by initializing *ret* to 0. Addresses-Coverity-ID: 1642546 ("Uninitialized scalar variable") Fixes: 774bcfb731765d ("drm/msm/dpu: add support for virtual planes") Signed-off-by: Ethan Carter Edwards <ethan@ethancedwards.com> --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- base-commit: a64dcfb451e254085a7daee5fe51bf22959d52d3 change-id: 20250209-dpu-c3fac78fc617 Best regards,