| Message ID | 20250217-sar2130p-pci-v1-4-94b20ec70a14@linaro.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | PCI: qcom-ep: add support for using the EP on SAR2130P and SM8450 | expand |
On Mon, Feb 17, 2025 at 08:56:16PM +0200, Dmitry Baryshkov wrote: > Enable PCIe endpoint support for the Qualcomm SAR2130P platform. > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > drivers/pci/controller/dwc/pcie-qcom-ep.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pci/controller/dwc/pcie-qcom-ep.c b/drivers/pci/controller/dwc/pcie-qcom-ep.c > index c08f64d7a825fa5da22976c8020f96ee5faa5462..dec5675c7c9d52b77f084ae139845b488fa02d2c 100644 > --- a/drivers/pci/controller/dwc/pcie-qcom-ep.c > +++ b/drivers/pci/controller/dwc/pcie-qcom-ep.c > @@ -933,6 +933,7 @@ static const struct of_device_id qcom_pcie_ep_match[] = { > { .compatible = "qcom,sa8775p-pcie-ep", .data = &cfg_1_34_0}, > { .compatible = "qcom,sdx55-pcie-ep", }, > { .compatible = "qcom,sm8450-pcie-ep", }, > + { .compatible = "qcom,sar2130p-pcie-ep", }, Could you please use a fallback? I'd prefer to not add compatible to the driver unless it requires special config. - Mani
On Thu, Feb 20, 2025 at 12:53:10PM +0530, Manivannan Sadhasivam wrote: > On Mon, Feb 17, 2025 at 08:56:16PM +0200, Dmitry Baryshkov wrote: > > Enable PCIe endpoint support for the Qualcomm SAR2130P platform. > > > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > --- > > drivers/pci/controller/dwc/pcie-qcom-ep.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/pci/controller/dwc/pcie-qcom-ep.c b/drivers/pci/controller/dwc/pcie-qcom-ep.c > > index c08f64d7a825fa5da22976c8020f96ee5faa5462..dec5675c7c9d52b77f084ae139845b488fa02d2c 100644 > > --- a/drivers/pci/controller/dwc/pcie-qcom-ep.c > > +++ b/drivers/pci/controller/dwc/pcie-qcom-ep.c > > @@ -933,6 +933,7 @@ static const struct of_device_id qcom_pcie_ep_match[] = { > > { .compatible = "qcom,sa8775p-pcie-ep", .data = &cfg_1_34_0}, > > { .compatible = "qcom,sdx55-pcie-ep", }, > > { .compatible = "qcom,sm8450-pcie-ep", }, > > + { .compatible = "qcom,sar2130p-pcie-ep", }, > > Could you please use a fallback? I'd prefer to not add compatible to the driver > unless it requires special config. This is a tough question, I have been thinking about it too. But granted the differences in clocks used by the controller I opted to use different compat strings without a fallback. I think it would be hard to describe the schema otherwise.
diff --git a/drivers/pci/controller/dwc/pcie-qcom-ep.c b/drivers/pci/controller/dwc/pcie-qcom-ep.c index c08f64d7a825fa5da22976c8020f96ee5faa5462..dec5675c7c9d52b77f084ae139845b488fa02d2c 100644 --- a/drivers/pci/controller/dwc/pcie-qcom-ep.c +++ b/drivers/pci/controller/dwc/pcie-qcom-ep.c @@ -933,6 +933,7 @@ static const struct of_device_id qcom_pcie_ep_match[] = { { .compatible = "qcom,sa8775p-pcie-ep", .data = &cfg_1_34_0}, { .compatible = "qcom,sdx55-pcie-ep", }, { .compatible = "qcom,sm8450-pcie-ep", }, + { .compatible = "qcom,sar2130p-pcie-ep", }, { } }; MODULE_DEVICE_TABLE(of, qcom_pcie_ep_match);
Enable PCIe endpoint support for the Qualcomm SAR2130P platform. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- drivers/pci/controller/dwc/pcie-qcom-ep.c | 1 + 1 file changed, 1 insertion(+)