| Message ID | 20250219-x1e80100-thermal-fixes-v1-1-d110e44ac3f9@linaro.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | arm64: dts: qcom: x1e80100: Fix thermal trip points | expand |
On Wed, Feb 19, 2025 at 12:36:18PM +0100, Stephan Gerhold wrote: > A passive trip point at 125°C is pretty high, this is usually the > temperature for the critical shutdown trip point. Also, we don't have any > passive cooling devices attached to the video thermal zone. > > Change this to be a critical trip point, and add a "hot" trip point at > 90°C for consistency with the other thermal zones. > > Cc: stable@vger.kernel.org Perhaps not needed since we don't have a video driver enabled yet. > Fixes: 4e915987ff5b ("arm64: dts: qcom: x1e80100: Enable tsens and thermal zone nodes") > Signed-off-by: Stephan Gerhold <stephan.gerhold@linaro.org> Looks to good to me either way: Reviewed-by: Johan Hovold <johan+linaro@kernel.org> Johan
On Wed, Feb 19, 2025 at 04:28:30PM +0100, Johan Hovold wrote: > On Wed, Feb 19, 2025 at 12:36:18PM +0100, Stephan Gerhold wrote: > > A passive trip point at 125°C is pretty high, this is usually the > > temperature for the critical shutdown trip point. Also, we don't have any > > passive cooling devices attached to the video thermal zone. > > > > Change this to be a critical trip point, and add a "hot" trip point at > > 90°C for consistency with the other thermal zones. > > > > Cc: stable@vger.kernel.org > > Perhaps not needed since we don't have a video driver enabled yet. > It will be needed to backport the next patch (and reordering the patches wouldn't have made sense). > > Fixes: 4e915987ff5b ("arm64: dts: qcom: x1e80100: Enable tsens and thermal zone nodes") > > Signed-off-by: Stephan Gerhold <stephan.gerhold@linaro.org> > > Looks to good to me either way: > > Reviewed-by: Johan Hovold <johan+linaro@kernel.org> > Thanks! Stephan
On 19.02.2025 12:36 PM, Stephan Gerhold wrote: > A passive trip point at 125°C is pretty high, this is usually the > temperature for the critical shutdown trip point. Also, we don't have any > passive cooling devices attached to the video thermal zone. > > Change this to be a critical trip point, and add a "hot" trip point at > 90°C for consistency with the other thermal zones. > > Cc: stable@vger.kernel.org > Fixes: 4e915987ff5b ("arm64: dts: qcom: x1e80100: Enable tsens and thermal zone nodes") > Signed-off-by: Stephan Gerhold <stephan.gerhold@linaro.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> Konrad
diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi index 9d38436763432892ceef95daf0335d4cf446357c..e349cbf6a2665695b5cc961cf9d53e7182e68e7f 100644 --- a/arch/arm64/boot/dts/qcom/x1e80100.dtsi +++ b/arch/arm64/boot/dts/qcom/x1e80100.dtsi @@ -8727,15 +8727,19 @@ mem-critical { }; video-thermal { - polling-delay-passive = <250>; - thermal-sensors = <&tsens0 12>; trips { trip-point0 { + temperature = <90000>; + hysteresis = <2000>; + type = "hot"; + }; + + video-critical { temperature = <125000>; hysteresis = <1000>; - type = "passive"; + type = "critical"; }; }; };
A passive trip point at 125°C is pretty high, this is usually the temperature for the critical shutdown trip point. Also, we don't have any passive cooling devices attached to the video thermal zone. Change this to be a critical trip point, and add a "hot" trip point at 90°C for consistency with the other thermal zones. Cc: stable@vger.kernel.org Fixes: 4e915987ff5b ("arm64: dts: qcom: x1e80100: Enable tsens and thermal zone nodes") Signed-off-by: Stephan Gerhold <stephan.gerhold@linaro.org> --- arch/arm64/boot/dts/qcom/x1e80100.dtsi | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-)