| Message ID | 20250219130923.7216-1-ansuelsmth@gmail.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [net] net: phy: qcom: qca807x fix condition for DAC_DSP_BIAS_CURRENT | expand |
On Wed, Feb 19, 2025 at 02:09:21PM +0100, Christian Marangi wrote: > From: George Moussalem <george.moussalem@outlook.com> > > While setting the DAC value, the wrong boolean value is evaluated to set > the DSP bias current. So let's correct the conditional statement and use > the right boolean value read from the DTS set in the priv. > > Cc: stable@vger.kernel.org > Fixes: d1cb613efbd3 ("net: phy: qcom: add support for QCA807x PHY Family") > Signed-off-by: George Moussalem <george.moussalem@outlook.com> > Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski <kuba@kernel.org>: On Wed, 19 Feb 2025 14:09:21 +0100 you wrote: > From: George Moussalem <george.moussalem@outlook.com> > > While setting the DAC value, the wrong boolean value is evaluated to set > the DSP bias current. So let's correct the conditional statement and use > the right boolean value read from the DTS set in the priv. > > Cc: stable@vger.kernel.org > Fixes: d1cb613efbd3 ("net: phy: qcom: add support for QCA807x PHY Family") > Signed-off-by: George Moussalem <george.moussalem@outlook.com> > Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> > > [...] Here is the summary with links: - [net] net: phy: qcom: qca807x fix condition for DAC_DSP_BIAS_CURRENT https://git.kernel.org/netdev/net/c/992ee3ed6e9f You are awesome, thank you!
diff --git a/drivers/net/phy/qcom/qca807x.c b/drivers/net/phy/qcom/qca807x.c index 3279de857b47..2ad8c2586d64 100644 --- a/drivers/net/phy/qcom/qca807x.c +++ b/drivers/net/phy/qcom/qca807x.c @@ -774,7 +774,7 @@ static int qca807x_config_init(struct phy_device *phydev) control_dac &= ~QCA807X_CONTROL_DAC_MASK; if (!priv->dac_full_amplitude) control_dac |= QCA807X_CONTROL_DAC_DSP_AMPLITUDE; - if (!priv->dac_full_amplitude) + if (!priv->dac_full_bias_current) control_dac |= QCA807X_CONTROL_DAC_DSP_BIAS_CURRENT; if (!priv->dac_disable_bias_current_tweak) control_dac |= QCA807X_CONTROL_DAC_BIAS_CURRENT_TWEAK;