| Message ID | 20250225121824.3869719-9-quic_amakhija@quicinc.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add DSI display support for SA8775P target | expand |
On 25.02.2025 1:18 PM, Ayushi Makhija wrote: > Enable both DSI to DP bridge ports on SA8775P Ride plaftrom. > > Signed-off-by: Ayushi Makhija <quic_amakhija@quicinc.com> > --- > arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi | 66 +++++++++++++++++++++- > 1 file changed, 64 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi b/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi > index 151f66512303..02d8a9c2c909 100644 > --- a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi > +++ b/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi > @@ -128,6 +128,30 @@ dp1_connector_in: endpoint { > }; > }; > }; > + > + dsi0-connector { > + compatible = "dp-connector"; > + label = "DSI0"; DP0 > + type = "full-size"; > + > + port { > + dsi0_connector_in: endpoint { > + remote-endpoint = <&anx7625_1_out>; > + }; > + }; > + }; > + > + dsi1-connector { > + compatible = "dp-connector"; > + label = "DSI1"; DP1 Konrad
On Tue, Feb 25, 2025 at 05:48:21PM +0530, Ayushi Makhija wrote: > Enable both DSI to DP bridge ports on SA8775P Ride plaftrom. > > Signed-off-by: Ayushi Makhija <quic_amakhija@quicinc.com> > --- > arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi | 66 +++++++++++++++++++++- > 1 file changed, 64 insertions(+), 2 deletions(-) Please squash into the previous patch. It doesn't make a lot of sense separately. > > diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi b/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi > index 151f66512303..02d8a9c2c909 100644 > --- a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi > +++ b/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi > @@ -128,6 +128,30 @@ dp1_connector_in: endpoint { > }; > }; > }; > + > + dsi0-connector { dpN-connector. It is not DSI. > + compatible = "dp-connector"; > + label = "DSI0"; Is it an actual label on it? > + type = "full-size"; > + > + port { > + dsi0_connector_in: endpoint { > + remote-endpoint = <&anx7625_1_out>; > + }; > + }; > + }; > +
On 2/25/2025 11:25 PM, Dmitry Baryshkov wrote: > On Tue, Feb 25, 2025 at 05:48:21PM +0530, Ayushi Makhija wrote: >> Enable both DSI to DP bridge ports on SA8775P Ride plaftrom. >> >> Signed-off-by: Ayushi Makhija <quic_amakhija@quicinc.com> >> --- >> arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi | 66 +++++++++++++++++++++- >> 1 file changed, 64 insertions(+), 2 deletions(-) > > Please squash into the previous patch. It doesn't make a lot of sense separately. > >> >> diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi b/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi >> index 151f66512303..02d8a9c2c909 100644 >> --- a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi >> @@ -128,6 +128,30 @@ dp1_connector_in: endpoint { >> }; >> }; >> }; >> + >> + dsi0-connector { > > dpN-connector. It is not DSI. Hi Dmitry, Konrad Thanks, for the review. I will change dsi0-connector -> dp2-connector and dsi1-connector -> dp3-connector respectively. > >> + compatible = "dp-connector"; >> + label = "DSI0"; > > Is it an actual label on it? The label for DSI to DP bridge ports itself on the device is DSI0 and DSI1 respectively. Thanks, Ayushi
On Tue, 4 Mar 2025 at 10:45, Ayushi Makhija <quic_amakhija@quicinc.com> wrote: > > On 2/25/2025 11:25 PM, Dmitry Baryshkov wrote: > > On Tue, Feb 25, 2025 at 05:48:21PM +0530, Ayushi Makhija wrote: > >> Enable both DSI to DP bridge ports on SA8775P Ride plaftrom. > >> > >> Signed-off-by: Ayushi Makhija <quic_amakhija@quicinc.com> > >> --- > >> arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi | 66 +++++++++++++++++++++- > >> 1 file changed, 64 insertions(+), 2 deletions(-) > > > > Please squash into the previous patch. It doesn't make a lot of sense separately. > > > >> > >> diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi b/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi > >> index 151f66512303..02d8a9c2c909 100644 > >> --- a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi > >> +++ b/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi > >> @@ -128,6 +128,30 @@ dp1_connector_in: endpoint { > >> }; > >> }; > >> }; > >> + > >> + dsi0-connector { > > > > dpN-connector. It is not DSI. > > Hi Dmitry, Konrad > > Thanks, for the review. > > I will change dsi0-connector -> dp2-connector and dsi1-connector -> dp3-connector respectively. Why? It's then dp-dsi0-connector. I think the board has DP2 and DP3 (please correct me if I'm wrong). How would you name those if you use those indices for DSI connectors? > > > > >> + compatible = "dp-connector"; > >> + label = "DSI0"; > > > > Is it an actual label on it? > > The label for DSI to DP bridge ports itself on the device is DSI0 and DSI1 respectively. Ack
On 3/4/2025 3:18 PM, Dmitry Baryshkov wrote: > On Tue, 4 Mar 2025 at 10:45, Ayushi Makhija <quic_amakhija@quicinc.com> wrote: >> >> On 2/25/2025 11:25 PM, Dmitry Baryshkov wrote: >>> On Tue, Feb 25, 2025 at 05:48:21PM +0530, Ayushi Makhija wrote: >>>> Enable both DSI to DP bridge ports on SA8775P Ride plaftrom. >>>> >>>> Signed-off-by: Ayushi Makhija <quic_amakhija@quicinc.com> >>>> --- >>>> arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi | 66 +++++++++++++++++++++- >>>> 1 file changed, 64 insertions(+), 2 deletions(-) >>> >>> Please squash into the previous patch. It doesn't make a lot of sense separately. >>> >>>> >>>> diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi b/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi >>>> index 151f66512303..02d8a9c2c909 100644 >>>> --- a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi >>>> +++ b/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi >>>> @@ -128,6 +128,30 @@ dp1_connector_in: endpoint { >>>> }; >>>> }; >>>> }; >>>> + >>>> + dsi0-connector { >>> >>> dpN-connector. It is not DSI. >> >> Hi Dmitry, Konrad >> >> Thanks, for the review. >> >> I will change dsi0-connector -> dp2-connector and dsi1-connector -> dp3-connector respectively. > > Why? It's then dp-dsi0-connector. I think the board has DP2 and DP3 > (please correct me if I'm wrong). How would you name those if you use > those indices for DSI connectors? > Hi Dmitry, Thanks, for the review. yes, you are correct there are total 4 DP connectors and 2 DSI to DP connectors on the device, better to keep the node name as dp-dsi0-connector and dp-dsi1-connector respectively. Thanks, Ayushi
diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi b/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi index 151f66512303..02d8a9c2c909 100644 --- a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi +++ b/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi @@ -128,6 +128,30 @@ dp1_connector_in: endpoint { }; }; }; + + dsi0-connector { + compatible = "dp-connector"; + label = "DSI0"; + type = "full-size"; + + port { + dsi0_connector_in: endpoint { + remote-endpoint = <&anx7625_1_out>; + }; + }; + }; + + dsi1-connector { + compatible = "dp-connector"; + label = "DSI1"; + type = "full-size"; + + port { + dsi1_connector_in: endpoint { + remote-endpoint = <&anx7625_2_out>; + }; + }; + }; }; &apps_rsc { @@ -598,7 +622,9 @@ anx7625_1_in: endpoint { dsi2dp_bridge_1_out: port@1 { reg = <1>; - anx7625_1_out: endpoint { }; + anx7625_1_out: endpoint { + remote-endpoint = <&dsi0_connector_in>; + }; }; }; }; @@ -632,7 +658,9 @@ anx7625_2_in: endpoint { dsi2dp_bridge_2_out: port@1 { reg = <1>; - anx7625_2_out: endpoint { }; + anx7625_2_out: endpoint { + remote-endpoint = <&dsi1_connector_in>; + }; }; }; }; @@ -685,6 +713,40 @@ &mdss0_dp1_phy { status = "okay"; }; +&mdss0_dsi0 { + vdda-supply = <&vreg_l1c>; + + status = "okay"; +}; + +&mdss0_dsi0_out { + data-lanes = <0 1 2 3>; + remote-endpoint = <&anx7625_1_in>; +}; + +&mdss0_dsi0_phy { + vdds-supply = <&vreg_l4a>; + + status = "okay"; +}; + +&mdss0_dsi1 { + vdda-supply = <&vreg_l1c>; + + status = "okay"; +}; + +&mdss0_dsi1_out { + data-lanes = <0 1 2 3>; + remote-endpoint = <&anx7625_2_in>; +}; + +&mdss0_dsi1_phy { + vdds-supply = <&vreg_l4a>; + + status = "okay"; +}; + &pmm8654au_0_gpios { gpio-line-names = "DS_EN", "POFF_COMPLETE",
Enable both DSI to DP bridge ports on SA8775P Ride plaftrom. Signed-off-by: Ayushi Makhija <quic_amakhija@quicinc.com> --- arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi | 66 +++++++++++++++++++++- 1 file changed, 64 insertions(+), 2 deletions(-)