| Message ID | 20250303225521.1780611-2-vladimir.zapolskiy@linaro.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | arm64: dts: qcom: sm8550: camcc: Manage MMCX and MXC | expand |
On Tue, Mar 04, 2025 at 12:55:20AM +0200, Vladimir Zapolskiy wrote: > During the tests it was unveiled and later it was confirmed that SM8550 > Camera Clock Controller shall enable both MXC and MMCX power domains. > > Since power-domains property is not specific to MMCX anymore, its > description is removed. > > Fixes: 9cbc64745fc6 ("dt-bindings: clock: qcom: Add SM8550 camera clock controller") > Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org> > --- > .../devicetree/bindings/clock/qcom,sm8450-camcc.yaml | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml > index 9e79f8fec437..d7fc9e5a2d20 100644 > --- a/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml > +++ b/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml > @@ -37,9 +37,7 @@ properties: > - description: Sleep clock source > > power-domains: > - maxItems: 1 > - description: > - A phandle and PM domain specifier for the MMCX power domain. > + maxItems: 2 items: - description: foo - description: bar Also, don't we need power-domain-names now? > > required-opps: > maxItems: 1 > -- > 2.43.0 >
On Tue, 04 Mar 2025 00:55:20 +0200, Vladimir Zapolskiy wrote: > During the tests it was unveiled and later it was confirmed that SM8550 > Camera Clock Controller shall enable both MXC and MMCX power domains. > > Since power-domains property is not specific to MMCX anymore, its > description is removed. > > Fixes: 9cbc64745fc6 ("dt-bindings: clock: qcom: Add SM8550 camera clock controller") > Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org> > --- > .../devicetree/bindings/clock/qcom,sm8450-camcc.yaml | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.example.dtb: clock-controller@ade0000: power-domains: [[4294967295, 6]] is too short from schema $id: http://devicetree.org/schemas/clock/qcom,sm8450-camcc.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.example.dtb: clock-controller@ade0000: Unevaluated properties are not allowed ('power-domains' was unexpected) from schema $id: http://devicetree.org/schemas/clock/qcom,sm8450-camcc.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250303225521.1780611-2-vladimir.zapolskiy@linaro.org The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml index 9e79f8fec437..d7fc9e5a2d20 100644 --- a/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml +++ b/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml @@ -37,9 +37,7 @@ properties: - description: Sleep clock source power-domains: - maxItems: 1 - description: - A phandle and PM domain specifier for the MMCX power domain. + maxItems: 2 required-opps: maxItems: 1
During the tests it was unveiled and later it was confirmed that SM8550 Camera Clock Controller shall enable both MXC and MMCX power domains. Since power-domains property is not specific to MMCX anymore, its description is removed. Fixes: 9cbc64745fc6 ("dt-bindings: clock: qcom: Add SM8550 camera clock controller") Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org> --- .../devicetree/bindings/clock/qcom,sm8450-camcc.yaml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)