| Message ID | 20250327-videocc-pll-multi-pd-voting-v3-15-895fafd62627@quicinc.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | clk: qcom: Add support to attach multiple power domains in cc probe | expand |
On 3/27/25 10:52 AM, Jagadeesh Kona wrote: > Videocc requires both MMCX and MXC rails to be powered ON to configure > the video PLLs on SM8650 platform. Hence add MXC power domain to videocc > node on SM8650. > > Signed-off-by: Jagadeesh Kona <quic_jkona@quicinc.com> > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > --- > arch/arm64/boot/dts/qcom/sm8650.dtsi | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm8650.dtsi b/arch/arm64/boot/dts/qcom/sm8650.dtsi > index 818db6ba3b3be99c187512ea4acf2004422f6a18..ad60596b71d25bb0198b26660dc41195a1210a23 100644 > --- a/arch/arm64/boot/dts/qcom/sm8650.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8650.dtsi > @@ -4959,7 +4959,8 @@ videocc: clock-controller@aaf0000 { > reg = <0 0x0aaf0000 0 0x10000>; > clocks = <&bi_tcxo_div2>, > <&gcc GCC_VIDEO_AHB_CLK>; > - power-domains = <&rpmhpd RPMHPD_MMCX>; > + power-domains = <&rpmhpd RPMHPD_MMCX>, > + <&rpmhpd RPMHPD_MXC>; So all other DTs touched in this series reference low_svs in required-opps Is that an actual requirement? Otherwise since Commit e3e56c050ab6 ("soc: qcom: rpmhpd: Make power_on actually enable the domain") we get the first nonzero state, which can be something like low_svs_d2 Konrad
On 4/1/25 5:27 PM, Konrad Dybcio wrote: > On 3/27/25 10:52 AM, Jagadeesh Kona wrote: >> Videocc requires both MMCX and MXC rails to be powered ON to configure >> the video PLLs on SM8650 platform. Hence add MXC power domain to videocc >> node on SM8650. >> >> Signed-off-by: Jagadeesh Kona <quic_jkona@quicinc.com> >> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> >> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> >> --- >> arch/arm64/boot/dts/qcom/sm8650.dtsi | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm64/boot/dts/qcom/sm8650.dtsi b/arch/arm64/boot/dts/qcom/sm8650.dtsi >> index 818db6ba3b3be99c187512ea4acf2004422f6a18..ad60596b71d25bb0198b26660dc41195a1210a23 100644 >> --- a/arch/arm64/boot/dts/qcom/sm8650.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sm8650.dtsi >> @@ -4959,7 +4959,8 @@ videocc: clock-controller@aaf0000 { >> reg = <0 0x0aaf0000 0 0x10000>; >> clocks = <&bi_tcxo_div2>, >> <&gcc GCC_VIDEO_AHB_CLK>; >> - power-domains = <&rpmhpd RPMHPD_MMCX>; >> + power-domains = <&rpmhpd RPMHPD_MMCX>, >> + <&rpmhpd RPMHPD_MXC>; > > So all other DTs touched in this series reference low_svs in required-opps actually "all" is wrong on my side, please also consider and if necessary apply the same change to patch 18 Konrad > > Is that an actual requirement? Otherwise since Commit e3e56c050ab6 > ("soc: qcom: rpmhpd: Make power_on actually enable the domain") we get the > first nonzero state, which can be something like low_svs_d2 > > Konrad
diff --git a/arch/arm64/boot/dts/qcom/sm8650.dtsi b/arch/arm64/boot/dts/qcom/sm8650.dtsi index 818db6ba3b3be99c187512ea4acf2004422f6a18..ad60596b71d25bb0198b26660dc41195a1210a23 100644 --- a/arch/arm64/boot/dts/qcom/sm8650.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8650.dtsi @@ -4959,7 +4959,8 @@ videocc: clock-controller@aaf0000 { reg = <0 0x0aaf0000 0 0x10000>; clocks = <&bi_tcxo_div2>, <&gcc GCC_VIDEO_AHB_CLK>; - power-domains = <&rpmhpd RPMHPD_MMCX>; + power-domains = <&rpmhpd RPMHPD_MMCX>, + <&rpmhpd RPMHPD_MXC>; #clock-cells = <1>; #reset-cells = <1>; #power-domain-cells = <1>;