| Message ID | 20250402123622.11984-1-loic.poulain@oss.qualcomm.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v2,1/2] dt-bindings: i2c: qcom-cci: Document QCM2290 compatible | expand |
On 02/04/2025 14:36, Loic Poulain wrote: > + - if: > + properties: > + compatible: > + contains: > + enum: > + - qcom,qcm2290-cci > + then: > + properties: > + clocks: > + minItems: 2 > + maxItems: 2 > + clock-names: > + items: > + - const: camss_top_ahb > + - const: cci This looks good, but I do not see updates for qcom,msm8974-cci/qcom,msm8226-cci constraints. You lowered minItems in top level, so you need to add minItems: 3 there. With that fixed: Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml index 73144473b9b2..55ec65df4f7a 100644 --- a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml +++ b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml @@ -25,6 +25,7 @@ properties: - items: - enum: + - qcom,qcm2290-cci - qcom,sc7280-cci - qcom,sc8280xp-cci - qcom,sdm670-cci @@ -44,11 +45,11 @@ properties: const: 0 clocks: - minItems: 3 + minItems: 2 maxItems: 6 clock-names: - minItems: 3 + minItems: 2 maxItems: 6 interrupts: @@ -120,6 +121,22 @@ allOf: - const: cci_ahb - const: cci + - if: + properties: + compatible: + contains: + enum: + - qcom,qcm2290-cci + then: + properties: + clocks: + minItems: 2 + maxItems: 2 + clock-names: + items: + - const: camss_top_ahb + - const: cci + - if: properties: compatible:
The CCI on QCM2290 is the interface for controlling camera sensor over I2C. It requires only two clocks. Signed-off-by: Loic Poulain <loic.poulain@oss.qualcomm.com> --- v2: Reorder commits and Fix binding testing syntax .../devicetree/bindings/i2c/qcom,i2c-cci.yaml | 21 +++++++++++++++++-- 1 file changed, 19 insertions(+), 2 deletions(-)