From patchwork Wed Apr 2 11:43:57 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: shao.mingyin@zte.com.cn X-Patchwork-Id: 14035832 Received: from mxhk.zte.com.cn (mxhk.zte.com.cn [63.216.63.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C99B3236451; Wed, 2 Apr 2025 11:44:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=63.216.63.35 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743594257; cv=none; b=cgl4KRJdHt4be4+q9ITUdYV7v07SKDi61XNkyn94jrJJJSRZnqLDsw09WpF7baIQ7BVVx67po714A0E/eX/Bs26OAjc3i1imc3dzUuFQzzv1dnAWsk48Us/vH7FyTecB/n/zLGEErfdVVa5+fZCLPOA+9Gu8xoYudnMEyYPzuDs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743594257; c=relaxed/simple; bh=Z0NePWjC0usRfphBp4RYVUXKLMLWOyek6WqP11WZt3M=; h=Date:Message-ID:In-Reply-To:References:Mime-Version:From:To:Cc: Subject:Content-Type; b=g3L1AwUYlngreUDV0Uudi18eTyxVdHKgzIkCPWLaUOi6oHmR9LvvgZI/r0xRVkm1Xm50LtoXaaCE+f43Fi6CquZe412/D8NoEJiOl5xp3Nff9G9XwHehY4Asb9TYyYdjPacqTL4G+ydViGYzJoMFgtpGWULNTD3dDCB9eItIz0I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=zte.com.cn; spf=pass smtp.mailfrom=zte.com.cn; arc=none smtp.client-ip=63.216.63.35 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=zte.com.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=zte.com.cn Received: from mse-fl2.zte.com.cn (unknown [10.5.228.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mxhk.zte.com.cn (FangMail) with ESMTPS id 4ZSNLk0g6Rz5B1Jd; Wed, 2 Apr 2025 19:44:14 +0800 (CST) Received: from xaxapp02.zte.com.cn ([10.88.97.241]) by mse-fl2.zte.com.cn with SMTP id 532BhsZv019636; Wed, 2 Apr 2025 19:43:54 +0800 (+08) (envelope-from shao.mingyin@zte.com.cn) Received: from mapi (xaxapp01[null]) by mapi (Zmail) with MAPI id mid32; Wed, 2 Apr 2025 19:43:57 +0800 (CST) Date: Wed, 2 Apr 2025 19:43:57 +0800 (CST) X-Zmail-TransId: 2af967ed22fd046-2b930 X-Mailer: Zmail v1.0 Message-ID: <20250402194357404aoSxd3G74tojxA7uCZXiy@zte.com.cn> In-Reply-To: <20250402194100610qY6KQ4JPISk-4v214Qs36@zte.com.cn> References: 20250402194100610qY6KQ4JPISk-4v214Qs36@zte.com.cn Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 From: To: , Cc: , , , , , , , , , , , , , , , Subject: =?utf-8?q?=5BPATCH_linux-next_3/5=5D_phy=3A_qualcomm=3A_phy-qcom-ip?= =?utf-8?q?q4019-usb=3A_Use=C2=A0dev=5Ferr=5Fprobe=28=29?= X-MAIL: mse-fl2.zte.com.cn 532BhsZv019636 X-Fangmail-Anti-Spam-Filtered: true X-Fangmail-MID-QID: 67ED230E.000/4ZSNLk0g6Rz5B1Jd From: Zhang Enpei Replace the open-code with dev_err_probe() to simplify the code. Signed-off-by: Zhang Enpei Signed-off-by: Shao Mingyin Reviewed-by: Dmitry Baryshkov --- drivers/phy/qualcomm/phy-qcom-ipq4019-usb.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/phy/qualcomm/phy-qcom-ipq4019-usb.c b/drivers/phy/qualcomm/phy-qcom-ipq4019-usb.c index da6f290af722..738b3015747f 100644 --- a/drivers/phy/qualcomm/phy-qcom-ipq4019-usb.c +++ b/drivers/phy/qualcomm/phy-qcom-ipq4019-usb.c @@ -109,11 +109,9 @@ static int ipq4019_usb_phy_probe(struct platform_device *pdev) } phy->por_rst = devm_reset_control_get(phy->dev, "por_rst"); - if (IS_ERR(phy->por_rst)) { - if (PTR_ERR(phy->por_rst) != -EPROBE_DEFER) - dev_err(dev, "POR reset is missing\n"); - return PTR_ERR(phy->por_rst); - } + if (IS_ERR(phy->por_rst)) + return dev_err_probe(dev, PTR_ERR(phy->por_rst), + "POR reset is missing\n"); phy->srif_rst = devm_reset_control_get_optional(phy->dev, "srif_rst"); if (IS_ERR(phy->srif_rst))