From patchwork Mon Jan 21 09:42:23 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Kucheria X-Patchwork-Id: 10773467 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C67EF1575 for ; Mon, 21 Jan 2019 09:43:37 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B629F299A0 for ; Mon, 21 Jan 2019 09:43:37 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A9FCB299A4; Mon, 21 Jan 2019 09:43:37 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 66B41299B6 for ; Mon, 21 Jan 2019 09:43:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728372AbfAUJnb (ORCPT ); Mon, 21 Jan 2019 04:43:31 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:44255 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727804AbfAUJna (ORCPT ); Mon, 21 Jan 2019 04:43:30 -0500 Received: by mail-wr1-f65.google.com with SMTP id z5so22430675wrt.11 for ; Mon, 21 Jan 2019 01:43:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=/iO1px23azz4XYlqPGK4I0M/7XGc7/WM1npHE+nRfKQ=; b=Q5qZut8Lgm+vBQ73S0qqM8ppV+bIgxmc+vcYzE971tIRrk72Vd3G/jhIEKcRSWs9rC tTPt7FjACaJfomCX3gvrmn4yZBbJtmJd4BswDHbvFuhyBdHL6gC3WX/bWQ6hYw44J5uo qgkDJb7tGyafICJ1phnejx+7AJPBr2E4EEr8M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=/iO1px23azz4XYlqPGK4I0M/7XGc7/WM1npHE+nRfKQ=; b=G0ksk9dda3s73OH0ieaFz3pADXZzCqIimHLJXCM/3GkhWafdZPZ/+O4mAq1m9hNAxo 6phUVanaPnTZklFU9b2JjsnRW4YX1wTmDOUTQI5qE2zwJhDuwk30M2g3k8yn5VPDUvyt eW5QWbAoIoEPpYR5mcfdZD+hvAsxkq37CtW5FBTbOUjNfwuMxMWydwdujiaId3iv/Ouq T2Fz+HpcVnhLMLF6TVskHpOjOinh0JZ2VlU9OQ59qAMk+iT0Q2fQzY2VfdqGSO76jCel QUPlVhWgEhyZlgJQtev7C+x1Y/Un6r/ZILkKWahIiRU6LCKpD+OQPVYMVwNG6LaHCu+s bkJA== X-Gm-Message-State: AJcUukdKkyGEoJEOyWA+dwPXuFlIsWm072Q3JWePCJ5+YScNChBPiaQE IVqnVRbN8meNFqTxOeCKK1YQRw== X-Google-Smtp-Source: ALg8bN5BbNpt9xTjrX7pXW7xYHtY4kSCbm9T5+Xrs4QGpvjZ2m7zBikHKoEz7wl4Gu23+CP7KV71NA== X-Received: by 2002:adf:ce86:: with SMTP id r6mr28491308wrn.257.1548063808552; Mon, 21 Jan 2019 01:43:28 -0800 (PST) Received: from localhost ([49.248.61.1]) by smtp.gmail.com with ESMTPSA id t76sm52767896wme.33.2019.01.21.01.43.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 21 Jan 2019 01:43:27 -0800 (PST) From: Amit Kucheria To: linux-kernel@vger.kernel.org Cc: linux-arm-msm@vger.kernel.org, edubezval@gmail.com, swboyd@chromium.org, Amit Daniel Kachhap , Viresh Kumar , Zhang Rui , Daniel Lezcano , linux-pm@vger.kernel.org Subject: [PATCH v1 2/2] thermal: cpu_cooling: Clarify error message Date: Mon, 21 Jan 2019 15:12:23 +0530 Message-Id: <3812a31a821981eb36858852d2f66c018c8fa0d4.1548063429.git.amit.kucheria@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Make it clear that it is a failure if the cpufreq driver was unable to register as a cooling device. Makes it easier to find in logs and grepping for words like fail, err, warn. Signed-off-by: Amit Kucheria Acked-by: Viresh Kumar --- drivers/thermal/cpu_cooling.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thermal/cpu_cooling.c b/drivers/thermal/cpu_cooling.c index dfd23245f778..6fff16113628 100644 --- a/drivers/thermal/cpu_cooling.c +++ b/drivers/thermal/cpu_cooling.c @@ -774,7 +774,7 @@ of_cpufreq_cooling_register(struct cpufreq_policy *policy) cdev = __cpufreq_cooling_register(np, policy, capacitance); if (IS_ERR(cdev)) { - pr_err("cpu_cooling: cpu%d is not running as cooling device: %ld\n", + pr_err("cpu_cooling: cpu%d failed to register as cooling device: %ld\n", policy->cpu, PTR_ERR(cdev)); cdev = NULL; }