| Message ID | 39e0f711-9331-4fd2-9d78-be53afb5c37d@oldschoolsolutions.biz (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | thermal: qcom: tsens: remove dependency to NVMEM_QCOM_QFPROM | expand |
Hi there, please don't bother with this patch. Re-checked and works as intended if done in the right order. with best regards Jens On 12/20/23 23:05, Jens Glathe wrote: > The dependency to NVMEM_QCOM_QFPROM seems to be a problem when using > "make menuconfig", it will exclude QCOM_TSENS from the build wWith > bad effects on power management, observed on the Windows Dev Kit 2023, > and Thinkpad X13s. Removing it doesn't have a negative side effect, > as it seems. Observed this since v6.6. > > Signed-off-by: Jens Glathe <jens.glathe@oldschoolsolutions.biz> > --- > drivers/thermal/qcom/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/thermal/qcom/Kconfig b/drivers/thermal/qcom/Kconfig > index c4ebb1977b177..09d9b35c57bd2 100644 > --- a/drivers/thermal/qcom/Kconfig > +++ b/drivers/thermal/qcom/Kconfig > @@ -1,7 +1,6 @@ > # SPDX-License-Identifier: GPL-2.0-only > config QCOM_TSENS > tristate "Qualcomm TSENS Temperature Alarm" > - depends on NVMEM_QCOM_QFPROM > depends on ARCH_QCOM || COMPILE_TEST > help > This enables the thermal sysfs driver for the TSENS device. It > shows
diff --git a/drivers/thermal/qcom/Kconfig b/drivers/thermal/qcom/Kconfig index c4ebb1977b177..09d9b35c57bd2 100644 --- a/drivers/thermal/qcom/Kconfig +++ b/drivers/thermal/qcom/Kconfig @@ -1,7 +1,6 @@ # SPDX-License-Identifier: GPL-2.0-only config QCOM_TSENS tristate "Qualcomm TSENS Temperature Alarm" - depends on NVMEM_QCOM_QFPROM depends on ARCH_QCOM || COMPILE_TEST help This enables the thermal sysfs driver for the TSENS device. It shows
The dependency to NVMEM_QCOM_QFPROM seems to be a problem when using "make menuconfig", it will exclude QCOM_TSENS from the build wWith bad effects on power management, observed on the Windows Dev Kit 2023, and Thinkpad X13s. Removing it doesn't have a negative side effect, as it seems. Observed this since v6.6. Signed-off-by: Jens Glathe <jens.glathe@oldschoolsolutions.biz> --- drivers/thermal/qcom/Kconfig | 1 - 1 file changed, 1 deletion(-)