| Message ID | 45e0882efe080d882fa083c16c51f613f70e52aa.1737615222.git.quic_lxu5@quicinc.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | arm64: dts: qcom: sa8775p: modify compute-cb nodes | expand |
On 1/23/2025 5:19 PM, Ling Xu wrote: > Need to remove the context bank compute-cb@10 because secure cdsp > uses the s2-only stream. You need a line below just before your commit message if you are not the original author. From: From Author <from@author.example.org> > > Fixes: f7b01bfb4b47 ("arm64: qcom: sa8775p: Add ADSP and CDSP0 fastrpc nodes") > Cc: stable@kernel.org > Signed-off-by: Karthik Sanagavarapu <quic_kartsana@quicinc.com> > Signed-off-by: Ling Xu <quic_lxu5@quicinc.com> > --- > arch/arm64/boot/dts/qcom/sa8775p.dtsi | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi > index 0aa27db21f3d..81b2fba94841 100644 > --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi > +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi > @@ -4585,14 +4585,6 @@ compute-cb@9 { > dma-coherent; > }; > > - compute-cb@10 { > - compatible = "qcom,fastrpc-compute-cb"; > - reg = <10>; > - iommus = <&apps_smmu 0x214a 0x04a0>, > - <&apps_smmu 0x218a 0x0400>; > - dma-coherent; > - }; > - > compute-cb@11 { > compatible = "qcom,fastrpc-compute-cb"; > reg = <11>; Thanks, Jie
On Thu, Jan 23, 2025 at 05:36:40PM +0800, Jie Gan wrote: > > > On 1/23/2025 5:19 PM, Ling Xu wrote: > > Need to remove the context bank compute-cb@10 because secure cdsp > > uses the s2-only stream. > You need a line below just before your commit message if you are not the > original author. > From: From Author <from@author.example.org> And Git will handle that automatically if the commit has proper Author metadata. > > > > > Fixes: f7b01bfb4b47 ("arm64: qcom: sa8775p: Add ADSP and CDSP0 fastrpc nodes") > > Cc: stable@kernel.org > > Signed-off-by: Karthik Sanagavarapu <quic_kartsana@quicinc.com> > > Signed-off-by: Ling Xu <quic_lxu5@quicinc.com> > > --- > > arch/arm64/boot/dts/qcom/sa8775p.dtsi | 8 -------- > > 1 file changed, 8 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi > > index 0aa27db21f3d..81b2fba94841 100644 > > --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi > > +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi > > @@ -4585,14 +4585,6 @@ compute-cb@9 { > > dma-coherent; > > }; > > - compute-cb@10 { > > - compatible = "qcom,fastrpc-compute-cb"; > > - reg = <10>; > > - iommus = <&apps_smmu 0x214a 0x04a0>, > > - <&apps_smmu 0x218a 0x0400>; > > - dma-coherent; > > - }; > > - > > compute-cb@11 { > > compatible = "qcom,fastrpc-compute-cb"; > > reg = <11>; > > > Thanks, > Jie
On Thu, Jan 23, 2025 at 02:49:28PM +0530, Ling Xu wrote: > Need to remove the context bank compute-cb@10 because secure cdsp > uses the s2-only stream. This doesn't tell us anything. is cb@10 secure (it isn't marked this way), are those SMMU ids incorrect? Or are they S2-only? Or something else? > > Fixes: f7b01bfb4b47 ("arm64: qcom: sa8775p: Add ADSP and CDSP0 fastrpc nodes") > Cc: stable@kernel.org > Signed-off-by: Karthik Sanagavarapu <quic_kartsana@quicinc.com> > Signed-off-by: Ling Xu <quic_lxu5@quicinc.com> > --- > arch/arm64/boot/dts/qcom/sa8775p.dtsi | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi > index 0aa27db21f3d..81b2fba94841 100644 > --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi > +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi > @@ -4585,14 +4585,6 @@ compute-cb@9 { > dma-coherent; > }; > > - compute-cb@10 { > - compatible = "qcom,fastrpc-compute-cb"; > - reg = <10>; > - iommus = <&apps_smmu 0x214a 0x04a0>, > - <&apps_smmu 0x218a 0x0400>; > - dma-coherent; > - }; > - > compute-cb@11 { > compatible = "qcom,fastrpc-compute-cb"; > reg = <11>; > -- > 2.34.1 >
diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi index 0aa27db21f3d..81b2fba94841 100644 --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi @@ -4585,14 +4585,6 @@ compute-cb@9 { dma-coherent; }; - compute-cb@10 { - compatible = "qcom,fastrpc-compute-cb"; - reg = <10>; - iommus = <&apps_smmu 0x214a 0x04a0>, - <&apps_smmu 0x218a 0x0400>; - dma-coherent; - }; - compute-cb@11 { compatible = "qcom,fastrpc-compute-cb"; reg = <11>;
Need to remove the context bank compute-cb@10 because secure cdsp uses the s2-only stream. Fixes: f7b01bfb4b47 ("arm64: qcom: sa8775p: Add ADSP and CDSP0 fastrpc nodes") Cc: stable@kernel.org Signed-off-by: Karthik Sanagavarapu <quic_kartsana@quicinc.com> Signed-off-by: Ling Xu <quic_lxu5@quicinc.com> --- arch/arm64/boot/dts/qcom/sa8775p.dtsi | 8 -------- 1 file changed, 8 deletions(-)