From patchwork Wed Oct 8 15:04:57 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinivas Kandagatla X-Patchwork-Id: 5054061 Return-Path: X-Original-To: patchwork-linux-arm-msm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id C9D31C11AB for ; Wed, 8 Oct 2014 15:05:07 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 0B70B201FA for ; Wed, 8 Oct 2014 15:05:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 35E782015E for ; Wed, 8 Oct 2014 15:05:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755876AbaJHPFF (ORCPT ); Wed, 8 Oct 2014 11:05:05 -0400 Received: from mail-wg0-f44.google.com ([74.125.82.44]:54383 "EHLO mail-wg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750858AbaJHPFE (ORCPT ); Wed, 8 Oct 2014 11:05:04 -0400 Received: by mail-wg0-f44.google.com with SMTP id y10so11701991wgg.15 for ; Wed, 08 Oct 2014 08:05:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=e2cBrm81sbZaw1jymmT6S03tIh1kiM3VI+y/IUln9L8=; b=Z6u3+mE5XCS8QaxBcbQ8a8Bj1j+vg8TkeLE9NQwnuWSWKUONgZlAa7AxrZUjt2h8AP lXuDn/CaA6q1g37p601olZEmGX25kEdLTggUrhY+ksiwMnv3wgTnOssv2qnXlXzR8s4p jY8UiorXshLa9JUwBoYGt8JEBhOig0+kozTgah+fNfzQIRl0DjcsjCcKvIQQwm5hxviz kVUi1dhGqCGOE4G9GFs0s/SYyOlyQu9opGPzsfyeebtVRbB5vOIu2ZUbjTtOQpW3ksBN Se51E7j6VDhCyShZEPl8A53E533TkuE06VCwLYWkcAff/ZDvaEwx8M5mSeel+fO/YT5J P9ow== X-Gm-Message-State: ALoCoQnsFZVOEogHthZOC8uh0LHlDwr3zk2rtgyMjhe2j/XNI7zmv0hsEMJM5KLZOYLKrmWYDwNI X-Received: by 10.194.48.81 with SMTP id j17mr2280513wjn.128.1412780702947; Wed, 08 Oct 2014 08:05:02 -0700 (PDT) Received: from [192.168.1.7] (host-78-149-2-97.as13285.net. [78.149.2.97]) by mx.google.com with ESMTPSA id os4sm346318wjc.48.2014.10.08.08.04.58 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 08 Oct 2014 08:05:01 -0700 (PDT) Message-ID: <54355299.4000501@linaro.org> Date: Wed, 08 Oct 2014 16:04:57 +0100 From: Srinivas Kandagatla User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 MIME-Version: 1.0 To: Stephen Boyd CC: Mike Turquette , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Viresh Kumar , linux-pm@vger.kernel.org Subject: Re: [PATCH v2 04/15] clk: divider: Make generic for usage elsewhere References: <1409957256-23729-1-git-send-email-sboyd@codeaurora.org> <1409957256-23729-5-git-send-email-sboyd@codeaurora.org> <542EE5FE.9080806@codeaurora.org> <54342287.7020005@linaro.org> <54343038.2060007@codeaurora.org> In-Reply-To: <54343038.2060007@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 07/10/14 19:26, Stephen Boyd wrote: > On 10/07/2014 10:27 AM, Srinivas Kandagatla wrote: >> Hi Stephen, >> >> Just noticed this regression while testing the patch on Arndale board. >> >> https://bugs.linaro.org/show_bug.cgi?id=740 > > If you return value it works correctly right? > I think you are right, .. From last message from bugs.linaro.org: " That seems to be it! This change: - makes Arndale to boot; rootfs on mmc mounts OK. " thanks, srini --- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/drivers/clk/clk-divider.c +++ b/drivers/clk/clk-divider.c @@ -366,7 +366,7 @@ int divider_get_val(unsigned long rate, unsigned long parent min_t(unsigned int, value, div_mask(width)); - return 0; + return value; } EXPORT_SYMBOL_GPL(divider_get_val);