From patchwork Mon Oct 5 05:07:14 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rajendra Nayak X-Patchwork-Id: 7324601 X-Patchwork-Delegate: agross@codeaurora.org Return-Path: X-Original-To: patchwork-linux-arm-msm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 860A89F32B for ; Mon, 5 Oct 2015 05:08:03 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id D008F206D7 for ; Mon, 5 Oct 2015 05:08:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A9975206CC for ; Mon, 5 Oct 2015 05:08:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751339AbbJEFHV (ORCPT ); Mon, 5 Oct 2015 01:07:21 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:41468 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751083AbbJEFHU (ORCPT ); Mon, 5 Oct 2015 01:07:20 -0400 Received: from smtp.codeaurora.org (localhost [127.0.0.1]) by smtp.codeaurora.org (Postfix) with ESMTP id 8F0B713F445; Mon, 5 Oct 2015 05:07:19 +0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 486) id 5E84713F6A5; Mon, 5 Oct 2015 05:07:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from [10.79.40.45] (unknown [202.46.23.61]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: rnayak@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id F3A7C13F445; Mon, 5 Oct 2015 05:07:16 +0000 (UTC) Message-ID: <56120582.1050707@codeaurora.org> Date: Mon, 05 Oct 2015 10:37:14 +0530 From: Rajendra Nayak User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: Stephen Boyd CC: Mike Turquette , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH] clk: qcom: Make oxili GDSC parent of oxili_cx GDSC References: <1443035362-10914-1-git-send-email-sboyd@codeaurora.org> <560CED90.9050201@codeaurora.org> <20151001175227.GE19319@codeaurora.org> <20151001190639.GI19319@codeaurora.org> In-Reply-To: <20151001190639.GI19319@codeaurora.org> X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP []... >>> It would also be nicer if this parent/child relationship can >>> somehow be represented in data (struct gdsc) that gets passed to >>> the gdsc driver which then sets it up, instead of individual >>> clock drivers doing it. >> >> Agreed. I'd rather that we do nothing besides register domains >> and then let the core code handle hooking up domains and >> subdomains. > > A little closer inspection makes me want to skip this. PM domains > can have multiple "master" domains, and pm_genpd_init() is the > only API that would be able to do the linking. That API is mostly > about initializing things to default values, so it doesn't seem > like a good fit. I'll send a v2 with the remove part and the > exports. What I was suggesting is that the qcom gdsc driver handle this instead of the qcom clock drivers. Something like.. diff --git a/drivers/clk/qcom/gdsc.c b/drivers/clk/qcom/gdsc.c index da9fad8..00edb2d 100644 --- a/drivers/clk/qcom/gdsc.c +++ b/drivers/clk/qcom/gdsc.c @@ -226,6 +226,8 @@ int gdsc_register(struct device *dev, struct gdsc **scs, size_t num, if (ret) return ret; data->domains[i] = &scs[i]->pd; + if (scs[i]->parent) + pm_genpd_add_subdomain(scs[i]->parent, &scs[i]->pd); } return of_genpd_add_provider_onecell(dev->of_node, data); diff --git a/drivers/clk/qcom/gdsc.h b/drivers/clk/qcom/gdsc.h index 5ded268..bc5791f 100644 --- a/drivers/clk/qcom/gdsc.h +++ b/drivers/clk/qcom/gdsc.h @@ -49,6 +49,7 @@ struct gdsc { struct reset_controller_dev *rcdev; unsigned int *resets; unsigned int reset_count; + struct generic_pm_domain *parent; }; #ifdef CONFIG_QCOM_GDSC diff --git a/drivers/clk/qcom/mmcc-msm8974.c b/drivers/clk/qcom/mmcc-msm8974.c index fe8320d..51ad8de 100644 --- a/drivers/clk/qcom/mmcc-msm8974.c +++ b/drivers/clk/qcom/mmcc-msm8974.c @@ -2400,6 +2400,7 @@ static struct gdsc oxilicx_gdsc = { .pd = { .name = "oxilicx", }, + .parent = &oxili_gdsc.pd, .pwrsts = PWRSTS_OFF_ON, };