| Message ID | 5a49bffc44c5f5bffe222560e489a712321ce971.1382985169.git.joshc@codeaurora.org (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
On 10/28/13 11:12, Josh Cartwright wrote: > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > index 914c3d1..0a288cb 100644 > --- a/drivers/mfd/Kconfig > +++ b/drivers/mfd/Kconfig > @@ -476,6 +476,16 @@ config MFD_PM8XXX_IRQ > This is required to use certain other PM 8xxx features, such as GPIO > and MPP. > > +config MFD_PM8X41 > + bool "Qualcomm PM8X41 PMIC" Can this be tristate? > + depends on ARCH_MSM It would be nice if we didn't have to depend on ARCH_MSM so we get some more build coverage but the driver is so simple it probably doesn't matter. > + select REGMAP_SPMI > + help > + This enables basic support for the Qualcomm 8941 and 8841 PMICs. These > + PMICs are currently used with the Snapdragon 800 series of SoCs. Note, that > + this will only be useful paired with descriptions of the independent functions > + as children nodes in the device tree. > + > config MFD_RDC321X > tristate "RDC R-321x southbridge" > select MFD_CORE > diff --git a/drivers/mfd/pm8x41.c b/drivers/mfd/pm8x41.c > new file mode 100644 > index 0000000..0a57221 > --- /dev/nullalso > +++ b/drivers/mfd/pm8x41.c > @@ -0,0 +1,64 @@ [...] > + > +static int pm8x41_probe(struct spmi_device *sdev) > +{ > + struct regmap *regmap; > + > + regmap = devm_regmap_init_spmi(sdev, &pm8x41_regmap_config); > + if (IS_ERR(regmap)) { > + dev_dbg(&sdev->dev, "regmap creation failed.\n"); > + return PTR_ERR(regmap); > + } > + > + return of_platform_populate(sdev->dev.of_node, NULL, NULL, &sdev->dev); > +} > + > +static struct of_device_id pm8x41_id_table[] = { const? > + { "qcom,pm8841", }, > + { "qcom,pm8941", }, > + {}, > +}; > +MODULE_DEVICE_TABLE(of, pm8x41_id_table); >
On Mon, 28 Oct 2013, Josh Cartwright wrote: > The Qualcomm 8941 and 8841 PMICs are components used with the Snapdragon > 800 series SoC family. This driver exists largely as a glue mfd component, > it exists to be an owner of an SPMI regmap for children devices > described in device tree. > > Signed-off-by: Josh Cartwright <joshc@codeaurora.org> > --- > drivers/mfd/Kconfig | 10 ++++++++ > drivers/mfd/Makefile | 1 + > drivers/mfd/pm8x41.c | 64 ++++++++++++++++++++++++++++++++++++++++++++++++++++ Can you CC me on your next submission, or it may not get applied.
On Tue, Oct 29, 2013 at 08:56:05AM -0700, Lee Jones wrote: > On Mon, 28 Oct 2013, Josh Cartwright wrote: > > > The Qualcomm 8941 and 8841 PMICs are components used with the Snapdragon > > 800 series SoC family. This driver exists largely as a glue mfd component, > > it exists to be an owner of an SPMI regmap for children devices > > described in device tree. > > > > Signed-off-by: Josh Cartwright <joshc@codeaurora.org> > > --- > > drivers/mfd/Kconfig | 10 ++++++++ > > drivers/mfd/Makefile | 1 + > > drivers/mfd/pm8x41.c | 64 ++++++++++++++++++++++++++++++++++++++++++++++++++++ > > Can you CC me on your next submission, or it may not get applied. Certainly. Sorry about that.
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig index 914c3d1..0a288cb 100644 --- a/drivers/mfd/Kconfig +++ b/drivers/mfd/Kconfig @@ -476,6 +476,16 @@ config MFD_PM8XXX_IRQ This is required to use certain other PM 8xxx features, such as GPIO and MPP. +config MFD_PM8X41 + bool "Qualcomm PM8X41 PMIC" + depends on ARCH_MSM + select REGMAP_SPMI + help + This enables basic support for the Qualcomm 8941 and 8841 PMICs. These + PMICs are currently used with the Snapdragon 800 series of SoCs. Note, that + this will only be useful paired with descriptions of the independent functions + as children nodes in the device tree. + config MFD_RDC321X tristate "RDC R-321x southbridge" select MFD_CORE diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile index 15b905c..ee4d338 100644 --- a/drivers/mfd/Makefile +++ b/drivers/mfd/Makefile @@ -149,6 +149,7 @@ obj-$(CONFIG_MFD_CS5535) += cs5535-mfd.o obj-$(CONFIG_MFD_OMAP_USB_HOST) += omap-usb-host.o omap-usb-tll.o obj-$(CONFIG_MFD_PM8921_CORE) += pm8921-core.o ssbi.o obj-$(CONFIG_MFD_PM8XXX_IRQ) += pm8xxx-irq.o +obj-$(CONFIG_MFD_PM8X41) += pm8x41.o obj-$(CONFIG_TPS65911_COMPARATOR) += tps65911-comparator.o obj-$(CONFIG_MFD_TPS65090) += tps65090.o obj-$(CONFIG_MFD_AAT2870_CORE) += aat2870-core.o diff --git a/drivers/mfd/pm8x41.c b/drivers/mfd/pm8x41.c new file mode 100644 index 0000000..0a57221 --- /dev/null +++ b/drivers/mfd/pm8x41.c @@ -0,0 +1,64 @@ +/* Copyright (c) 2013, The Linux Foundation. All rights reserved. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 and + * only version 2 as published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ +#include <linux/kernel.h> +#include <linux/module.h> +#include <linux/spmi.h> +#include <linux/regmap.h> +#include <linux/of_platform.h> + +static const struct regmap_config pm8x41_regmap_config = { + .reg_bits = 16, + .val_bits = 8, + .max_register = 0xFFFF, +}; + +static int pm8x41_remove_child(struct device *dev, void *unused) +{ + platform_device_unregister(to_platform_device(dev)); + return 0; +} + +static int pm8x41_remove(struct spmi_device *sdev) +{ + device_for_each_child(&sdev->dev, NULL, pm8x41_remove_child); + return 0; +} + +static int pm8x41_probe(struct spmi_device *sdev) +{ + struct regmap *regmap; + + regmap = devm_regmap_init_spmi(sdev, &pm8x41_regmap_config); + if (IS_ERR(regmap)) { + dev_dbg(&sdev->dev, "regmap creation failed.\n"); + return PTR_ERR(regmap); + } + + return of_platform_populate(sdev->dev.of_node, NULL, NULL, &sdev->dev); +} + +static struct of_device_id pm8x41_id_table[] = { + { "qcom,pm8841", }, + { "qcom,pm8941", }, + {}, +}; +MODULE_DEVICE_TABLE(of, pm8x41_id_table); + +static struct spmi_driver pm8x41_driver = { + .probe = pm8x41_probe, + .remove = pm8x41_remove, + .driver = { + .name = "qpnp,pm8x41", + .of_match_table = pm8x41_id_table, + }, +}; +module_spmi_driver(pm8x41_driver);
The Qualcomm 8941 and 8841 PMICs are components used with the Snapdragon 800 series SoC family. This driver exists largely as a glue mfd component, it exists to be an owner of an SPMI regmap for children devices described in device tree. Signed-off-by: Josh Cartwright <joshc@codeaurora.org> --- drivers/mfd/Kconfig | 10 ++++++++ drivers/mfd/Makefile | 1 + drivers/mfd/pm8x41.c | 64 ++++++++++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 75 insertions(+) create mode 100644 drivers/mfd/pm8x41.c