Message ID | 71817f920176103fa387cad14e8d7d38b3636e6a.1553086065.git.amit.kucheria@linaro.org (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <linux-arm-msm-owner@kernel.org> Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0730E17E9 for <patchwork-linux-arm-msm@patchwork.kernel.org>; Wed, 20 Mar 2019 13:20:39 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EA2D829B82 for <patchwork-linux-arm-msm@patchwork.kernel.org>; Wed, 20 Mar 2019 13:20:38 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id DC76029BE1; Wed, 20 Mar 2019 13:20:38 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_WEB autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9643B29BD8 for <patchwork-linux-arm-msm@patchwork.kernel.org>; Wed, 20 Mar 2019 13:20:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727870AbfCTNUd (ORCPT <rfc822;patchwork-linux-arm-msm@patchwork.kernel.org>); Wed, 20 Mar 2019 09:20:33 -0400 Received: from mail-pf1-f194.google.com ([209.85.210.194]:46187 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728250AbfCTNTR (ORCPT <rfc822;linux-arm-msm@vger.kernel.org>); Wed, 20 Mar 2019 09:19:17 -0400 Received: by mail-pf1-f194.google.com with SMTP id 9so1674353pfj.13 for <linux-arm-msm@vger.kernel.org>; Wed, 20 Mar 2019 06:19:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=J8JlGYbgg/zRqWjBOjDxf78JZ4BdingiWMKoRwZVd2w=; b=iWl+Jh9lxol2sN66KVe+2+jJwlqM+v2Sl2GnWQwxNRv4PVDX1DEtKSrsoBB6Qch0rH U/qFwGXqMkbG58fzPYfTKEbpF6tSLb7kRg38a9BZ0gVI9NpkhqBLScgb5YStrLtHyWpw VFFCsZFJAy6xi3tPGWeP8b2FBGh5SRMcSGHg30bhWomsAHb0R/mdTGkq38HBicgImpZd LUYhfTvq+l4i5X9wxDekvm5AdK9tFHKfXUkA9z7v+Aca/dIrfsiNLB6EBl7FdRM32CHB UsWnoRlfC3oIwiAAv+1J0eAtkfGqaxCZpd2vhMYyZNR0rseJUguKhiSVXe7//ZSOTIEt iHGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=J8JlGYbgg/zRqWjBOjDxf78JZ4BdingiWMKoRwZVd2w=; b=bzykoCjKypRoVIm24bR6f7CSB4QB9eccTfurHqTchGwDgbbInODmYG6xHa5+v683yA hQdPvSWE02yKcFF5J/QeLDYgqg7TL3P+JsxB0FQ/Ct6WOtwqvxY/Q4E11LUgn5Q5akQU MkXNGy93AZzlR+fm1yfa0M8qy/KMs/pHFiGc++KV6Sfjl/eF/mLM+Zjkg+5rDuaFa3uJ gdOKmH/PTTCf0z/LqMa2idOgOt8GiFt2j3cG+q153tiBjAQ1K0b4LJ6vVQLzkEw539vL FLA+/BwlIDeeoBnvtllEkjws/WDq+BsiEOS2/JoVC3az1hjIm92t+n1jl0hVQy9x6Krt xLEQ== X-Gm-Message-State: APjAAAWmg/kZCR5v+jQWYlaD7hTtKBWT2CHqOJlf7DWd+ILPNAwL+hZC eIQYsJQchfGfuR1XMCf0qLyVZA== X-Google-Smtp-Source: APXvYqyF/+1HkBB1QB7ygp+WXkTaNQqkPdgEA+ShZBrkQC8wxak16xOQmLL/X9K2HCCUruBt3J/BvA== X-Received: by 2002:a17:902:2f43:: with SMTP id s61mr8037789plb.158.1553087957020; Wed, 20 Mar 2019 06:19:17 -0700 (PDT) Received: from localhost ([114.143.122.221]) by smtp.gmail.com with ESMTPSA id j6sm3801719pfe.79.2019.03.20.06.19.15 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 20 Mar 2019 06:19:16 -0700 (PDT) From: Amit Kucheria <amit.kucheria@linaro.org> To: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, bjorn.andersson@linaro.org, edubezval@gmail.com, andy.gross@linaro.org, Daniel Lezcano <daniel.lezcano@linaro.org>, David Brown <david.brown@linaro.org>, Zhang Rui <rui.zhang@intel.com> Cc: linux-pm@vger.kernel.org Subject: [PATCHv3 12/23] drivers: thermal: tsens: Don't print error message on -EPROBE_DEFER Date: Wed, 20 Mar 2019 18:47:52 +0530 Message-Id: <71817f920176103fa387cad14e8d7d38b3636e6a.1553086065.git.amit.kucheria@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <cover.1553086065.git.amit.kucheria@linaro.org> References: <cover.1553086065.git.amit.kucheria@linaro.org> In-Reply-To: <cover.1553086065.git.amit.kucheria@linaro.org> References: <cover.1553086065.git.amit.kucheria@linaro.org> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: <linux-arm-msm.vger.kernel.org> X-Mailing-List: linux-arm-msm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP |
Series |
thermal: tsens: Refactor to use regmap_field
|
expand
|
diff --git a/drivers/thermal/qcom/tsens.c b/drivers/thermal/qcom/tsens.c index b91a0b88d33c..057b33353ba3 100644 --- a/drivers/thermal/qcom/tsens.c +++ b/drivers/thermal/qcom/tsens.c @@ -159,7 +159,8 @@ static int tsens_probe(struct platform_device *pdev) if (priv->ops->calibrate) { ret = priv->ops->calibrate(priv); if (ret < 0) { - dev_err(dev, "tsens calibration failed\n"); + if (ret != -EPROBE_DEFER) + dev_err(dev, "tsens calibration failed\n"); return ret; } }
We print a calibration failure message on -EPROBE_DEFER from nvmem/qfprom as follows: [ 3.003090] qcom-tsens 4a9000.thermal-sensor: version: 1.4 [ 3.005376] qcom-tsens 4a9000.thermal-sensor: tsens calibration failed [ 3.113248] qcom-tsens 4a9000.thermal-sensor: version: 1.4 This confuses people when, in fact, calibration succeeds later when nvmem/qfprom device is available. Don't print this message on a -EPROBE_DEFER. Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org> --- drivers/thermal/qcom/tsens.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)