| Message ID | 7ddaf7dc192c5f03f70d27297551e758a39a4ab5.1642768837.git.quic_schowdhu@quicinc.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add Embedded USB Debugger (EUD) driver | expand |
On Fri 21 Jan 07:53 CST 2022, Souradeep Chowdhury wrote: > Add the ports property for dwc3 node. This port can be used > by the Embedded USB Debugger for role switching the controller > from device to host mode and vice versa. > > Signed-off-by: Souradeep Chowdhury <quic_schowdhu@quicinc.com> > --- > Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml > index d29ffcd..ccb1236 100644 > --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml > +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml > @@ -332,6 +332,16 @@ properties: > items: > enum: [1, 4, 8, 16, 32, 64, 128, 256] > > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + description: > + This port is to be attached to the endpoint of the Embedded USB Debugger. More generally this is used together with the already documented usb-role-switch property to connect the dwc3 to the Type-C connector. Which makes me feel that we don't actually need ports/port, but could do with just port? Perhaps I'm missing some usecase? I'm somewhat confused to why this isn't already documented... Regards, Bjorn > + > + properties: > + port@0: > + $ref: /schemas/graph.yaml#/properties/port > + description: Connector endpoint of Embedded USB debugger. > + > unevaluatedProperties: false > > required: > -- > 2.7.4 >
On 1/26/2022 9:51 AM, Bjorn Andersson wrote: > On Fri 21 Jan 07:53 CST 2022, Souradeep Chowdhury wrote: > >> Add the ports property for dwc3 node. This port can be used >> by the Embedded USB Debugger for role switching the controller >> from device to host mode and vice versa. >> >> Signed-off-by: Souradeep Chowdhury <quic_schowdhu@quicinc.com> >> --- >> Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml >> index d29ffcd..ccb1236 100644 >> --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml >> +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml >> @@ -332,6 +332,16 @@ properties: >> items: >> enum: [1, 4, 8, 16, 32, 64, 128, 256] >> >> + ports: >> + $ref: /schemas/graph.yaml#/properties/ports >> + description: >> + This port is to be attached to the endpoint of the Embedded USB Debugger. > More generally this is used together with the already documented > usb-role-switch property to connect the dwc3 to the Type-C connector. > > Which makes me feel that we don't actually need ports/port, but could do > with just port? Perhaps I'm missing some usecase? > > > I'm somewhat confused to why this isn't already documented... Ack. Will document this as a port. > > Regards, > Bjorn > >> + >> + properties: >> + port@0: >> + $ref: /schemas/graph.yaml#/properties/port >> + description: Connector endpoint of Embedded USB debugger. >> + >> unevaluatedProperties: false >> >> required: >> -- >> 2.7.4 >>
diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml index d29ffcd..ccb1236 100644 --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml @@ -332,6 +332,16 @@ properties: items: enum: [1, 4, 8, 16, 32, 64, 128, 256] + ports: + $ref: /schemas/graph.yaml#/properties/ports + description: + This port is to be attached to the endpoint of the Embedded USB Debugger. + + properties: + port@0: + $ref: /schemas/graph.yaml#/properties/port + description: Connector endpoint of Embedded USB debugger. + unevaluatedProperties: false required:
Add the ports property for dwc3 node. This port can be used by the Embedded USB Debugger for role switching the controller from device to host mode and vice versa. Signed-off-by: Souradeep Chowdhury <quic_schowdhu@quicinc.com> --- Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 10 ++++++++++ 1 file changed, 10 insertions(+)