| Message ID | 82799fec-6e03-b0ce-dfa2-dc12324a6c5e@free.fr (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [RFC,v1] arm64: dts: qcom: msm8998: Add rpmcc node | expand |
On 1/11/2019 7:42 AM, Marc Gonzalez wrote: > Add MSM8998 Resource Power Manager Clock Controller DT node. > > Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr> > --- > arch/arm64/boot/dts/qcom/msm8998.dtsi | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi > index 8d41b69ec2da..de37415be0a8 100644 > --- a/arch/arm64/boot/dts/qcom/msm8998.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi > @@ -3,6 +3,7 @@ > > #include <dt-bindings/interrupt-controller/arm-gic.h> > #include <dt-bindings/clock/qcom,gcc-msm8998.h> > +#include <dt-bindings/clock/qcom,rpmcc.h> > #include <dt-bindings/gpio/gpio.h> > > / { > @@ -266,6 +267,11 @@ > rpm_requests: rpm-requests { > compatible = "qcom,rpm-msm8998"; > qcom,glink-channels = "rpm_requests"; > + > + rpmcc: qcom,rpmcc { > + compatible = "qcom,rpmcc-msm8998", "qcom,rpmcc"; > + #clock-cells = <1>; > + }; > }; > }; > > Reviewed-by: Jeffrey Hugo <jhugo@codeaurora.org>
Hi Marc, On 1/11/19 16:42, Marc Gonzalez wrote: > Add MSM8998 Resource Power Manager Clock Controller DT node. > > Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr> > --- > arch/arm64/boot/dts/qcom/msm8998.dtsi | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi > index 8d41b69ec2da..de37415be0a8 100644 > --- a/arch/arm64/boot/dts/qcom/msm8998.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi > @@ -3,6 +3,7 @@ > > #include <dt-bindings/interrupt-controller/arm-gic.h> > #include <dt-bindings/clock/qcom,gcc-msm8998.h> > +#include <dt-bindings/clock/qcom,rpmcc.h> > #include <dt-bindings/gpio/gpio.h> > > / { > @@ -266,6 +267,11 @@ > rpm_requests: rpm-requests { > compatible = "qcom,rpm-msm8998"; > qcom,glink-channels = "rpm_requests"; > + > + rpmcc: qcom,rpmcc { Maybe use "clock-controller" as node name instead of "qcom,rpmcc". Thanks, Georgi > + compatible = "qcom,rpmcc-msm8998", "qcom,rpmcc"; > + #clock-cells = <1>; > + }; > }; > }; > >
On Fri 11 Jan 09:01 PST 2019, Georgi Djakov wrote: > Hi Marc, > > On 1/11/19 16:42, Marc Gonzalez wrote: > > Add MSM8998 Resource Power Manager Clock Controller DT node. > > > > Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr> > > --- > > arch/arm64/boot/dts/qcom/msm8998.dtsi | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi > > index 8d41b69ec2da..de37415be0a8 100644 > > --- a/arch/arm64/boot/dts/qcom/msm8998.dtsi > > +++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi > > @@ -3,6 +3,7 @@ > > > > #include <dt-bindings/interrupt-controller/arm-gic.h> > > #include <dt-bindings/clock/qcom,gcc-msm8998.h> > > +#include <dt-bindings/clock/qcom,rpmcc.h> > > #include <dt-bindings/gpio/gpio.h> > > > > / { > > @@ -266,6 +267,11 @@ > > rpm_requests: rpm-requests { > > compatible = "qcom,rpm-msm8998"; > > qcom,glink-channels = "rpm_requests"; > > + > > + rpmcc: qcom,rpmcc { > > Maybe use "clock-controller" as node name instead of "qcom,rpmcc". > I agree with Georgi, name this "clock-controller". With that, you have my Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> Regards, Bjorn
diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi index 8d41b69ec2da..de37415be0a8 100644 --- a/arch/arm64/boot/dts/qcom/msm8998.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi @@ -3,6 +3,7 @@ #include <dt-bindings/interrupt-controller/arm-gic.h> #include <dt-bindings/clock/qcom,gcc-msm8998.h> +#include <dt-bindings/clock/qcom,rpmcc.h> #include <dt-bindings/gpio/gpio.h> / { @@ -266,6 +267,11 @@ rpm_requests: rpm-requests { compatible = "qcom,rpm-msm8998"; qcom,glink-channels = "rpm_requests"; + + rpmcc: qcom,rpmcc { + compatible = "qcom,rpmcc-msm8998", "qcom,rpmcc"; + #clock-cells = <1>; + }; }; };
Add MSM8998 Resource Power Manager Clock Controller DT node. Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr> --- arch/arm64/boot/dts/qcom/msm8998.dtsi | 6 ++++++ 1 file changed, 6 insertions(+)