From patchwork Thu Mar 28 17:36:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marc Gonzalez X-Patchwork-Id: 13609261 Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com [209.85.208.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C2F7535CA for ; Thu, 28 Mar 2024 17:39:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711647582; cv=none; b=MV4YGpddrHgQTD7yW8EiMKeNfm8ZkJUBJb7UVv+PyQbQJSSrNwDbFMgzAS6md7HYFlVb9s3B2MrySlMwrOeDv/kXZPpya25oRH8P4EVHErJR+JERoPzcQWi/oSdCfpg4WyBDK0LfA9F1DbrWIbRjSkYSqAZV+U3cqvAyFl25DEE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711647582; c=relaxed/simple; bh=cBrfrQiFvoFDuBlj4G0fb4q9qQbWu3wbg1FHrBsVYcU=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=kQy4AeTw+PUWcQh+V+syD61DYqj7ChgJ4DBOzPNFEzhExKcCIldFZCvctCwqZTrLkaExf8ak4yPTLoI229EfWNFh1w0wSC1TJGHguec8WB+SeF88airmsbLeRVQ5TA00RBm2LFy56PmpW6WySRByhwDwPi7MSteMWYpnTyoUqn0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=freebox.fr; spf=pass smtp.mailfrom=freebox.fr; dkim=pass (2048-bit key) header.d=freebox-fr.20230601.gappssmtp.com header.i=@freebox-fr.20230601.gappssmtp.com header.b=ekDE738L; arc=none smtp.client-ip=209.85.208.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=freebox.fr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=freebox.fr Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=freebox-fr.20230601.gappssmtp.com header.i=@freebox-fr.20230601.gappssmtp.com header.b="ekDE738L" Received: by mail-lj1-f176.google.com with SMTP id 38308e7fff4ca-2d68c6a4630so13001711fa.3 for ; Thu, 28 Mar 2024 10:39:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebox-fr.20230601.gappssmtp.com; s=20230601; t=1711647578; x=1712252378; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=5+f/pRvSBwUdMhwHshcL4qVDbpYUW3TaHUiQYZdgH3I=; b=ekDE738LvzLTzlbZBNxWEamtTP1HWEg8vpYfcFee6UYcav51y/ApzbGDlrvaCJ6Sx7 8TtZ+8R2/uljKBoHQ0Q3QlOjVOQBivKTGPuW9ZIsek1asrqr/xnfYHpIXjkYg7y8ZyH1 /NYAV94Hf1TsD5qEmwy7sw8fa2KbQlX3l5RB6CyGydkN5bzqvJZI4oTH3QuiqLGrBbMk VaAR6gmLfX8ekfHK9fDheLOd4dkOKsk5rteWHENZQMl5KvKyyCP6ibioXXlYJQG0RBW4 BB1APMrF79N7NT7uVhfSgHFul5KNwxEWNhhNXIod4+q97JkFH7Fr6wuPXnsfRsDRs6UL BRqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711647578; x=1712252378; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5+f/pRvSBwUdMhwHshcL4qVDbpYUW3TaHUiQYZdgH3I=; b=th2eDgeDQsF5uy01ZieK6nr9+amuqtHPqt8ZgRU4D9qa+oRZIiGhN7P0iNypfOtaKN rPXqVt0DDYUTSebRv/l50/CwUMXe9MIXEfnhOIOc6+Ljcvek73c+EiC33mjQWa7mMv9t Empj1Yl9IQGCXYu1I94mQ2EKBfy/gi8SKDkZn4igPOhtYzspLtEDPf+ehz6YQqUmuSD0 LDTLiSXnY2IC5aLEKublQk6m0/v6YRANat0bXWZux7ksjL+8/bLhqNulAq94DDzlhxTk FR0MuqU6/WaRsXnIcxBNDGG81xiFQfk95OUWmmCLGfgCD3RjzkCbdw/CzFXWlVIuxEyY nSWg== X-Forwarded-Encrypted: i=1; AJvYcCUBw/MWFu7bGNzNRm8eYuGTKI//QwMDO2vj45z6F+8UQeAcHv76C09YWTBkGzfeKJV4If2kGugrK8v9mHkRSqbxsO9gNRdN/EkmqJnqlw== X-Gm-Message-State: AOJu0Yxpt3JZkpSZmKykiuKRK0u/jYrcyMQCD1m33Rj/YwbPVIXhvxGn FU0lTz5ahdRcdXAvv3pICimSIUAYw2y+DfaeDRLpPfKD78Q+qdQWQdsXdO+eHAI= X-Google-Smtp-Source: AGHT+IFQBU18T0uIaawzs7r5eRFygg/fKL4VZsh6uLptoa/iScmPmWB9yGQE9bSbSrdNC/yyfCQCNQ== X-Received: by 2002:a2e:960e:0:b0:2d6:e0a9:9981 with SMTP id v14-20020a2e960e000000b002d6e0a99981mr2780077ljh.9.1711647578125; Thu, 28 Mar 2024 10:39:38 -0700 (PDT) Received: from [192.168.108.81] (freebox.vlq16.iliad.fr. [213.36.7.13]) by smtp.gmail.com with ESMTPSA id o10-20020a05600c510a00b004148a5e3188sm6066643wms.25.2024.03.28.10.39.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Mar 2024 10:39:37 -0700 (PDT) Message-ID: <84f20fb5-5d48-419c-8eff-d7044afb81c0@freebox.fr> Date: Thu, 28 Mar 2024 18:36:48 +0100 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v2 1/3] dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop Content-Language: en-US From: Marc Gonzalez To: Kalle Valo , Jeff Johnson , ath10k Cc: wireless , DT , MSM , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Pierre-Hugues Husson , Arnaud Vrac , Bjorn Andersson , Konrad Dybcio , Jami Kettunen , Jeffrey Hugo References: In-Reply-To: The ath10k driver waits for an "MSA_READY" indicator to complete initialization. If the indicator is not received, then the device remains unusable. cf. ath10k_qmi_driver_event_work() Several msm8998-based devices are affected by this issue. Oddly, it seems safe to NOT wait for the indicator, and proceed immediately when QMI_EVENT_SERVER_ARRIVE. Jeff Johnson wrote: The feedback I received was "it might be ok to change all ath10k qmi to skip waiting for msa_ready", and it was pointed out that ath11k (and ath12k) do not wait for it. However with so many deployed devices, "might be ok" isn't a strong argument for changing the default behavior. Signed-off-by: Pierre-Hugues Husson Signed-off-by: Marc Gonzalez --- Documentation/devicetree/bindings/net/wireless/qcom,ath10k.yaml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.yaml index 9b3ef4bc37325..1680604cd1b7e 100644 --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.yaml +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.yaml @@ -122,6 +122,13 @@ properties: Whether to skip executing an SCM call that reassigns the memory region ownership. + qcom,no-msa-ready-indicator: + type: boolean + description: + The driver waits for an MSA_READY indicator to complete init. + If the indicator is not received, interface remains unusable. + Pretending we received the indicator works around the issue. + qcom,smem-states: $ref: /schemas/types.yaml#/definitions/phandle-array description: State bits used by the AP to signal the WLAN Q6.