From patchwork Thu Sep 4 14:47:40 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tim Bird X-Patchwork-Id: 4846581 Return-Path: X-Original-To: patchwork-linux-arm-msm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 9643BC0338 for ; Thu, 4 Sep 2014 14:47:53 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id DAFC720211 for ; Thu, 4 Sep 2014 14:47:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DB6EB2026C for ; Thu, 4 Sep 2014 14:47:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751764AbaIDOrn (ORCPT ); Thu, 4 Sep 2014 10:47:43 -0400 Received: from mail-lb0-f172.google.com ([209.85.217.172]:54526 "EHLO mail-lb0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751379AbaIDOrm (ORCPT ); Thu, 4 Sep 2014 10:47:42 -0400 Received: by mail-lb0-f172.google.com with SMTP id c11so3452417lbj.3 for ; Thu, 04 Sep 2014 07:47:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=357GIJ3Wwh4BPlmkgSwiei+oVcWuyY9FHi9XXcH9dfE=; b=Gzrcca8Qes0IvR9HZAW9wsdPyraUhXPEg5g3lbgzRBzb5jUw4JLd7dGRwysABvVdsL t2As/2/9ttxRHfTtRJQjDGYRMN4JUCqGQiUrO3lat5anyZQU4UHJCB6NKRWFfC7dpfIZ 7qHJgfo/vlRoYvlEv6cM03ihmhv/EXuh4l3mvcB61l7nOZzeK8wySAjIvkjLxNShS2Cy ACFMLhVcToZ50u6ZKmo5n07Dg2IsdvdY7MoomS8oid87il72zrvREbDeAWhq8+DqoJFi WUVbowb3QPql49JtoosKrDy51PXRFhLQN3Hae1sp9oo9wBgkolA0l5p5r30PTGJRWlVa ZStw== MIME-Version: 1.0 X-Received: by 10.112.118.141 with SMTP id km13mr4876451lbb.37.1409842060441; Thu, 04 Sep 2014 07:47:40 -0700 (PDT) Received: by 10.25.17.139 with HTTP; Thu, 4 Sep 2014 07:47:40 -0700 (PDT) In-Reply-To: <1408086522.2695.19.camel@iivanov-dev> References: <20140814165402.GA1445@saruman.home> <20140815002339.GA2710@peterchendt> <1408086522.2695.19.camel@iivanov-dev> Date: Thu, 4 Sep 2014 07:47:40 -0700 Message-ID: Subject: Re: Fwd: Status of chipidea msm USB reset patch From: Tim Bird To: Peter Chen Cc: "Ivan T. Ivanov" , "linux-arm-msm@vger.kernel.org" , "linux-usb@vger.kernel.org" , Greg Kroah-Hartman Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Spam-Status: No, score=-8.4 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Fri, Aug 15, 2014 at 12:08 AM, Ivan T. Ivanov wrote: > On Fri, 2014-08-15 at 08:23 +0800, Peter Chen wrote: >> On Thu, Aug 14, 2014 at 11:54:02AM -0500, Felipe Balbi wrote: >> > Hi, >> > >> > On Thu, Aug 14, 2014 at 09:53:10AM -0700, Tim Bird wrote: >> > > Ping. Anybody know the status of this patch? Is it queued in someone's tree? >> > > Without it the USB driver for the Qualcomm 8974 (hsusb phy) doesn't >> > > work (at least for me). >> > > It looks like it got dropped from Ivan's original patch series, back in May. >> > >> > I don't maintain chipidea, Peter's the guy you want >> >> Below patch was not at msm chipidea patchset Ivan sent me. >> >> http://markmail.org/search/?q=%5BPATCH+v4+0%2F3%5D+usb%3A+chipidea%3A+msm%3A+Clean+and+fix+#query:%5BPATCH%20v4%200%2F3%5D%20usb%3A%20chipidea%3A%20msm%3A%20Clean%20and%20fix%20from%3A%22Ivan%20T.%20Ivanov%22+page:1+mid:mt7hgr7yamyzegg3+state:results >> > > > My fault. I have waiting PHY patches to be accepted to send this one. > Will rebase and resend. Peter, There appears to be no progress on this. Can we just add the existing patch, get it into Linus' tree asap as a bugfix (preferably in this RC cycle)? Then ask Ivan to rebase his patches on top of this, instead of rebasing this patch as part of a larger effort with an unclear delivery date? Note that without this patch, the driver in mainline doesn't work at all, so adding it couldn't possibly make mainline worse. IMHO this should be CC:'ed to stable for the 3.16 kernel as well. No other files are affected, and it applies and builds on 3.16 without problems. Please let me know. -- Tim Bird Senior Software Engineer, Sony Mobile Architecture Group Chair, CE Workgroup, Linux Foundation Patch follows for reference: Subject: [PATCH] usb: chipidea: msm: Use USB PHY API to control PHY state PHY drivers keep track of the current state of the hardware, so don't change PHY settings under it. Signed-off-by: Ivan T. Ivanov --- drivers/usb/chipidea/ci_hdrc_msm.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) dev_dbg(dev, "unknown ci_hdrc event\n"); diff --git a/drivers/usb/chipidea/ci_hdrc_msm.c b/drivers/usb/chipidea/ci_hdrc_msm.c index d72b9d2..81de834 100644 --- a/drivers/usb/chipidea/ci_hdrc_msm.c +++ b/drivers/usb/chipidea/ci_hdrc_msm.c @@ -20,13 +20,11 @@ static void ci_hdrc_msm_notify_event(struct ci_hdrc *ci, unsigned event) { struct device *dev = ci->gadget.dev.parent; - int val; switch (event) { case CI_HDRC_CONTROLLER_RESET_EVENT: dev_dbg(dev, "CI_HDRC_CONTROLLER_RESET_EVENT received\n"); - writel(0, USB_AHBBURST); - writel(0, USB_AHBMODE); + usb_phy_init(ci->transceiver); break; case CI_HDRC_CONTROLLER_STOPPED_EVENT: dev_dbg(dev, "CI_HDRC_CONTROLLER_STOPPED_EVENT received\n"); @@ -34,10 +32,7 @@ static void ci_hdrc_msm_notify_event(struct ci_hdrc *ci, unsigned event) * Put the transceiver in non-driving mode. Otherwise host * may not detect soft-disconnection. */ - val = usb_phy_io_read(ci->transceiver, ULPI_FUNC_CTRL); - val &= ~ULPI_FUNC_CTRL_OPMODE_MASK; - val |= ULPI_FUNC_CTRL_OPMODE_NONDRIVING; - usb_phy_io_write(ci->transceiver, val, ULPI_FUNC_CTRL); + usb_phy_notify_disconnect(ci->transceiver, USB_SPEED_UNKNOWN); break; default: