| Message ID | b6f139947e93fec1ade5faf3517dfb2b3b9bcd41.1617867599.git.mchehab+huawei@kernel.org (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | [1/3] media: venus: use NULL instead of zero for pointers | expand |
Hi Mauro, On 4/8/21 10:40 AM, Mauro Carvalho Chehab wrote: > As reported by sparse: > > drivers/media/platform/qcom/venus/core.c:227:41: warning: Using plain integer as NULL pointer > drivers/media/platform/qcom/venus/core.c:228:34: warning: Using plain integer as NULL pointer > > Two vars are using zero instead of NULL for pointers. Not really > an issue, but using NULL makes it clearer that the init data is > expecting a pointer. > > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> > --- > drivers/media/platform/qcom/venus/core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Acked-by: Stanimir Varbanov <stanimir.varbanov@linaro.org> > > diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c > index f5b88b96f5f7..4451e3c11bc0 100644 > --- a/drivers/media/platform/qcom/venus/core.c > +++ b/drivers/media/platform/qcom/venus/core.c > @@ -224,8 +224,8 @@ static void venus_assign_register_offsets(struct venus_core *core) > core->cpu_cs_base = core->base + CPU_CS_BASE; > core->cpu_ic_base = core->base + CPU_IC_BASE; > core->wrapper_base = core->base + WRAPPER_BASE; > - core->wrapper_tz_base = 0; > - core->aon_base = 0; > + core->wrapper_tz_base = NULL; > + core->aon_base = NULL; > } > } > >
diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c index f5b88b96f5f7..4451e3c11bc0 100644 --- a/drivers/media/platform/qcom/venus/core.c +++ b/drivers/media/platform/qcom/venus/core.c @@ -224,8 +224,8 @@ static void venus_assign_register_offsets(struct venus_core *core) core->cpu_cs_base = core->base + CPU_CS_BASE; core->cpu_ic_base = core->base + CPU_IC_BASE; core->wrapper_base = core->base + WRAPPER_BASE; - core->wrapper_tz_base = 0; - core->aon_base = 0; + core->wrapper_tz_base = NULL; + core->aon_base = NULL; } }
As reported by sparse: drivers/media/platform/qcom/venus/core.c:227:41: warning: Using plain integer as NULL pointer drivers/media/platform/qcom/venus/core.c:228:34: warning: Using plain integer as NULL pointer Two vars are using zero instead of NULL for pointers. Not really an issue, but using NULL makes it clearer that the init data is expecting a pointer. Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> --- drivers/media/platform/qcom/venus/core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)