diff mbox series

[1/2] Changing Ardreno X185 Check to X1xxx Family Check

Message ID eXTmCkW-1fFjQPMz9pDuTV6stWYM2-k_vUP8hhFhSQGIVNAITUWcadIMLvtpufgBOIUY4S8RYGU-vSxIEehZknZv9n1tnS2ivaSvUSyQpGQ=@protonmail.com (mailing list archive)
State Not Applicable
Headers show
Series [1/2] Changing Ardreno X185 Check to X1xxx Family Check | expand

Commit Message

John Schulz Sept. 21, 2024, 1:03 a.m. UTC 
Hello,

First time submitting a patch. As work is made towards integrating more QCOM X1E and X1P SoCs, using a family identification function seems better fit than checking individual devices. 

Thanks,

Comments

Dmitry Baryshkov Sept. 21, 2024, 7:27 a.m. UTC | #1 
On Sat, Sep 21, 2024 at 01:03:00AM GMT, John Schulz wrote:
> Hello,
> 
> First time submitting a patch. As work is made towards integrating more QCOM X1E and X1P SoCs, using a family identification function seems better fit than checking individual devices. 


Please use git commit and then git format-patch / git send-email to
format and send patches.

Commit message is not an email text but rather a patch description. It
should explain why you made the change.

Patches should be atomic and non-breaking. E.g. if I pick this patch w/o
picking up 2/2 build will break. We frequently use git bisect, which
means that (ideally) after each commit the kernel should still build.

Last, but not least, your patch misses DCO signature.

Please take a glance at Documentation/process, especially
submitting-patches.rst.

> 
> Thanks,
> 
> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
> index 06cab2c6fd66..34ca8f6d5d99 100644
> --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
> +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
> @@ -1026,7 +1026,7 @@ static int hw_init(struct msm_gpu *gpu)
>  	gpu_write(gpu, REG_A6XX_UCHE_CLIENT_PF, BIT(7) | 0x1);
>  
>  	/* Set weights for bicubic filtering */
> -	if (adreno_is_a650_family(adreno_gpu) || adreno_is_x185(adreno_gpu)) {
> +	if (adreno_is_a650_family(adreno_gpu) || adreno_is_x1xx_family(adreno_gpu)) {
>  		gpu_write(gpu, REG_A6XX_TPL1_BICUBIC_WEIGHTS_TABLE_0, 0);
>  		gpu_write(gpu, REG_A6XX_TPL1_BICUBIC_WEIGHTS_TABLE_1,
>  			0x3fe05ff4);
John Schulz Sept. 21, 2024, 8:44 p.m. UTC | #2 
Hello,

Thank you for your insight and my apologies on messing up the first one. I have submitted a fixed one that uses git and send mail. 

Thank you,
John Schulz

On Saturday, September 21st, 2024 at 3:27 AM, Dmitry Baryshkov <dmitry.baryshkov@linaro.org> wrote:

> 
> 
> On Sat, Sep 21, 2024 at 01:03:00AM GMT, John Schulz wrote:
> 
> > Hello,
> > 
> > First time submitting a patch. As work is made towards integrating more QCOM X1E and X1P SoCs, using a family identification function seems better fit than checking individual devices.
> 
> 
> 
> Please use git commit and then git format-patch / git send-email to
> format and send patches.
> 
> Commit message is not an email text but rather a patch description. It
> should explain why you made the change.
> 
> Patches should be atomic and non-breaking. E.g. if I pick this patch w/o
> picking up 2/2 build will break. We frequently use git bisect, which
> means that (ideally) after each commit the kernel should still build.
> 
> Last, but not least, your patch misses DCO signature.
> 
> Please take a glance at Documentation/process, especially
> submitting-patches.rst.
> 
> > Thanks,
> > 
> > diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
> > index 06cab2c6fd66..34ca8f6d5d99 100644
> > --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
> > +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
> > @@ -1026,7 +1026,7 @@ static int hw_init(struct msm_gpu *gpu)
> > gpu_write(gpu, REG_A6XX_UCHE_CLIENT_PF, BIT(7) | 0x1);
> > 
> > /* Set weights for bicubic filtering */
> > - if (adreno_is_a650_family(adreno_gpu) || adreno_is_x185(adreno_gpu)) {
> > + if (adreno_is_a650_family(adreno_gpu) || adreno_is_x1xx_family(adreno_gpu)) {
> > gpu_write(gpu, REG_A6XX_TPL1_BICUBIC_WEIGHTS_TABLE_0, 0);
> > gpu_write(gpu, REG_A6XX_TPL1_BICUBIC_WEIGHTS_TABLE_1,
> > 0x3fe05ff4);
> 
> 
> --
> With best wishes
> Dmitry
diff mbox series

Patch

diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
index 06cab2c6fd66..34ca8f6d5d99 100644
--- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
+++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
@@ -1026,7 +1026,7 @@  static int hw_init(struct msm_gpu *gpu)
 	gpu_write(gpu, REG_A6XX_UCHE_CLIENT_PF, BIT(7) | 0x1);
 
 	/* Set weights for bicubic filtering */
-	if (adreno_is_a650_family(adreno_gpu) || adreno_is_x185(adreno_gpu)) {
+	if (adreno_is_a650_family(adreno_gpu) || adreno_is_x1xx_family(adreno_gpu)) {
 		gpu_write(gpu, REG_A6XX_TPL1_BICUBIC_WEIGHTS_TABLE_0, 0);
 		gpu_write(gpu, REG_A6XX_TPL1_BICUBIC_WEIGHTS_TABLE_1,
 			0x3fe05ff4);