From patchwork Mon Oct 29 08:49:07 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "jianchao.wang" X-Patchwork-Id: 10658849 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id AC3F41751 for ; Mon, 29 Oct 2018 08:49:53 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9E18329724 for ; Mon, 29 Oct 2018 08:49:53 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8FBA729730; Mon, 29 Oct 2018 08:49:53 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 36C0F29724 for ; Mon, 29 Oct 2018 08:49:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729473AbeJ2RhJ (ORCPT ); Mon, 29 Oct 2018 13:37:09 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:36698 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729343AbeJ2RhJ (ORCPT ); Mon, 29 Oct 2018 13:37:09 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w9T8nQBL030849; Mon, 29 Oct 2018 08:49:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id; s=corp-2018-07-02; bh=twlili5HFbkeN1MoU2fTFQw0Qt+lh6aOhHr2ibGMVaE=; b=dM7T6AX2aL7pBdORcxVoLTEKm4BC5UHDNexg5Cfk8/Y7IPuXqTkIdPYJdk/wPdIox4qZ 2n1/45v6Mt7C62BrPEwu8OFB77YCgcBeUuPN4qDb/CGMIobIIs4OqRw/rsLgrH89fUxd 0qgSi8ACGkCYY8CI3MJNWPcgaA3d/r51VeXTeWjdwOP+76SZyCs+63YI9khfwBXkb60i /n30FLE9bd50m0BKiHhx02K5Awo4H+9i8/GK5bSFhS6pBrURAc4USE+NiyzToDCInC2Y GPYt0qhgztmKwF4zaGXviQXbXJSyM3x0JsoZynEuco3S2k7CucB5hYhK4GhLURYAB72o ZQ== Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp2130.oracle.com with ESMTP id 2nduckrxq7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 29 Oct 2018 08:49:26 +0000 Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w9T8nLwr002949 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 29 Oct 2018 08:49:21 GMT Received: from abhmp0011.oracle.com (abhmp0011.oracle.com [141.146.116.17]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id w9T8nKhw017037; Mon, 29 Oct 2018 08:49:20 GMT Received: from will-ThinkCentre-M93p.cn.oracle.com (/10.182.70.234) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 29 Oct 2018 01:49:20 -0700 From: Jianchao Wang To: axboe@kernel.dk Cc: ming.lei@redhat.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH RESENT V3 0/4] blk-mq: refactor and fix on issue request directly Date: Mon, 29 Oct 2018 16:49:07 +0800 Message-Id: <1540802951-5408-1-git-send-email-jianchao.w.wang@oracle.com> X-Mailer: git-send-email 2.7.4 X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9060 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=1 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=982 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1810290085 Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Jens The 1st patch refactors the code of issue request directly. It merges the blk_mq_try_issue_directly and __blk_mq_try_issue_directly and make it handle the return value of .queue_rq itself. The 2nd patch let the requests be inserted into hctx->dispatch when the queue is stopped or quiesced if bypass_insert is true. The 3rd patch make blk_mq_sched_insert_requests issue requests directly with 'bypass_insert' false, then it needn't to handle the non-issued requests any more. The 4th patch ensures the hctx to be ran on its mapped cpu in issue directly path. V3: - Correct the code about the case bypass_insert is true and io scheduler attached. The request still need to be issued in case above. (1/4) - Refactor the code to make code clearer. blk_mq_make_request is introduced to decide insert, end or just return based on the return value of .queue_rq and bypass_insert (1/4) - Add the 2nd patch. It introduce a new decision result which indicates to insert request with blk_mq_request_bypass_insert. - Modify the code to adapt the new patch 1. V2: - Add 1st and 2nd patch Jianchao Wang(4) blk-mq: refactor the code of issue request directly blk-mq: insert request without involving any io blk-mq: issue directly with bypass_insert 'false' in blk-mq: ensure hctx to be ran on mapped cpu when issue block/blk-mq-sched.c | 8 ++- block/blk-mq.c | 139 ++++++++++++++++++++++++++++++--------------------- 2 files changed, 86 insertions(+), 61 deletions(-) Thanks Jianchao