From patchwork Mon Nov 12 09:23:23 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "jianchao.wang" X-Patchwork-Id: 10678359 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9AD6213AD for ; Mon, 12 Nov 2018 09:24:14 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 80F7E29FA5 for ; Mon, 12 Nov 2018 09:24:14 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 752E729FAA; Mon, 12 Nov 2018 09:24:14 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 12B4F29FA5 for ; Mon, 12 Nov 2018 09:24:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728416AbeKLTQd (ORCPT ); Mon, 12 Nov 2018 14:16:33 -0500 Received: from userp2120.oracle.com ([156.151.31.85]:55390 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726161AbeKLTQc (ORCPT ); Mon, 12 Nov 2018 14:16:32 -0500 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id wAC9O923073750; Mon, 12 Nov 2018 09:24:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id; s=corp-2018-07-02; bh=2Rxx6LFDsq5RehpIELMoUCvnNy05rGpaDq5aAXdH/A8=; b=lI+GVAHb9qWWPSt4GFWobFdCBjtD06ixOisu0+6/of3hH54+2xBocC46uNwL2crTBtOG +hpiDLwfneLvk06FBmKj7FktUtkKQFBJ/7ML9ylYKUjemljGw223r0FFKiZswzbGWOmM NRV4ae9N8DRV4CoU9sMh5jDupiBh0FIcSO5SaE7WcpYdwmXTaeqoUtyGpWPT++3rBTvW EHsqJ7LXhNxmRP9h0yGsDBJDhpgiaX3348F2jwsdrqdBh8HAJPPawTm0NnYLspLTq5WR D7lc15W7CXDUbMMc+8cVXmXr4iE2ArFTwWZkRqZ7PNOQNqlY2fVZkXeedn3WB0lWtGnR yA== Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by userp2120.oracle.com with ESMTP id 2nnwc0c4kb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 12 Nov 2018 09:24:09 +0000 Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id wAC9O8UA009774 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 12 Nov 2018 09:24:08 GMT Received: from abhmp0012.oracle.com (abhmp0012.oracle.com [141.146.116.18]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id wAC9O6nT007182; Mon, 12 Nov 2018 09:24:08 GMT Received: from will-ThinkCentre-M93p.cn.oracle.com (/10.182.70.234) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 12 Nov 2018 01:24:05 -0800 From: Jianchao Wang To: axboe@kernel.dk Cc: ming.lei@redhat.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH V5 0/6] blk-mq: refactor and fix on issue request directly Date: Mon, 12 Nov 2018 17:23:23 +0800 Message-Id: <1542014609-1769-1-git-send-email-jianchao.w.wang@oracle.com> X-Mailer: git-send-email 2.7.4 X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9074 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=1 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1811120086 Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Jens Please consider this patchset for 4.21. It refactors the code of issue request directly to unify the interface and make the code clearer and more readable, and also fixes two defects there. The 1st patch make __blk_mq_issue_directly be able to accept NULL cookie pointer then we needn't the dummy unused_cookie. The 2nd patch refactors the code of issue request directly to unify the helper interface which could handle all the cases. The 3rd patch fix the issue that when queue is stopped or quiesced request may pass through bottom device's potential io scheduler. The 4th patch fix the issue that hctx maybe ran on a cpu where it is not mapped in issue directly path. The 5th patch make blk_mq_sched_insert_requests issue requests directly with 'bypass' false, then it needn't to handle the non-issued requests any more. The 6th patch replace and kill the one line blk_mq_request_issue_directly. V5: - rebase against Jens' for-4.21/block branch - adjust the order of patch04 and patch05 - add patch06 to replace and kill the one line blk_mq_request_bypass_insert - comment changes V4: - split the original patch 1 into two patches, 1st and 2nd patch currently - rename the mq_decision to mq_issue_decision - comment changes V3: - Correct the code about the case bypass_insert is true and io scheduler attached. The request still need to be issued in case above. (1/4) - Refactor the code to make code clearer. blk_mq_make_request is introduced to decide insert, end or just return based on the return value of .queue_rq and bypass_insert (1/4) - Add the 2nd patch. It introduce a new decision result which indicates to insert request with blk_mq_request_bypass_insert. - Modify the code to adapt the new patch 1. V2: - Add 1st and 2nd patch to refactor the code. Jianchao Wang(6) blk-mq: make __blk_mq_issue_directly be able to accept NULL cookie pointer blk-mq: refactor the code of issue request directly blk-mq: fix issue directly case when q is stopped or quiesced blk-mq: ensure hctx to be ran on mapped cpu when issue directly blk-mq: issue directly with bypass 'false' in blk_mq_sched_insert_requests blk-mq: replace and kill blk_mq_request_issue_directly block/blk-core.c | 2 +- block/blk-mq-sched.c | 8 +-- block/blk-mq.c | 156 +++++++++++++++++++++++++++++---------------------- block/blk-mq.h | 6 +- 4 files changed, 97 insertions(+), 75 deletions(-) Thanks Jianchao