[v3,0/2] loop: fix two issues introduced by prior commit

Message

Dongli Zhang Feb. 22, 2019, 2:10 p.m. UTC

This patch set fix two issues introduced by prior commit.


[PATCH v3 1/2] loop: do not print warn message if partition scan is successful
[PATCH v3 1/2] fixes d57f3374ba48 ("loop: Move special partition reread
handling in loop_clr_fd()") to not always print warn message even when
partition scan is successful.


[PATCH v3 2/2] loop: set GENHD_FL_NO_PART_SCAN after blkdev_reread_part()
[PATCH v3 2/2] fixes 0da03cab87e6 ("loop: Fix deadlock when calling
blkdev_reread_part()") to not set GENHD_FL_NO_PART_SCAN before partition
scan when detaching loop device from the file.

Changed since v1:
  * move the setting of lo->lo_state to Lo_unbound after partscan has finished as well
    (suggested by Jan Kara)

Changed since v2:
  * Put the code inline in __loop_clr_fd() but not introduce new function
    (suggested by Jan Kara)


Dongli Zhang

Comments

Jens Axboe Feb. 22, 2019, 10:51 p.m. UTC | #1

On 2/22/19 7:10 AM, Dongli Zhang wrote:
> This patch set fix two issues introduced by prior commit.
> 
> 
> [PATCH v3 1/2] loop: do not print warn message if partition scan is successful
> [PATCH v3 1/2] fixes d57f3374ba48 ("loop: Move special partition reread
> handling in loop_clr_fd()") to not always print warn message even when
> partition scan is successful.
> 
> 
> [PATCH v3 2/2] loop: set GENHD_FL_NO_PART_SCAN after blkdev_reread_part()
> [PATCH v3 2/2] fixes 0da03cab87e6 ("loop: Fix deadlock when calling
> blkdev_reread_part()") to not set GENHD_FL_NO_PART_SCAN before partition
> scan when detaching loop device from the file.
> 
> Changed since v1:
>   * move the setting of lo->lo_state to Lo_unbound after partscan has finished as well
>     (suggested by Jan Kara)
> 
> Changed since v2:
>   * Put the code inline in __loop_clr_fd() but not introduce new function
>     (suggested by Jan Kara)

Applied, thanks.