From patchwork Fri Sep 21 20:31:14 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 10610927 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4E3B1112B for ; Fri, 21 Sep 2018 20:31:44 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 336DE2E7A5 for ; Fri, 21 Sep 2018 20:31:44 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 26DF92E7AF; Fri, 21 Sep 2018 20:31:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2E1DF2E7B6 for ; Fri, 21 Sep 2018 20:31:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391251AbeIVCWN (ORCPT ); Fri, 21 Sep 2018 22:22:13 -0400 Received: from out002.mailprotect.be ([83.217.72.86]:36437 "EHLO out002.mailprotect.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391243AbeIVCWN (ORCPT ); Fri, 21 Sep 2018 22:22:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mailprotect.be; s=mail; h=Content-Transfer-Encoding:MIME-Version:Message-Id :Date:Subject:Cc:To:From:reply-to:sender:bcc:in-reply-to:references: content-type; bh=Q0B2ZstGxOLd37APK6GLSS9pmTWCde8oDP/KtPfy9hc=; b=HHbYDSRUzaTJ pFog3+DVRroemCEqrWSgXxvy3WTi9RwZra/wbOz9mF5BP5STyX21GPZtHGLiqm61KRc0ONzqPX4YJ IKqXuwh5k0vAKNeVoJZyZ6+rGlWNoPtnYWwH2FeHRoZoGAQQ6lzvYl/CmTnhM0tKSs5KuDC3+tDaM u8+tim3Tw6yFw9a5+ZsMuovqIqlLtCJ/4IV31sF4d9nVf1XDpJyw7Vidlh74J/e9BAOiXWrZcwNJc 7bGWEUjOwMjpr45ThhegMA+m6AzrmUGUGiBUjmrvg5fcFvsU/xX/kFwF+yakptKbeUx1CPan8T6S8 pQJMtXvLWLTxt8zfg3najw==; Received: from smtp-auth.mailprotect.be ([178.208.39.159]) by com-mpt-out002.mailprotect.be with esmtp (Exim 4.89) (envelope-from ) id 1g3S5S-0008uy-BM; Fri, 21 Sep 2018 22:31:39 +0200 Received: from desktop-bart.svl.corp.google.com (unknown [104.133.8.89]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp-auth.mailprotect.be (Postfix) with ESMTPSA id AF861C05F3; Fri, 21 Sep 2018 22:31:36 +0200 (CEST) From: Bart Van Assche To: Jens Axboe Cc: linux-block@vger.kernel.org, Christoph Hellwig , Bart Van Assche Subject: [PATCH v10 0/8] blk-mq: Implement runtime power management Date: Fri, 21 Sep 2018 13:31:14 -0700 Message-Id: <20180921203122.49743-1-bvanassche@acm.org> X-Mailer: git-send-email 2.19.0.444.g18242da7ef-goog MIME-Version: 1.0 X-Originating-IP: 178.208.39.159 X-SpamExperts-Domain: mailprotect.be X-SpamExperts-Username: 178.208.39.128/27 Authentication-Results: mailprotect.be; auth=pass smtp.auth=178.208.39.128/27@mailprotect.be X-SpamExperts-Outgoing-Class: ham X-SpamExperts-Outgoing-Evidence: Combined (0.05) X-Recommended-Action: accept X-Filter-ID: EX5BVjFpneJeBchSMxfU5jts9ERVLRM0HegxBTDtieR602E9L7XzfQH6nu9C/Fh9KJzpNe6xgvOx q3u0UDjvO1tLifGj39bI0bcPyaJsYTaOqZpfO3PVJjdazu3l6Zm3CrxbKqqxVb1b/D8J7mjn9lDh ZuDehiH2YklRjLmWtDSmAEYI57h2mKAXM6QK99xqZOFbSD3u8HyLgGOQKCi94WnCbXmeX2Xd8NXE kUMqYlbilbHtbFYVmmyNP/jzd7CC6hBx0MWsIqDBZyeY119Okv3hl8yPfPdsT0UPQvdnVMOU8Zf+ B9qSJPzSsfZHWcrk0wiB5Hyfbd+MEJoOqabVUmvDy59pzP1iosV0DNWOAjtKmgPibyDvE1NrkqBr j5LVTAHvvK3wzc9xtICtqPlcxdKelFAlBm05iz5amJ7IrkWDVBIlfDzdqrCMCxk4PGeKWG7kK39p Pgyq7MfSXQHW36gux18SgkjQE1RDgqlo3I0LAao5RzCtd/nkTxNvxuZerjIfxK2tug+mEO2au1ST CTIzJvw9qxD5zQLggp7fQffzn6lW1kGYXc7LzqBLOOMBIK/1NH5THMtlYvyHAYGOGgjdb5hy4d8/ k+RlvkD7ATmoZ2kfng5rdXwjvpU4S+XAhVR1id1GLKHJBvyjlI1w1OhVceCu6itH4YpfzgAUZzmH JoezfzvwbuHdxNj4Sj7kVm0paVjt0XwXocuPHjmFTkCc0RxCf9FkbFgnW+3iFcf0oNABzQxwob1u +dNdIjp/ccBbl1BHkCySY+bm8ly/DcLFbWytmZzGUc1tNu77kJRQazMn6WLsmpwGaTF7LH61QGmn /0s7yNORlJsMuxx5wpuhQMLamj7Oyt2dC2MAv4mYtvnBMAb/PdseBrO5+sgb7mO7tb9j5FCrlct0 NDRE/+HQ8cQ5+hWV5O0279/I1JPrjuU3A3io6xJmD59iFVkb+AU6q1UwDsMQCbPquATGabyZS7Sc T75RjnQYc6HoKp6uedK/Z3MvnAyDmuOaA5CG/FxvddG4mRHKJlnoc+LvLMw4Oh2LkwsmIC+tUiJA U2G2XhkGbmsUNPNkere1WheN5NhD8uPe57LIJ6DJCG96zHB7HfKjI1eYNYaA4ur2/Is= X-Report-Abuse-To: spam@com-mpt-mgt001.mailprotect.be Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hello Jens, One of the pieces that is missing before blk-mq can be made the default is implementing runtime power management support for blk-mq. This patch series not only implements runtime power management for blk-mq but also fixes a starvation issue in the power management code for the legacy block layer. Please consider this patch series for the upstream kernel. Thanks, Bart. Changes compared to v9: - Left out the patches that document the functions that iterate over requests and also the patch that introduces blk_mq_queue_rq_iter(). - Simplified blk_pre_runtime_suspend(): left out the check whether no requests are in progress. - Fixed the race between blk_queue_enter(), queue freezing and runtime power management that Ming had identified. - Added a new patch that introduces percpu_ref_resurrect(). Changes compared to v8: - Fixed the race that was reported by Jianchao. - Fixed another spelling issue in a source code comment. Changes compared to v7: - Addressed Jianchao's feedback about patch "Make blk_get_request() block for non-PM requests while suspended". - Added two new patches - one that documents the functions that iterate over requests and one that introduces a new function that iterates over all requests associated with a queue. Changes compared to v6: - Left out the patches that split RQF_PREEMPT in three flags. - Left out the patch that introduces the SCSI device state SDEV_SUSPENDED. - Left out the patch that introduces blk_pm_runtime_exit(). - Restored the patch that changes the PREEMPT_ONLY flag into a counter. Changes compared to v5: - Introduced a new flag RQF_DV that replaces RQF_PREEMPT for SCSI domain validation. - Introduced a new request queue state QUEUE_FLAG_DV_ONLY for SCSI domain validation. - Instead of using SDEV_QUIESCE for both runtime suspend and SCSI domain validation, use that state for domain validation only and introduce a new state for runtime suspend, namely SDEV_QUIESCE. - Reallow system suspend during SCSI domain validation. - Moved the runtime resume call from the request allocation code into blk_queue_enter(). - Instead of relying on q_usage_counter, iterate over the tag set to determine whether or not any requests are in flight. Changes compared to v4: - Dropped the patches "Give RQF_PREEMPT back its original meaning" and "Serialize queue freezing and blk_pre_runtime_suspend()". - Replaced "percpu_ref_read()" with "percpu_is_in_use()". - Inserted pm_request_resume() calls in the block layer request allocation code such that the context that submits a request no longer has to call pm_runtime_get(). Changes compared to v3: - Avoid adverse interactions between system-wide suspend/resume and runtime power management by changing the PREEMPT_ONLY flag into a counter. - Give RQF_PREEMPT back its original meaning, namely that it is only set for ide_preempt requests. - Remove the flag BLK_MQ_REQ_PREEMPT. - Removed the pm_request_resume() call. Changes compared to v2: - Fixed the build for CONFIG_BLOCK=n. - Added a patch that introduces percpu_ref_read() in the percpu-counter code. - Added a patch that makes it easier to detect missing pm_runtime_get*() calls. - Addressed Jianchao's feedback including the comment about runtime overhead of switching a per-cpu counter to atomic mode. Changes compared to v1: - Moved the runtime power management code into a separate file. - Addressed Ming's feedback. Bart Van Assche (8): block: Move power management code into a new source file block, scsi: Change the preempt-only flag into a counter block: Split blk_pm_add_request() and blk_pm_put_request() block: Schedule runtime resume earlier percpu-refcount: Introduce percpu_ref_resurrect() block: Allow unfreezing of a queue while requests are in progress block: Make blk_get_request() block for non-PM requests while suspended blk-mq: Enable support for runtime power management block/Kconfig | 3 + block/Makefile | 1 + block/blk-core.c | 270 ++++---------------------------- block/blk-mq-debugfs.c | 10 +- block/blk-mq.c | 4 +- block/blk-pm.c | 216 +++++++++++++++++++++++++ block/blk-pm.h | 69 ++++++++ block/elevator.c | 22 +-- drivers/scsi/scsi_lib.c | 11 +- drivers/scsi/scsi_pm.c | 1 + drivers/scsi/sd.c | 1 + drivers/scsi/sr.c | 1 + include/linux/blk-pm.h | 24 +++ include/linux/blkdev.h | 37 ++--- include/linux/percpu-refcount.h | 1 + lib/percpu-refcount.c | 28 +++- 16 files changed, 401 insertions(+), 298 deletions(-) create mode 100644 block/blk-pm.c create mode 100644 block/blk-pm.h create mode 100644 include/linux/blk-pm.h Reviewed-by: Ming Lei