| Message ID | 20190123163049.24863-1-joro@8bytes.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | Fix virtio-blk issue with SWIOTLB | expand |
On Wed, Jan 23, 2019 at 05:30:44PM +0100, Joerg Roedel wrote: > Hi, > > here is the third version of this patch-set. Previous > versions can be found here: > > V1: https://lore.kernel.org/lkml/20190110134433.15672-1-joro@8bytes.org/ > > V2: https://lore.kernel.org/lkml/20190115132257.6426-1-joro@8bytes.org/ > > The problem solved here is a limitation of the SWIOTLB implementation, > which does not support allocations larger than 256kb. When the > virtio-blk driver tries to read/write a block larger than that, the > allocation of the dma-handle fails and an IO error is reported. > > Changes to v2 are: > > * Check if SWIOTLB is active before returning its limit in > dma_direct_max_mapping_size() > > * Only apply the maximum segment limit in virtio-blk when > DMA-API is used for the vring > > Please review. > > Thanks, > > Joerg > > Joerg Roedel (5): > swiotlb: Introduce swiotlb_max_mapping_size() > swiotlb: Add is_swiotlb_active() function > dma: Introduce dma_max_mapping_size() > virtio: Introduce virtio_max_dma_size() > virtio-blk: Consider virtio_max_dma_size() for maximum segment size > > drivers/block/virtio_blk.c | 10 ++++++---- > drivers/virtio/virtio_ring.c | 10 ++++++++++ The kvm-devel mailing list should have been copied on those. When you do can you please put 'Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>' on all of them? Thank you! P.S. Christopher, I am assuming you are OK with this idea, if so - and once the owners of 'virtio' Ack, do you want to put it in my tree? Thanks! > include/linux/dma-mapping.h | 16 ++++++++++++++++ > include/linux/swiotlb.h | 11 +++++++++++ > include/linux/virtio.h | 2 ++ > kernel/dma/direct.c | 11 +++++++++++ > kernel/dma/swiotlb.c | 10 ++++++++++ > 7 files changed, 66 insertions(+), 4 deletions(-) > > -- > 2.17.1 >
On Wed, Jan 23, 2019 at 05:30:44PM +0100, Joerg Roedel wrote: > Hi, > > here is the third version of this patch-set. Previous > versions can be found here: > > V1: https://lore.kernel.org/lkml/20190110134433.15672-1-joro@8bytes.org/ > > V2: https://lore.kernel.org/lkml/20190115132257.6426-1-joro@8bytes.org/ > > The problem solved here is a limitation of the SWIOTLB implementation, > which does not support allocations larger than 256kb. When the > virtio-blk driver tries to read/write a block larger than that, the > allocation of the dma-handle fails and an IO error is reported. OK looks good to me. I will park this in my tree for now this way it will get testing in linux-next. Can I get an ack from DMA maintainers on the DMA bits for merging this in 5.0? > Changes to v2 are: > > * Check if SWIOTLB is active before returning its limit in > dma_direct_max_mapping_size() > > * Only apply the maximum segment limit in virtio-blk when > DMA-API is used for the vring > > Please review. > > Thanks, > > Joerg > > Joerg Roedel (5): > swiotlb: Introduce swiotlb_max_mapping_size() > swiotlb: Add is_swiotlb_active() function > dma: Introduce dma_max_mapping_size() > virtio: Introduce virtio_max_dma_size() > virtio-blk: Consider virtio_max_dma_size() for maximum segment size > > drivers/block/virtio_blk.c | 10 ++++++---- > drivers/virtio/virtio_ring.c | 10 ++++++++++ > include/linux/dma-mapping.h | 16 ++++++++++++++++ > include/linux/swiotlb.h | 11 +++++++++++ > include/linux/virtio.h | 2 ++ > kernel/dma/direct.c | 11 +++++++++++ > kernel/dma/swiotlb.c | 10 ++++++++++ > 7 files changed, 66 insertions(+), 4 deletions(-) > > -- > 2.17.1
On Wed, Jan 23, 2019 at 01:51:29PM -0500, Michael S. Tsirkin wrote: > On Wed, Jan 23, 2019 at 05:30:44PM +0100, Joerg Roedel wrote: > > Hi, > > > > here is the third version of this patch-set. Previous > > versions can be found here: > > > > V1: https://lore.kernel.org/lkml/20190110134433.15672-1-joro@8bytes.org/ > > > > V2: https://lore.kernel.org/lkml/20190115132257.6426-1-joro@8bytes.org/ > > > > The problem solved here is a limitation of the SWIOTLB implementation, > > which does not support allocations larger than 256kb. When the > > virtio-blk driver tries to read/write a block larger than that, the > > allocation of the dma-handle fails and an IO error is reported. > > > OK looks good to me. > I will park this in my tree for now this way it will get > testing in linux-next. > Can I get an ack from DMA maintainers on the DMA bits for > merging this in 5.0? You got mine (SWIOTBL is my area). > > > Changes to v2 are: > > > > * Check if SWIOTLB is active before returning its limit in > > dma_direct_max_mapping_size() > > > > * Only apply the maximum segment limit in virtio-blk when > > DMA-API is used for the vring > > > > Please review. > > > > Thanks, > > > > Joerg > > > > Joerg Roedel (5): > > swiotlb: Introduce swiotlb_max_mapping_size() > > swiotlb: Add is_swiotlb_active() function > > dma: Introduce dma_max_mapping_size() > > virtio: Introduce virtio_max_dma_size() > > virtio-blk: Consider virtio_max_dma_size() for maximum segment size > > > > drivers/block/virtio_blk.c | 10 ++++++---- > > drivers/virtio/virtio_ring.c | 10 ++++++++++ > > include/linux/dma-mapping.h | 16 ++++++++++++++++ > > include/linux/swiotlb.h | 11 +++++++++++ > > include/linux/virtio.h | 2 ++ > > kernel/dma/direct.c | 11 +++++++++++ > > kernel/dma/swiotlb.c | 10 ++++++++++ > > 7 files changed, 66 insertions(+), 4 deletions(-) > > > > -- > > 2.17.1
On Wed, Jan 23, 2019 at 04:14:53PM -0500, Konrad Rzeszutek Wilk wrote: > On Wed, Jan 23, 2019 at 01:51:29PM -0500, Michael S. Tsirkin wrote: > > On Wed, Jan 23, 2019 at 05:30:44PM +0100, Joerg Roedel wrote: > > > Hi, > > > > > > here is the third version of this patch-set. Previous > > > versions can be found here: > > > > > > V1: https://lore.kernel.org/lkml/20190110134433.15672-1-joro@8bytes.org/ > > > > > > V2: https://lore.kernel.org/lkml/20190115132257.6426-1-joro@8bytes.org/ > > > > > > The problem solved here is a limitation of the SWIOTLB implementation, > > > which does not support allocations larger than 256kb. When the > > > virtio-blk driver tries to read/write a block larger than that, the > > > allocation of the dma-handle fails and an IO error is reported. > > > > > > OK looks good to me. > > I will park this in my tree for now this way it will get > > testing in linux-next. > > Can I get an ack from DMA maintainers on the DMA bits for > > merging this in 5.0? > > You got mine (SWIOTBL is my area). OK so Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> > > > > > Changes to v2 are: > > > > > > * Check if SWIOTLB is active before returning its limit in > > > dma_direct_max_mapping_size() > > > > > > * Only apply the maximum segment limit in virtio-blk when > > > DMA-API is used for the vring > > > > > > Please review. > > > > > > Thanks, > > > > > > Joerg > > > > > > Joerg Roedel (5): > > > swiotlb: Introduce swiotlb_max_mapping_size() > > > swiotlb: Add is_swiotlb_active() function > > > dma: Introduce dma_max_mapping_size() > > > virtio: Introduce virtio_max_dma_size() > > > virtio-blk: Consider virtio_max_dma_size() for maximum segment size > > > > > > drivers/block/virtio_blk.c | 10 ++++++---- > > > drivers/virtio/virtio_ring.c | 10 ++++++++++ > > > include/linux/dma-mapping.h | 16 ++++++++++++++++ > > > include/linux/swiotlb.h | 11 +++++++++++ > > > include/linux/virtio.h | 2 ++ > > > kernel/dma/direct.c | 11 +++++++++++ > > > kernel/dma/swiotlb.c | 10 ++++++++++ > > > 7 files changed, 66 insertions(+), 4 deletions(-) > > > > > > -- > > > 2.17.1
On Mon, Jan 28, 2019 at 10:20:05AM -0500, Michael S. Tsirkin wrote: > On Wed, Jan 23, 2019 at 04:14:53PM -0500, Konrad Rzeszutek Wilk wrote: > > On Wed, Jan 23, 2019 at 01:51:29PM -0500, Michael S. Tsirkin wrote: > > > On Wed, Jan 23, 2019 at 05:30:44PM +0100, Joerg Roedel wrote: > > > > Hi, > > > > > > > > here is the third version of this patch-set. Previous > > > > versions can be found here: > > > > > > > > V1: https://lore.kernel.org/lkml/20190110134433.15672-1-joro@8bytes.org/ > > > > > > > > V2: https://lore.kernel.org/lkml/20190115132257.6426-1-joro@8bytes.org/ > > > > > > > > The problem solved here is a limitation of the SWIOTLB implementation, > > > > which does not support allocations larger than 256kb. When the > > > > virtio-blk driver tries to read/write a block larger than that, the > > > > allocation of the dma-handle fails and an IO error is reported. > > > > > > > > > OK looks good to me. > > > I will park this in my tree for now this way it will get > > > testing in linux-next. > > > Can I get an ack from DMA maintainers on the DMA bits for > > > merging this in 5.0? > > > > You got mine (SWIOTBL is my area). > > OK so > > Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> Yes :-) > > > > > > > > > > Changes to v2 are: > > > > > > > > * Check if SWIOTLB is active before returning its limit in > > > > dma_direct_max_mapping_size() > > > > > > > > * Only apply the maximum segment limit in virtio-blk when > > > > DMA-API is used for the vring > > > > > > > > Please review. > > > > > > > > Thanks, > > > > > > > > Joerg > > > > > > > > Joerg Roedel (5): > > > > swiotlb: Introduce swiotlb_max_mapping_size() > > > > swiotlb: Add is_swiotlb_active() function > > > > dma: Introduce dma_max_mapping_size() > > > > virtio: Introduce virtio_max_dma_size() > > > > virtio-blk: Consider virtio_max_dma_size() for maximum segment size > > > > > > > > drivers/block/virtio_blk.c | 10 ++++++---- > > > > drivers/virtio/virtio_ring.c | 10 ++++++++++ > > > > include/linux/dma-mapping.h | 16 ++++++++++++++++ > > > > include/linux/swiotlb.h | 11 +++++++++++ > > > > include/linux/virtio.h | 2 ++ > > > > kernel/dma/direct.c | 11 +++++++++++ > > > > kernel/dma/swiotlb.c | 10 ++++++++++ > > > > 7 files changed, 66 insertions(+), 4 deletions(-) > > > > > > > > -- > > > > 2.17.1