From patchwork Mon Jan 28 13:14:43 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shin'ichiro Kawasaki X-Patchwork-Id: 10783673 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 00FFF1390 for ; Mon, 28 Jan 2019 13:15:03 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E157C2A82A for ; Mon, 28 Jan 2019 13:15:02 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CE7A62AA57; Mon, 28 Jan 2019 13:15:02 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 448D82A82A for ; Mon, 28 Jan 2019 13:15:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726719AbfA1NPB (ORCPT ); Mon, 28 Jan 2019 08:15:01 -0500 Received: from esa3.hgst.iphmx.com ([216.71.153.141]:31555 "EHLO esa3.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726647AbfA1NPB (ORCPT ); Mon, 28 Jan 2019 08:15:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1548681300; x=1580217300; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=gePm98OGpYqxkqUmEVNHuWrHtxlVjXBWz1NYO1Y3eP0=; b=dMPoUprZQkZ0SHHM7EX7SlVIwyWIW4rE3fZ4z4/BLRjnw+27LyGcQ2X8 X+EaYfIWiJOkEm3WUNpu9SjMKwSpz6GNW8YYGZuEjf02bzzS71zBKuWDk uFcaT8t+qQYM+HoWdtOudCWaqzvndjSlWragZsRqIcuBFKCT0yPBjSgxF cwBZ4LHXRHx3f78nFvH2S8LDMu4KKniaHZBWmT0l+WA4UFjJDIQEAzgLv WJtNjNOGvDKFf/miOZ/hqwZzK6XEfvu/YWXAEovgmlU6MXiw0Gxlz1F5I KogI4ZW6Aiu4gMD36LV2g2+QUnGv8l62a2PfJxuRWKrcMfwR6gywcfW5V A==; X-IronPort-AV: E=Sophos;i="5.56,534,1539619200"; d="scan'208";a="104898821" Received: from uls-op-cesaip01.wdc.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 28 Jan 2019 21:15:00 +0800 Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP; 28 Jan 2019 04:54:03 -0800 Received: from shin_dev.dhcp.fujisawa.hgst.com (HELO shin_dev.fujisawa.hgst.com) ([10.149.52.166]) by uls-op-cesaip02.wdc.com with ESMTP; 28 Jan 2019 05:14:57 -0800 From: Shin'ichiro Kawasaki To: linux-block@vger.kernel.org, Omar Sandoval , Masato Suzuki , Shinichiro Kawasaki Cc: Omar Sandoval , Jens Axboe , Matias Bjorling , Hannes Reinecke , Mike Snitzer , "Martin K . Petersen" , Damien Le Moal , Chaitanya Kulkarni Subject: [PATCH blktests v4 00/12] Implement zoned block device support Date: Mon, 28 Jan 2019 22:14:43 +0900 Message-Id: <20190128131455.31997-1-shinichiro.kawasaki@wdc.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The current blktests infrastucture and test cases do not support zoned block devices and no specific test cases exist to test these block devices special features (zone report and reset, sequential write constraint). This patch series implement this missing support. The series addresses two aspects: the first 4 patches introduce changes to the common scripts and configuration to allow existing test cases to run against a null_blk device with zone mode enabled (new RUN_ZONED_TESTS config variable) as well as whitelisting tests that can support zoned block devices (new CAN_BE_ZONED test flag). Helper functions are introduced to facilitate checking a device zone model. The second part, composed of the last 8 patches, introduce the new zbd test group to cover zoned block device specific test cases. All these test cases are implemented using the test_device() function so that target devices can be specified in the TEST_DEVS config variable, to cover a variety of zoned block devices: physical real drives, partitions and dm-linear setups on top of zoned block devices, etc. Furthermore, using the infrastructure changes of the first part, the TEST_DEVS definition can be left empty, resulting in the zbd test cases to be run against an automatically created null_blk device with zoned mode enabled. 5 test cases are added to the new zbd test group to check the kernel ioctl and sysfs interface, zone report operation, zone reset and write command handling. These tests are simple but only a start. We will in the future send more test cases to cover at least the regressions and bugs found and fixed in the zoned block device code since its introduction with kernel 4.10. Another still to be added part is support for host-managed ZBC emulation in scsi-debug to further improve test coverage without requiring a physical SMR disk. This work is ongoing and will be added to blktests once the relevant scsi-debug changes are accepted in the kernel. Changes from v3: * Dropped _dd() * Addressed various nit commented on the list Changes from v2: * Replaced ZONED with RUN_FOR_ZONED and CAN_BE_ZONED variables * Introduce fallback_device mechanism instead of relying on group rc script * Dropped set_scheduler() move to common Changes from v1: * Fixed _test_dev_is_zoned * Added _have_fio_zbd_zonemode * Added patch 10 to move _dd to common/rc * Addressed various nit commented on the list Masato Suzuki (6): tests: Introduce zbd test group zbd/001: sysfs and ioctl consistency test zbd/002: report zone test zbd/003: Test sequential zones reset zbd/004: Check write split accross sequential zones zbd/005: Test write ordering Shin'ichiro Kawasaki (6): config: Introduce RUN_ZONED_TESTS variable and CAN_BE_ZONED flag common: Introduce _have_fio_zbd_zonemode() helper function block/004: Adjust fio conditions for zoned block devices block: Whitelist tests supporting zoned block devices check: Introduce fallback_device() and cleanup_fallback_device() src: Introduce zbdioctl program Documentation/running-tests.md | 11 ++ check | 64 ++++++++++- common/fio | 9 ++ common/null_blk | 10 +- common/shellcheck | 2 +- new | 4 + src/.gitignore | 1 + src/Makefile | 3 +- src/zbdioctl.c | 83 ++++++++++++++ tests/block/004 | 16 ++- tests/block/005 | 1 + tests/block/006 | 1 + tests/block/010 | 1 + tests/block/011 | 1 + tests/block/016 | 1 + tests/block/017 | 1 + tests/block/020 | 1 + tests/block/021 | 1 + tests/block/023 | 1 + tests/zbd/001 | 75 +++++++++++++ tests/zbd/001.out | 2 + tests/zbd/002 | 108 ++++++++++++++++++ tests/zbd/002.out | 2 + tests/zbd/003 | 82 ++++++++++++++ tests/zbd/003.out | 2 + tests/zbd/004 | 99 +++++++++++++++++ tests/zbd/004.out | 2 + tests/zbd/005 | 67 +++++++++++ tests/zbd/005.out | 2 + tests/zbd/rc | 195 +++++++++++++++++++++++++++++++++ 30 files changed, 841 insertions(+), 7 deletions(-) create mode 100644 src/zbdioctl.c create mode 100755 tests/zbd/001 create mode 100644 tests/zbd/001.out create mode 100755 tests/zbd/002 create mode 100644 tests/zbd/002.out create mode 100755 tests/zbd/003 create mode 100644 tests/zbd/003.out create mode 100755 tests/zbd/004 create mode 100644 tests/zbd/004.out create mode 100755 tests/zbd/005 create mode 100644 tests/zbd/005.out create mode 100644 tests/zbd/rc