[v2,0/8] lightnvm: bugfixes and improvements

Message

Igor Konopko March 5, 2019, 1:51 p.m. UTC

This series provides a group of the bugfixes or improvements
for lightnvm and pblk device.

Most of the patches are rather simple and covers some corner cases
scenario, but we were able to hit most of them in some scenarios.
Few others close some existing gaps which we were able to found.

Changes v2->v1:
-skipped patches which were applied in v1
-dropped not needed patch for pblk_should_kick_write()
-patch which scan for opened chunks on pblk creation do not close
chunk anymore, just print the warning
-unknown read errors are counted seperately from read unrecoverable

Igor Konopko (8):
  lightnvm: pblk: Gracefully handle GC vmalloc fail
  lightnvm: pblk: Fix put line back behaviour
  lightnvm: pblk: Count all read errors in stats
  lightnvm: pblk: Ensure that erase is chunk aligned
  lightnvm: pblk: Cleanly fail when there is not enough memory
  lightnvm: pblk: Set proper read stutus in bio
  lightnvm: pblk: warn about opened chunk on factory init
  lightnvm: Inherit mdts from the parent nvme device

 drivers/lightnvm/core.c       |  9 +++++++--
 drivers/lightnvm/pblk-core.c  | 15 +++++++++++++++
 drivers/lightnvm/pblk-gc.c    | 35 +++++++++++++++++++----------------
 drivers/lightnvm/pblk-init.c  | 24 +++++++++++++++++++-----
 drivers/lightnvm/pblk-map.c   |  1 +
 drivers/lightnvm/pblk-read.c  | 11 +++++------
 drivers/lightnvm/pblk-sysfs.c |  3 ++-
 drivers/lightnvm/pblk.h       |  2 ++
 drivers/nvme/host/lightnvm.c  |  1 +
 include/linux/lightnvm.h      |  1 +
 10 files changed, 72 insertions(+), 30 deletions(-)

Comments

Matias Bjorling March 9, 2019, 4:56 p.m. UTC | #1

On 3/5/19 2:51 PM, Igor Konopko wrote:
> This series provides a group of the bugfixes or improvements
> for lightnvm and pblk device.
> 
> Most of the patches are rather simple and covers some corner cases
> scenario, but we were able to hit most of them in some scenarios.
> Few others close some existing gaps which we were able to found.
> 
> Changes v2->v1:
> -skipped patches which were applied in v1
> -dropped not needed patch for pblk_should_kick_write()
> -patch which scan for opened chunks on pblk creation do not close
> chunk anymore, just print the warning
> -unknown read errors are counted seperately from read unrecoverable
> 
> Igor Konopko (8):
>    lightnvm: pblk: Gracefully handle GC vmalloc fail
>    lightnvm: pblk: Fix put line back behaviour
>    lightnvm: pblk: Count all read errors in stats
>    lightnvm: pblk: Ensure that erase is chunk aligned
>    lightnvm: pblk: Cleanly fail when there is not enough memory
>    lightnvm: pblk: Set proper read stutus in bio
>    lightnvm: pblk: warn about opened chunk on factory init
>    lightnvm: Inherit mdts from the parent nvme device
> 
>   drivers/lightnvm/core.c       |  9 +++++++--
>   drivers/lightnvm/pblk-core.c  | 15 +++++++++++++++
>   drivers/lightnvm/pblk-gc.c    | 35 +++++++++++++++++++----------------
>   drivers/lightnvm/pblk-init.c  | 24 +++++++++++++++++++-----
>   drivers/lightnvm/pblk-map.c   |  1 +
>   drivers/lightnvm/pblk-read.c  | 11 +++++------
>   drivers/lightnvm/pblk-sysfs.c |  3 ++-
>   drivers/lightnvm/pblk.h       |  2 ++
>   drivers/nvme/host/lightnvm.c  |  1 +
>   include/linux/lightnvm.h      |  1 +
>   10 files changed, 72 insertions(+), 30 deletions(-)
> 

Thanks Igor. Thanks Javier and Hans for the reviews.

I've picked up 1, 2, 4, 5, 6, and 8. Note that I've lower-cased the 
first letter after "lightnvm: pblk:" in the patches, and also updated 
the wording a bit when appropriate.