[V2,0/2] block: improve print_req_error

Message

Chaitanya Kulkarni June 13, 2019, 2:16 p.m. UTC

Hi,

This patch-series is based on the initial patch posted by 
Christoph Hellwig <[e-mail]>. I've added one more patch to improve
print message.

While debugging the driver and block layer this print message is very
handy.

Please consider this for 5.3.

Following is the sample error message with forced REQ_OP_WRITE,
REQ_OP_WRITE_ZEROES and REQ_OP_DISCARD failure from modified null_blk
for testing :-

 blk_update_request: I/O error, dev nullb0, sector 0 op 0x9:(WRITE_ZEROES) flags 0x400800 phys_seg 0 prio class 0
 blk_update_request: I/O error, dev nullb0, sector 0 op 0x3:(DISCARD) flags 0x800 phys_seg 1 prio class 0
 blk_update_request: I/O error, dev nullb0, sector 0 op 0x1:(WRITE) flags 0x800 phys_seg 1 prio class 0

I've fixed all the review comments except the one for which we want to
use the newly added function in the include/trace/events/f2fs.h as f2fs
code is highly coupled with the tracing structures. I'll make a separate
patch for that change as needed.

Thanks,
-Chaitanya

Changes from V1:-
1. Get rid of the function switch case and use the passtern similar to
   block/blk-mq-debuffs.c(Bart).

Chaitanya Kulkarni (1):
  block: add more debug data to print_req_err

Christoph Hellwig (1):
  block: improve print_req_error

 block/blk-core.c | 45 ++++++++++++++++++++++++++++++++++++++-------
 1 file changed, 38 insertions(+), 7 deletions(-)